From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, hch@infradead.org,
chandanrlinux@gmail.com
Subject: Re: [PATCH 2/3] xfs: print name of function causing fs shutdown instead of hex pointer
Date: Mon, 21 Jun 2021 08:24:12 +1000 [thread overview]
Message-ID: <20210620222412.GQ664593@dread.disaster.area> (raw)
In-Reply-To: <162404244503.2377241.5074228710477395763.stgit@locust>
On Fri, Jun 18, 2021 at 11:54:05AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> In xfs_do_force_shutdown, print the symbolic name of the function that
> called us to shut down the filesystem instead of a raw hex pointer.
> This makes debugging a lot easier:
>
> XFS (sda): xfs_do_force_shutdown(0x2) called from line 2440 of file
> fs/xfs/xfs_log.c. Return address = ffffffffa038bc38
>
> becomes:
>
> XFS (sda): xfs_do_force_shutdown(0x2) called from line 2440 of file
> fs/xfs/xfs_log.c. Return address = xfs_trans_mod_sb+0x25
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Makes sense.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-06-20 22:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 18:53 [PATCHSET v2 0/3] xfs: various small fixes and cleanups Darrick J. Wong
2021-06-18 18:53 ` [PATCH 1/3] xfs: fix type mismatches in the inode reclaim functions Darrick J. Wong
2021-06-20 22:23 ` Dave Chinner
2021-06-18 18:54 ` [PATCH 2/3] xfs: print name of function causing fs shutdown instead of hex pointer Darrick J. Wong
2021-06-20 22:24 ` Dave Chinner [this message]
2021-06-21 4:41 ` Chandan Babu R
2021-06-21 5:26 ` Christoph Hellwig
2021-06-18 18:54 ` [PATCH 3/3] xfs: shorten the shutdown messages to a single line Darrick J. Wong
2021-06-20 22:29 ` Dave Chinner
2021-06-21 4:41 ` Chandan Babu R
2021-06-21 5:30 ` Christoph Hellwig
2021-06-21 6:02 ` Dave Chinner
2021-06-21 6:06 ` Christoph Hellwig
2021-06-21 6:29 ` Dave Chinner
2021-06-21 16:56 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210620222412.GQ664593@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=chandanrlinux@gmail.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.