All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Leon Romanovsky <leonro@nvidia.com>,
	Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Jack Wang <jinpu.wang@ionos.com>, Lijun Ou <oulijun@huawei.com>,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	Max Gurtovoy <mgurtovoy@nvidia.com>,
	"Md. Haris Iqbal" <haris.iqbal@ionos.com>,
	Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	Weihang Li <liweihang@huawei.com>
Subject: Re: [PATCH rdma-next v2] RDMA: Fix kernel-doc warnings about wrong comment
Date: Mon, 21 Jun 2021 20:52:29 -0300	[thread overview]
Message-ID: <20210621235229.GA2374294@nvidia.com> (raw)
In-Reply-To: <e57d5f4ddd08b7a19934635b44d6d632841b9ba7.1623823612.git.leonro@nvidia.com>

On Wed, Jun 16, 2021 at 09:09:47AM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
> 
> Compilation with W=1 produces warnings similar to the below.
> 
>   drivers/infiniband/ulp/ipoib/ipoib_main.c:320: warning: This comment
> 	starts with '/**', but isn't a kernel-doc comment. Refer
> 	Documentation/doc-guide/kernel-doc.rst
> 
> All such occurrences were found with the following one line
>  git grep -A 1 "\/\*\*" drivers/infiniband/
> 
> Reviewed-by: Jack Wang <jinpu.wang@ionos.com> #rtrs
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
>  Changelog:
>  v1 https://lore.kernel.org/lkml/8b40bbff098247962af5a7b35d47b2e964daa523.1622726066.git.leonro@nvidia.com
>  * Found two extra places in hns_roce_hem.c
>  * Added Dennis's ROB
>  v0 https://lore.kernel.org/lkml/635def71048cbffe76e2dd324cf420d8a465ee9d.1622460676.git.leonro@nvidia.com:
>  * Rebased to drop i40iw
>  * Added Jack's ROB
> ---
>  drivers/infiniband/core/iwpm_util.h       | 2 +-
>  drivers/infiniband/core/roce_gid_mgmt.c   | 5 +++--
>  drivers/infiniband/hw/hfi1/chip.c         | 4 ++--
>  drivers/infiniband/hw/hfi1/file_ops.c     | 6 +++---
>  drivers/infiniband/hw/hfi1/hfi.h          | 2 +-
>  drivers/infiniband/hw/hfi1/init.c         | 4 ++--
>  drivers/infiniband/hw/hfi1/pio.c          | 2 +-
>  drivers/infiniband/hw/hns/hns_roce_hem.c  | 4 ++--
>  drivers/infiniband/sw/rdmavt/mr.c         | 4 ++--
>  drivers/infiniband/sw/rdmavt/qp.c         | 3 ++-
>  drivers/infiniband/sw/rdmavt/vt.c         | 4 ++--
>  drivers/infiniband/ulp/ipoib/ipoib_main.c | 7 ++++---
>  drivers/infiniband/ulp/iser/iser_verbs.c  | 2 +-
>  drivers/infiniband/ulp/isert/ib_isert.c   | 4 ++--
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c    | 4 ++--
>  drivers/infiniband/ulp/rtrs/rtrs-srv.c    | 2 +-
>  16 files changed, 31 insertions(+), 28 deletions(-)

Applied to for-next, thanks

Jason

      reply	other threads:[~2021-06-21 23:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  6:09 [PATCH rdma-next v2] RDMA: Fix kernel-doc warnings about wrong comment Leon Romanovsky
2021-06-21 23:52 ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210621235229.GA2374294@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=dledford@redhat.com \
    --cc=haris.iqbal@ionos.com \
    --cc=jinpu.wang@ionos.com \
    --cc=leon@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=liweihang@huawei.com \
    --cc=mgurtovoy@nvidia.com \
    --cc=mike.marciniszyn@cornelisnetworks.com \
    --cc=oulijun@huawei.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.