From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528BAC49EA6 for ; Thu, 24 Jun 2021 13:52:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1249A61351 for ; Thu, 24 Jun 2021 13:52:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1249A61351 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41334 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwPmT-0005pz-7X for qemu-devel@archiver.kernel.org; Thu, 24 Jun 2021 09:52:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwPlk-000593-6D for qemu-devel@nongnu.org; Thu, 24 Jun 2021 09:51:48 -0400 Received: from rev.ng ([5.9.113.41]:49095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwPli-0001Gd-7x for qemu-devel@nongnu.org; Thu, 24 Jun 2021 09:51:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7ybpSyg5v4jxa3vDDoPgyvIRimcGYoj776w4LUX26Aw=; b=dHHjBtRXQRPle93hhO3PsDhr3n GOLW6O4hwZ4sNgG/tl8/5OKmnvHlpSGI64rWEwhnDY9DU3TQe710m6HI0OogABm7vVHU82yOouSYs jqaJCXPsFrCfdsmJjWPgkckdgYx4TbnFjff6gFArHastRf7wbK9jGDadVyzDR9p3mYOU=; Date: Thu, 24 Jun 2021 15:51:31 +0200 To: Taylor Simpson Cc: "qemu-devel@nongnu.org" , Brian Cain , "babush@rev.ng" , "nizzo@rev.ng" , "philmd@redhat.com" , "richard.henderson@linaro.org" Subject: Re: [PATCH v5 03/14] target/hexagon: import README for idef-parser Message-ID: <20210624155131.0523ab28@orange> In-Reply-To: References: <20210619093713.1845446-1-ale.qemu@rev.ng> <20210619093713.1845446-4-ale.qemu@rev.ng> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=5.9.113.41; envelope-from=ale@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Alessandro Di Federico From: Alessandro Di Federico via On Wed, 23 Jun 2021 15:46:22 +0000 Taylor Simpson wrote: > The output isn't actually indented, but it would be great if it were. > This is especially true for instructions where an "if" or "for" show > up in the emitted code. Emitting whitespaces in the parser is a bit annoying and fragile, but it can be done. We post-process the parser output with `indent` internally. We could run it after the output is produced, but that would mean a new dependency. I'd go for opportunistic indentation through `indent` if installed. > Is there a way to force the parser not to emit a particular > instruction (i.e., fall back on the reference implementation)? Yes, see `gen_idef_parser_funcs.py`. -- Alessandro Di Federico rev.ng