From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78D96C49EBE for ; Thu, 24 Jun 2021 22:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60743613AD for ; Thu, 24 Jun 2021 22:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232784AbhFXWw2 (ORCPT ); Thu, 24 Jun 2021 18:52:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:54528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232695AbhFXWwN (ORCPT ); Thu, 24 Jun 2021 18:52:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 286386135C; Thu, 24 Jun 2021 22:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624574994; bh=Do7JpeaMbcTZFmYRsJ6KflWqZQ5cEUS3jxE0VeBISec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KftG9LTMBq4EBxfDAXYFRYxvIic6GLpckd4GFs34LxG3LaieSh9UxRngbGqtcXXdI vDM+/kNx0FmKddqDDZYBmlWS1dxDQMpqasyV2BC3MOGzfjJ7HvIQpKxttYbiXMh2ew vQ5gpGK5kOJNIUXHTqipaHbBaJancGP3D6QxVO1lUOry391v7443wcAyUsRcqc0B7p WY9YitbrfNtAuF0uGe4CeYP0uy+4pMNMBKGDtFW96bPCaktQ/HJVUXjdWMyNzQ8vh4 +ptCcBOMMyScAhiy4YdeQEaAE7HfPfE94IWsQ2S7iV9pXvgxBx3/jd4A+A5tIwps5/ y8w8X9ODdp9Mg== Received: by pali.im (Postfix) id DC8858A3; Fri, 25 Jun 2021 00:49:53 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/10] serial: mvebu-uart: correctly calculate minimal possible baudrate Date: Fri, 25 Jun 2021 00:49:02 +0200 Message-Id: <20210624224909.6350-4-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624224909.6350-1-pali@kernel.org> References: <20210624224909.6350-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For default (x16) scheme which is currently used by mvebu-uart.c driver, maximal divisor of UART base clock is 1023*16. Therefore there is limit for minimal supported baudrate. This change calculate it correctly and prevents setting invalid divisor 0 into hardware registers. Signed-off-by: Pali Rohár Fixes: 68a0db1d7da2 ("serial: mvebu-uart: add function to change baudrate") --- drivers/tty/serial/mvebu-uart.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c index dc0c26824ddb..f8b0016db847 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -481,7 +481,7 @@ static void mvebu_uart_set_termios(struct uart_port *port, struct ktermios *old) { unsigned long flags; - unsigned int baud; + unsigned int baud, min_baud, max_baud; spin_lock_irqsave(&port->lock, flags); @@ -500,16 +500,21 @@ static void mvebu_uart_set_termios(struct uart_port *port, port->ignore_status_mask |= STAT_RX_RDY(port) | STAT_BRK_ERR; /* + * Maximal divisor is 1023 * 16 when using default (x16) scheme. * Maximum achievable frequency with simple baudrate divisor is 230400. * Since the error per bit frame would be of more than 15%, achieving * higher frequencies would require to implement the fractional divisor * feature. */ - baud = uart_get_baud_rate(port, termios, old, 0, 230400); + min_baud = DIV_ROUND_UP(port->uartclk, 1023 * 16); + max_baud = 230400; + + baud = uart_get_baud_rate(port, termios, old, min_baud, max_baud); if (mvebu_uart_baud_rate_set(port, baud)) { /* No clock available, baudrate cannot be changed */ if (old) - baud = uart_get_baud_rate(port, old, NULL, 0, 230400); + baud = uart_get_baud_rate(port, old, NULL, + min_baud, max_baud); } else { tty_termios_encode_baud_rate(termios, baud, baud); uart_update_timeout(port, termios->c_cflag, baud); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64C36C49EA5 for ; Thu, 24 Jun 2021 22:52:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2646960FEA for ; Thu, 24 Jun 2021 22:52:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2646960FEA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e116G5PZARGHhScsVOsGRbnI73uD5GlVOX0fpBTMYbM=; b=kabfHL5ejCHUqe jCp9bYkP6z8cVABhgfi/y13P4lA+wgeunQqMOF9M0BYjuum7BD6MbdoiT+Zpux1xl+B0nM0wwTABe mSGjaWoetaKvfgdFxjcflC0HOgU5GWwEKydzihdy4fIvyKRvfMRUrHj0JGb/Q3DZdaSl52FIXsDWg 6HelxQuOVwgk++oAf2PhMkv4nhxIf0694q+FdyHuZf8JwEwP6V4fkOW0pZrC9qhJaiRPx59OvXORY Kx6GjQIsPaN6lurvUL9MKXR8I0ocXttp6DbY0bKJHBN/hBA2jZ0XGTvZz+bcDpRug/wtWpm+rHbuy 96Pl5qQ6OV7+v42YvRuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwYBS-00GcyE-G5; Thu, 24 Jun 2021 22:50:54 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwYAU-00Gcjl-Hh for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 22:49:57 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 286386135C; Thu, 24 Jun 2021 22:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1624574994; bh=Do7JpeaMbcTZFmYRsJ6KflWqZQ5cEUS3jxE0VeBISec=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KftG9LTMBq4EBxfDAXYFRYxvIic6GLpckd4GFs34LxG3LaieSh9UxRngbGqtcXXdI vDM+/kNx0FmKddqDDZYBmlWS1dxDQMpqasyV2BC3MOGzfjJ7HvIQpKxttYbiXMh2ew vQ5gpGK5kOJNIUXHTqipaHbBaJancGP3D6QxVO1lUOry391v7443wcAyUsRcqc0B7p WY9YitbrfNtAuF0uGe4CeYP0uy+4pMNMBKGDtFW96bPCaktQ/HJVUXjdWMyNzQ8vh4 +ptCcBOMMyScAhiy4YdeQEaAE7HfPfE94IWsQ2S7iV9pXvgxBx3/jd4A+A5tIwps5/ y8w8X9ODdp9Mg== Received: by pali.im (Postfix) id DC8858A3; Fri, 25 Jun 2021 00:49:53 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Michael Turquette , Stephen Boyd , Rob Herring , Greg Kroah-Hartman Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vladimir Vid , =?UTF-8?q?Marek=20Beh=C3=BAn?= , linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/10] serial: mvebu-uart: correctly calculate minimal possible baudrate Date: Fri, 25 Jun 2021 00:49:02 +0200 Message-Id: <20210624224909.6350-4-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210624224909.6350-1-pali@kernel.org> References: <20210624224909.6350-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_154954_642577_F4FF766C X-CRM114-Status: GOOD ( 11.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rm9yIGRlZmF1bHQgKHgxNikgc2NoZW1lIHdoaWNoIGlzIGN1cnJlbnRseSB1c2VkIGJ5IG12ZWJ1 LXVhcnQuYyBkcml2ZXIsCm1heGltYWwgZGl2aXNvciBvZiBVQVJUIGJhc2UgY2xvY2sgaXMgMTAy MyoxNi4gVGhlcmVmb3JlIHRoZXJlIGlzIGxpbWl0IGZvcgptaW5pbWFsIHN1cHBvcnRlZCBiYXVk cmF0ZS4gVGhpcyBjaGFuZ2UgY2FsY3VsYXRlIGl0IGNvcnJlY3RseSBhbmQgcHJldmVudHMKc2V0 dGluZyBpbnZhbGlkIGRpdmlzb3IgMCBpbnRvIGhhcmR3YXJlIHJlZ2lzdGVycy4KClNpZ25lZC1v ZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5vcmc+CkZpeGVzOiA2OGEwZGIxZDdkYTIg KCJzZXJpYWw6IG12ZWJ1LXVhcnQ6IGFkZCBmdW5jdGlvbiB0byBjaGFuZ2UgYmF1ZHJhdGUiKQot LS0KIGRyaXZlcnMvdHR5L3NlcmlhbC9tdmVidS11YXJ0LmMgfCAxMSArKysrKysrKy0tLQogMSBm aWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9kcml2ZXJzL3R0eS9zZXJpYWwvbXZlYnUtdWFydC5jIGIvZHJpdmVycy90dHkvc2VyaWFsL212 ZWJ1LXVhcnQuYwppbmRleCBkYzBjMjY4MjRkZGIuLmY4YjAwMTZkYjg0NyAxMDA2NDQKLS0tIGEv ZHJpdmVycy90dHkvc2VyaWFsL212ZWJ1LXVhcnQuYworKysgYi9kcml2ZXJzL3R0eS9zZXJpYWwv bXZlYnUtdWFydC5jCkBAIC00ODEsNyArNDgxLDcgQEAgc3RhdGljIHZvaWQgbXZlYnVfdWFydF9z ZXRfdGVybWlvcyhzdHJ1Y3QgdWFydF9wb3J0ICpwb3J0LAogCQkJCSAgIHN0cnVjdCBrdGVybWlv cyAqb2xkKQogewogCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Ci0JdW5zaWduZWQgaW50IGJhdWQ7CisJ dW5zaWduZWQgaW50IGJhdWQsIG1pbl9iYXVkLCBtYXhfYmF1ZDsKIAogCXNwaW5fbG9ja19pcnFz YXZlKCZwb3J0LT5sb2NrLCBmbGFncyk7CiAKQEAgLTUwMCwxNiArNTAwLDIxIEBAIHN0YXRpYyB2 b2lkIG12ZWJ1X3VhcnRfc2V0X3Rlcm1pb3Moc3RydWN0IHVhcnRfcG9ydCAqcG9ydCwKIAkJcG9y dC0+aWdub3JlX3N0YXR1c19tYXNrIHw9IFNUQVRfUlhfUkRZKHBvcnQpIHwgU1RBVF9CUktfRVJS OwogCiAJLyoKKwkgKiBNYXhpbWFsIGRpdmlzb3IgaXMgMTAyMyAqIDE2IHdoZW4gdXNpbmcgZGVm YXVsdCAoeDE2KSBzY2hlbWUuCiAJICogTWF4aW11bSBhY2hpZXZhYmxlIGZyZXF1ZW5jeSB3aXRo IHNpbXBsZSBiYXVkcmF0ZSBkaXZpc29yIGlzIDIzMDQwMC4KIAkgKiBTaW5jZSB0aGUgZXJyb3Ig cGVyIGJpdCBmcmFtZSB3b3VsZCBiZSBvZiBtb3JlIHRoYW4gMTUlLCBhY2hpZXZpbmcKIAkgKiBo aWdoZXIgZnJlcXVlbmNpZXMgd291bGQgcmVxdWlyZSB0byBpbXBsZW1lbnQgdGhlIGZyYWN0aW9u YWwgZGl2aXNvcgogCSAqIGZlYXR1cmUuCiAJICovCi0JYmF1ZCA9IHVhcnRfZ2V0X2JhdWRfcmF0 ZShwb3J0LCB0ZXJtaW9zLCBvbGQsIDAsIDIzMDQwMCk7CisJbWluX2JhdWQgPSBESVZfUk9VTkRf VVAocG9ydC0+dWFydGNsaywgMTAyMyAqIDE2KTsKKwltYXhfYmF1ZCA9IDIzMDQwMDsKKworCWJh dWQgPSB1YXJ0X2dldF9iYXVkX3JhdGUocG9ydCwgdGVybWlvcywgb2xkLCBtaW5fYmF1ZCwgbWF4 X2JhdWQpOwogCWlmIChtdmVidV91YXJ0X2JhdWRfcmF0ZV9zZXQocG9ydCwgYmF1ZCkpIHsKIAkJ LyogTm8gY2xvY2sgYXZhaWxhYmxlLCBiYXVkcmF0ZSBjYW5ub3QgYmUgY2hhbmdlZCAqLwogCQlp ZiAob2xkKQotCQkJYmF1ZCA9IHVhcnRfZ2V0X2JhdWRfcmF0ZShwb3J0LCBvbGQsIE5VTEwsIDAs IDIzMDQwMCk7CisJCQliYXVkID0gdWFydF9nZXRfYmF1ZF9yYXRlKHBvcnQsIG9sZCwgTlVMTCwK KwkJCQkJCSAgbWluX2JhdWQsIG1heF9iYXVkKTsKIAl9IGVsc2UgewogCQl0dHlfdGVybWlvc19l bmNvZGVfYmF1ZF9yYXRlKHRlcm1pb3MsIGJhdWQsIGJhdWQpOwogCQl1YXJ0X3VwZGF0ZV90aW1l b3V0KHBvcnQsIHRlcm1pb3MtPmNfY2ZsYWcsIGJhdWQpOwotLSAKMi4yMC4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=