From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F012DC48BC2 for ; Sun, 27 Jun 2021 23:51:44 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E1D261C31 for ; Sun, 27 Jun 2021 23:51:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E1D261C31 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 424E882D71; Mon, 28 Jun 2021 01:51:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MKxBoX0d"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 713B182D71; Mon, 28 Jun 2021 01:51:28 +0200 (CEST) Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0F2388291E for ; Mon, 28 Jun 2021 01:51:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-ot1-x331.google.com with SMTP id x17-20020a05683000d1b029045fb1889a9eso16317876oto.5 for ; Sun, 27 Jun 2021 16:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2z9XdPWpCHR+yFYvTPEtk2Xb8QYT8gzJamyoujNn3k0=; b=MKxBoX0dGH7G/20lG6pj4y/ySEo1HBKuWjP0gn1ou8PuAJ/HjAGKcfmQnCFQbAJ6Y4 FuTjpav/QfLlgHCJ8HHMjN8KZLlszsm6y/+F8uMYBmmkNrg7IX4fSu9VZv0nqAQ6vn2y 8Az4eFkDUHqeEMMwclh8yTm0jdm/6koWT97gk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2z9XdPWpCHR+yFYvTPEtk2Xb8QYT8gzJamyoujNn3k0=; b=cFwMZHEcP333DoJauY541bqu4wrEUzDoefOfgMcmgzNeGRw9mjZmjOqBsy3U7zumX6 kwpXKMYkhMxme0Kpy4JEA0DbvGy/rgEm+l4K3KHCLU2fWyzFSqC1fHdTAOjzII6O7YBG XJT3u7opAB4+urHmatzCCLi4eB1uyqCo2C0gGss+stfqclmx5P1AoQzfWQcYdy4OoG9f 2oVzHaQRD3P28QNuNVV2pJVuVXAaX86k5m3+U3ATEQgASR2RpGO0iTEIJ/DIt1spwAiJ KHLOyfz4k0Q6KWVrcDsuI88YtpXSdcFq3LnNgXzgkkdcoDV4I1b1P6j7Im5QR+yfWLBM lGaQ== X-Gm-Message-State: AOAM53112Owxkfrf7qnriZi5P199ryGEyrjvMzyvI0aAC059PKNIVjUj nIcsn2wYNapoJrdJ+3NVud5IZ2g6xxTeTMhO X-Google-Smtp-Source: ABdhPJzc9WbTmHs5OeX2C8eEkNPrR+49TlEbD5VpFTb+aC7lf4X66goZn4YYK6bnZB9TATioWyMDpg== X-Received: by 2002:a05:6830:1019:: with SMTP id a25mr18839667otp.258.1624837883627; Sun, 27 Jun 2021 16:51:23 -0700 (PDT) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id bb34sm1297928oob.39.2021.06.27.16.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Jun 2021 16:51:23 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Simon Glass , Bin Meng , Jagan Teki , Jagannadha Sutradharudu Teki Subject: [PATCH v3 04/16] spi: ich: Don't require the PCH Date: Sun, 27 Jun 2021 17:50:59 -0600 Message-Id: <20210627235111.485507-4-sjg@chromium.org> X-Mailer: git-send-email 2.32.0.93.g670b81a890-goog In-Reply-To: <20210627235111.485507-1-sjg@chromium.org> References: <20210627235111.485507-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean When booting from coreboot we may not have a PCH driver available. The SPI driver can operate without the PCH but currently complains in this case. Update it to continue to work normally. The only missing feature is memory-mapping of SPI-flash contents, which is not essential. Signed-off-by: Simon Glass Reviewed-by: Bin Meng --- (no changes since v1) drivers/spi/ich.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c index 1cd410493b0..3d49c22a9da 100644 --- a/drivers/spi/ich.c +++ b/drivers/spi/ich.c @@ -114,7 +114,7 @@ static bool ich9_can_do_33mhz(struct udevice *dev) struct ich_spi_priv *priv = dev_get_priv(dev); u32 fdod, speed; - if (!CONFIG_IS_ENABLED(PCI)) + if (!CONFIG_IS_ENABLED(PCI) || !priv->pch) return false; /* Observe SPI Descriptor Component Section 0 */ dm_pci_write_config32(priv->pch, 0xb0, 0x1000); @@ -632,7 +632,7 @@ static int ich_spi_get_basics(struct udevice *bus, bool can_probe, if (device_get_uclass_id(pch) != UCLASS_PCH) { uclass_first_device(UCLASS_PCH, &pch); if (!pch) - return log_msg_ret("uclass", -EPROTOTYPE); + ; /* ignore this error since we don't need it */ } } -- 2.32.0.93.g670b81a890-goog