From: David Edmondson <david.edmondson@oracle.com> To: qemu-devel@nongnu.org Cc: Richard Henderson <richard.henderson@linaro.org>, Michael Roth <michael.roth@amd.com>, kvm@vger.kernel.org, Roman Bolshakov <r.bolshakov@yadro.com>, Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, babu.moger@amd.com, Cameron Esfahani <dirty@apple.com>, Eduardo Habkost <ehabkost@redhat.com>, David Edmondson <david.edmondson@oracle.com> Subject: [RFC PATCH 3/8] target/i386: Clarify the padding requirements of X86XSaveArea Date: Mon, 5 Jul 2021 11:46:27 +0100 [thread overview] Message-ID: <20210705104632.2902400-4-david.edmondson@oracle.com> (raw) In-Reply-To: <20210705104632.2902400-1-david.edmondson@oracle.com> Replace the hard-coded size of offsets or structure elements with defined constants or sizeof(). Signed-off-by: David Edmondson <david.edmondson@oracle.com> --- target/i386/cpu.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 6590ad6391..92f9ca264c 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1329,7 +1329,13 @@ typedef struct X86XSaveArea { /* AVX State: */ XSaveAVX avx_state; - uint8_t padding[960 - 576 - sizeof(XSaveAVX)]; + + /* Ensure that XSaveBNDREG is properly aligned. */ + uint8_t padding[XSAVE_BNDREG_OFFSET + - sizeof(X86LegacyXSaveArea) + - sizeof(X86XSaveHeader) + - sizeof(XSaveAVX)]; + /* MPX State: */ XSaveBNDREG bndreg_state; XSaveBNDCSR bndcsr_state; -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: David Edmondson <david.edmondson@oracle.com> To: qemu-devel@nongnu.org Cc: Eduardo Habkost <ehabkost@redhat.com>, kvm@vger.kernel.org, Michael Roth <michael.roth@amd.com>, Marcelo Tosatti <mtosatti@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Cameron Esfahani <dirty@apple.com>, David Edmondson <david.edmondson@oracle.com>, babu.moger@amd.com, Roman Bolshakov <r.bolshakov@yadro.com>, Paolo Bonzini <pbonzini@redhat.com> Subject: [RFC PATCH 3/8] target/i386: Clarify the padding requirements of X86XSaveArea Date: Mon, 5 Jul 2021 11:46:27 +0100 [thread overview] Message-ID: <20210705104632.2902400-4-david.edmondson@oracle.com> (raw) In-Reply-To: <20210705104632.2902400-1-david.edmondson@oracle.com> Replace the hard-coded size of offsets or structure elements with defined constants or sizeof(). Signed-off-by: David Edmondson <david.edmondson@oracle.com> --- target/i386/cpu.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 6590ad6391..92f9ca264c 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1329,7 +1329,13 @@ typedef struct X86XSaveArea { /* AVX State: */ XSaveAVX avx_state; - uint8_t padding[960 - 576 - sizeof(XSaveAVX)]; + + /* Ensure that XSaveBNDREG is properly aligned. */ + uint8_t padding[XSAVE_BNDREG_OFFSET + - sizeof(X86LegacyXSaveArea) + - sizeof(X86XSaveHeader) + - sizeof(XSaveAVX)]; + /* MPX State: */ XSaveBNDREG bndreg_state; XSaveBNDCSR bndcsr_state; -- 2.30.2
next prev parent reply other threads:[~2021-07-05 10:46 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-05 10:46 [RFC PATCH 0/8] Derive XSAVE state component offsets from CPUID leaf 0xd where possible David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-05 10:46 ` [RFC PATCH 1/8] target/i386: Declare constants for XSAVE offsets David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-05 10:46 ` [RFC PATCH 2/8] target/i386: Consolidate the X86XSaveArea offset checks David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-05 10:46 ` David Edmondson [this message] 2021-07-05 10:46 ` [RFC PATCH 3/8] target/i386: Clarify the padding requirements of X86XSaveArea David Edmondson 2021-07-05 10:46 ` [RFC PATCH 4/8] target/i386: Pass buffer and length to XSAVE helper David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-05 10:46 ` [RFC PATCH 5/8] target/i386: Make x86_ext_save_areas visible outside cpu.c David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-05 10:46 ` [RFC PATCH 6/8] target/i386: Observe XSAVE state area offsets David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-05 10:46 ` [RFC PATCH 7/8] target/i386: Populate x86_ext_save_areas offsets using cpuid where possible David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-05 10:46 ` [RFC PATCH 8/8] target/i386: Move X86XSaveArea into TCG David Edmondson 2021-07-05 10:46 ` David Edmondson 2021-07-07 1:09 ` Richard Henderson 2021-07-07 1:09 ` Richard Henderson 2021-07-07 6:51 ` Paolo Bonzini 2021-07-07 10:10 ` David Edmondson 2021-07-07 10:10 ` David Edmondson 2021-07-08 7:45 ` David Edmondson 2021-07-08 15:22 ` Richard Henderson 2021-07-08 16:13 ` David Edmondson 2021-07-05 16:57 ` [RFC PATCH 0/8] Derive XSAVE state component offsets from CPUID leaf 0xd where possible Paolo Bonzini 2021-07-05 16:57 ` Paolo Bonzini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210705104632.2902400-4-david.edmondson@oracle.com \ --to=david.edmondson@oracle.com \ --cc=babu.moger@amd.com \ --cc=dirty@apple.com \ --cc=ehabkost@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=michael.roth@amd.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=r.bolshakov@yadro.com \ --cc=richard.henderson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.