From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13532C07E96 for ; Fri, 9 Jul 2021 01:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9D1B61468 for ; Fri, 9 Jul 2021 01:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbhGIB2G (ORCPT ); Thu, 8 Jul 2021 21:28:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:40272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbhGIB2G (ORCPT ); Thu, 8 Jul 2021 21:28:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6248461467; Fri, 9 Jul 2021 01:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625793923; bh=0S5RTHBY6Tn7m0hB8C5DQVqIwvDfsBsP7aUEQowh1Us=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kGECSItLyF9Oqo/SRgAgF6Nn+/4DVfjymToCTPpB6D5UQFqkc3728CA9qdrB3aP4n 1t8ROj26D7j+gqnCxHHZ6o617k7oWE13qmbMFnWtFNUMUcYR/pdJuPTIN5OCQMvgf7 lSusEL4r8JqKTRQxXhD8CoTUhTjJjpz1cA/Wkf5FqILfmPoM7aEWk4bA3XT5pccvWz Qempm4rmDH1B5CQpHJOFH95fUOCPyDIMR43rzbt1DyZvONFuafxCVDVg7n8TGhTQKs srMvv/k9kJK22SO9p8ybFHFjUCrZSyi3MHxow4/YdKi8CrRvw0CG2YJYt2itLhxmGa sK1tA4aRNSHng== Date: Thu, 8 Jul 2021 18:25:22 -0700 From: "Darrick J. Wong" To: Pavel Reichl Cc: fstests@vger.kernel.org Subject: Re: [PATCH v3 1/1] generic/{453,454}: Don't run for FSs restricting names Message-ID: <20210709012522.GD11571@locust> References: <20210708163518.51386-1-preichl@redhat.com> <20210708163518.51386-2-preichl@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210708163518.51386-2-preichl@redhat.com> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Thu, Jul 08, 2021 at 06:35:18PM +0200, Pavel Reichl wrote: > Running generic/{453,454} tests is probably only useful for filesystems > that allow unrestricted byte streams for names. > > Signed-off-by: Pavel Reichl > Suggested-by: Darrick J. Wong > Reviewed-by: Theodore Ts'o > --- Looks good to me now, Reviewed-by: Darrick J. Wong --D > common/rc | 13 +++++++++++++ > tests/generic/453 | 1 + > tests/generic/454 | 1 + > 3 files changed, 15 insertions(+) > > diff --git a/common/rc b/common/rc > index d4ad421e..d4b1f21f 100644 > --- a/common/rc > +++ b/common/rc > @@ -4599,6 +4599,19 @@ _require_od_endian_flag() > _notrun "od does not support endian flag" > } > > +# Skip this test unless the filesystem treats names (directory entries, > +# fs labels, and extended attribute names) as raw byte sequences. > +_require_names_are_bytes() { > + case "$FSTYP" in > + ext2|ext3|ext4|f2fs|xfs|btrfs) > + # do nothing > + ;; > + *) > + _notrun "$FSTYP does not allow unrestricted byte streams for names" > + ;; > + esac > +} > + > init_rc > > ################################################################################ > diff --git a/tests/generic/453 b/tests/generic/453 > index 55ddcc01..a0fb802e 100755 > --- a/tests/generic/453 > +++ b/tests/generic/453 > @@ -15,6 +15,7 @@ _begin_fstest auto quick dir > # Import common functions. > > _require_scratch > +_require_names_are_bytes > > echo "Format and mount" > _scratch_mkfs > $seqres.full 2>&1 > diff --git a/tests/generic/454 b/tests/generic/454 > index 3aefa9f0..133e2e9d 100755 > --- a/tests/generic/454 > +++ b/tests/generic/454 > @@ -17,6 +17,7 @@ _begin_fstest auto quick attr > > _require_scratch > _require_attrs > +_require_names_are_bytes > > echo "Format and mount" > _scratch_mkfs > $seqres.full 2>&1 > -- > 2.31.1 >