From: Kees Cook <keescook@chromium.org>
To: bowsingbetee <bowsingbetee@protonmail.com>
Cc: Sergei Trofimovich <slyfox@gentoo.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Potapenko <glider@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH] mm: page_alloc: fix page_poison=1 / INIT_ON_ALLOC_DEFAULT_ON interaction
Date: Wed, 14 Jul 2021 14:14:04 -0700 [thread overview]
Message-ID: <202107141413.78A4ED77@keescook> (raw)
In-Reply-To: <Uw6pNgiHmif9MJPCW3QYgIzcFUoL5wATgnqN4rNUrbpzsGtNvEg0CjiUnqu_LVpuf2Zs8uHUQ8Jz6fpdf30VZdAKpSH0we8NN2iNZVY2YVY=@protonmail.com>
On Wed, Jul 14, 2021 at 11:11:18AM +0000, bowsingbetee wrote:
> B & C variants show this message and A does not, which is what I would expect to happen.
>
> Tested variants:
>
> A. "page_poison=1 init_on_free=0 init_on_alloc=0 slub_debug=P"
> B. "page_poison=1 init_on_free=0 init_on_alloc=0 slub_debug=P init_on_free=1"
> C. "page_poison=1 slub_debug=P"
>
> in common:
> CONFIG_INIT_ON_ALLOC_DEFAULT_ON=y
> CONFIG_INIT_ON_FREE_DEFAULT_ON=y
> CONFIG_PAGE_POISONING=y
> CONFIG_SLUB_DEBUG=y
> CONFIG_SLUB=y
>
> (the slub parts don't matter, ignore them)
>
> [...]
>
> While both patches(Sergei's, and yours) work for me, I'll be using this one for now.
>
> Thank you for your work!
> Cheers!
Awesome; thanks for testing it!
-Kees
--
Kees Cook
prev parent reply other threads:[~2021-07-14 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 23:57 v5.12+ regression on page_poison=1 i_on_free=0 i_on_alloc=0 warnings Sergei Trofimovich
2021-07-12 21:58 ` [PATCH] mm: page_alloc: fix page_poison=1 / INIT_ON_ALLOC_DEFAULT_ON interaction Sergei Trofimovich
2021-07-14 2:00 ` Andrew Morton
2021-07-17 18:18 ` Sergei Trofimovich
2021-07-14 3:10 ` Kees Cook
2021-07-14 11:11 ` bowsingbetee
2021-07-14 21:14 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107141413.78A4ED77@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bowsingbetee@protonmail.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=slyfox@gentoo.org \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.