From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: remove support for disabling quota accounting on a mounted file system
Date: Tue, 20 Jul 2021 08:35:17 +0200 [thread overview]
Message-ID: <20210720063517.GB14747@lst.de> (raw)
In-Reply-To: <20210715171549.GV22402@magnolia>
On Thu, Jul 15, 2021 at 10:15:49AM -0700, Darrick J. Wong wrote:
> > + if (flags & XFS_ALL_QUOTA_ACCT)
> > + xfs_info(mp, "disabling of quota accounting not supported.");
>
> Why not return EOPNOTSUPP here? We're not going to turn off accounting,
> so we're not doing what the admin asked.
Because what the user usually wants is to disable visible effects of
quota, and we still give that. The fact that we keep accounting underneath
isn't quite as relevant as there is no different user behavior, just a little
overhead.
[snipping the rest of the full quote..]
next prev parent reply other threads:[~2021-07-20 6:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 11:14 don't allow disabling quota accounting on a mounted file system Christoph Hellwig
2021-07-12 11:14 ` [PATCH 1/3] xfs: remove support for " Christoph Hellwig
2021-07-14 11:10 ` Carlos Maiolino
2021-07-20 6:33 ` Christoph Hellwig
2021-07-14 21:44 ` Darrick J. Wong
2021-07-15 17:15 ` Darrick J. Wong
2021-07-20 6:35 ` Christoph Hellwig [this message]
2021-07-12 11:14 ` [PATCH 2/3] xfs: remove the flags argument to xfs_qm_dquot_walk Christoph Hellwig
2021-07-14 11:11 ` Carlos Maiolino
2021-07-14 21:45 ` Darrick J. Wong
2021-07-12 11:14 ` [PATCH 3/3] xfs: remove the active vs running quota differentiation Christoph Hellwig
2021-07-14 11:47 ` Carlos Maiolino
2021-07-14 21:47 ` Darrick J. Wong
2021-07-22 7:26 don't allow disabling quota accounting on a mounted file system v2 Christoph Hellwig
2021-07-22 7:26 ` [PATCH 1/3] xfs: remove support for disabling quota accounting on a mounted file system Christoph Hellwig
2021-07-22 18:22 ` Darrick J. Wong
2021-07-22 19:03 ` Christoph Hellwig
2021-07-22 19:07 ` Darrick J. Wong
2021-07-23 5:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720063517.GB14747@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.