From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yizhuo <yzhai003@ucr.edu>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Juan Antonio Aldea-Armenteros <juant.aldea@gmail.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: atomisp: fix the uninitialized use and rename "retvalue"
Date: Fri, 23 Jul 2021 11:10:34 +0300 [thread overview]
Message-ID: <20210723081034.GD1931@kadam> (raw)
In-Reply-To: <20210723003607.64179-1-yzhai003@ucr.edu>
On Fri, Jul 23, 2021 at 12:36:04AM +0000, Yizhuo wrote:
> Inside function mt9m114_detect(), variable "retvalue" could
> be uninitialized if mt9m114_read_reg() returns error, however, it
> is used in the later if statement, which is potentially unsafe.
>
> The local variable "retvalue" is renamed to "model" to avoid
> confusion.
>
> Fixes: ad85094b293e ("Revert "media: staging: atomisp: Remove driver"")
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> ---
Is your full name just Yizhuo or Yizhuo Zhai? Please use your legal
name as if you were signing a legal document.
I don't think you have changed anything in this version? It's basically
a resend of the patch from Jun 25? Please put that information under
the --- cut off.
Looks okay to me.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2021-07-23 8:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 22:51 linux-next: Fixes tag needs some work in the v4l-dvb-next tree Stephen Rothwell
2021-07-23 0:36 ` [PATCH v4] media: atomisp: fix the uninitialized use and rename "retvalue" Yizhuo
2021-07-23 0:36 ` Yizhuo
2021-07-23 8:10 ` Dan Carpenter [this message]
2021-07-23 9:19 ` Yizhuo Zhai
2021-07-23 9:19 ` Yizhuo Zhai
2021-08-11 3:54 ` Yizhuo Zhai
2021-08-11 3:54 ` Yizhuo Zhai
2021-08-11 4:19 ` Yizhuo Zhai
2021-08-11 4:19 ` Yizhuo Zhai
2021-08-11 7:01 ` Greg Kroah-Hartman
2021-08-12 5:50 ` Yizhuo Zhai
2021-08-12 5:50 ` Yizhuo Zhai
2021-08-12 5:54 ` Yizhuo Zhai
2021-08-12 5:54 ` Yizhuo Zhai
2021-08-12 6:52 ` Sakari Ailus
2021-08-12 6:52 ` Greg Kroah-Hartman
2021-08-12 7:34 ` Yizhuo Zhai
2021-08-12 7:34 ` Yizhuo Zhai
2021-08-12 7:46 ` Greg Kroah-Hartman
2021-07-23 0:38 ` linux-next: Fixes tag needs some work in the v4l-dvb-next tree Yizhuo Zhai
2021-07-23 0:58 ` Stephen Rothwell
2021-07-23 2:19 ` Yizhuo Zhai
2021-07-23 7:04 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723081034.GD1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=juant.aldea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yzhai003@ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.