All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Cc: lukma@denx.de, maxims@google.com, sjg@chromium.org,
	u-boot@lists.denx.de, ryan_chen@aspeedtech.com, joel@jms.id.au
Subject: Re: [PATCH v3 06/14] common: fit: Use hash.c to call CRC/SHA function
Date: Sat, 24 Jul 2021 08:57:20 -0400	[thread overview]
Message-ID: <20210724125720.GA25851@bill-the-cat> (raw)
In-Reply-To: <20210720063839.1518-7-chiawei_wang@aspeedtech.com>

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

On Tue, Jul 20, 2021 at 02:38:31PM +0800, Chia-Wei Wang wrote:

> From: Joel Stanley <joel@jms.id.au>
> 
> Currently the FIT verification calls directly into
> SW implemented functions to get a CRC/SHA/MD5 hash.
> 
> This patch removes duplcated algorithm lookup and use
> hash_lookup_algo to get the hashing function with HW
> accelearation supported if configured.
> 
> The MD5 direct call remains as it is not included in
> the hash lookup table of hash.c.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>

While this is a good idea, there's some required prep work.  At least
the following platforms don't compile due to this patch:
ls1046ardb_qspi imx8mm_beacon imx8mn_beacon imx8mn_beacon_2g
imx8mm-icore-mx8mm-ctouch2 imx8mm-icore-mx8mm-edimm2.2 imx8mm_evk
imx8mn_ddr4_evk imx8mn_evk imx8mp_evk imx8mq_evk imx8mm_venice
imx8mq_phanbell phycore-imx8mm phycore-imx8mp pico-imx8mq verdin-imx8mm
mt8183_pumpkin mt8516_pumpkin mscc_jr2 mscc_luton mscc_ocelot
mscc_serval mscc_servalt mt7620_mt7530_rfb mt7620_rfb mt7628_rfb

Which is likely due to cases where HASH or SPL_HASH_SUPPORT are not
being selected as it was not previously required.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-07-24 12:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20  6:38 [PATCH v3 00/14] aspeed: Support secure boot chain with FIT image verification Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 01/14] aspeed: ast2600: Enlarge SRAM size Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 02/14] clk: ast2600: Add YCLK control for HACE Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 03/14] crypto: aspeed: Add AST2600 HACE support Chia-Wei Wang
2021-07-20 18:33   ` Simon Glass
2021-07-23  6:30     ` ChiaWei Wang
2021-07-24 17:22       ` Simon Glass
2021-07-20  6:38 ` [PATCH v3 04/14] ast2600: spl: Add HACE probing Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 05/14] ARM: dts: ast2600: Add HACE to device tree Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 06/14] common: fit: Use hash.c to call CRC/SHA function Chia-Wei Wang
2021-07-24 12:57   ` Tom Rini [this message]
2021-07-26  0:06     ` ChiaWei Wang
2021-07-26  2:01       ` Tom Rini
2021-07-20  6:38 ` [PATCH v3 07/14] clk: ast2600: Add RSACLK control for ARCY Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 08/14] crypto: aspeed: Add AST2600 ARCY support Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 09/14] ast2600: spl: Add ARCY probing Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 10/14] ARM: dts: ast2600: Add ARCY to device tree Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 11/14] ast2600: spl: Locate load buffer in DRAM space Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 12/14] configs: ast2600-evb: Enable SPL FIT support Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 13/14] configs: aspeed: Make EXTRA_ENV_SETTINGS board specific Chia-Wei Wang
2021-07-20  6:38 ` [PATCH v3 14/14] configs: ast2600: Boot kernel FIT in DRAM Chia-Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210724125720.GA25851@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=chiawei_wang@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=lukma@denx.de \
    --cc=maxims@google.com \
    --cc=ryan_chen@aspeedtech.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.