From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
To: <u-boot@lists.denx.de>
Cc: <peng.fan@nxp.com>, <jh80.chung@samsung.com>, <faiz_abbas@ti.com>,
<sjg@chromium.org>, <michael@walle.cc>, <git@xilinx.com>,
<monstr@monstr.eu>, <somaashokreddy@gmail.com>,
Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Subject: [PATCH v3 0/7] Arasan sdhci driver updates
Date: Fri, 30 Jul 2021 06:28:35 -0600 [thread overview]
Message-ID: <20210730122842.3264-1-ashok.reddy.soma@xilinx.com> (raw)
This patch series updates/fixes below things:
- Handle errors from tapdelay functions and return to set_delay()
- Add ZynqMP firmware related enums which are used in sdhci driver
- Replace mmio_write() with firmware call xilinx_pm_request()
- Move tapdelay setting code from tap_delays.c to driver and remove
tap_dealy.c and zynqmp_tap_delay.h
- Change variable name from deviceid to node_id in couple of functions
for consistancy
- Add a workaround for sd card detect stable issue for Versal platforms
- Use set_control_reg from sdhci.c
These patches are based on below microblaze U-Boot 'next' branch.
https://source.denx.de/u-boot/custodians/u-boot-microblaze/-/commits/next
Changes in v3:
- Added new line after return at two places
- As we are seeing issues with SPL flow, keep zynqmp_mmio_write method
to set tapdelay's and DLL resets. Add xilinx_pm_request on top of it
for regular flow.
- Changed the patch title to reflect these changes
- Make the changes on top of patch 4/7 to move the code to zynq_sdhci.c
Changes in v2:
- Split patch 1/7 to two patches, one for zynq_sdhci and other one
for sdhci
- This is the second patch that has been split from 1/7
- This covers changes for sdhci driver separately
- Added a debug print in case of error from set_delay()
- Added comment for why 1ms delay is needed between DLL assert and
release
- Remove mmc->dev->seq_ and use priv->deviceid instead
- Changed return error from -EIO to -ETIMEDOUT in arasan_sdhci_probe()
in card detect state stable workaround
Ashok Reddy Soma (5):
mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay
mmc: sdhci: Change prototype of set_delay to return errors
mmc: zynq_sdhci: Add xilinx_pm_request() method to set tapdelays
mmc: zynq_sdhci: Move setting tapdelay code to driver
mmc: zynq_sdhci: Use set_control_reg from sdhci.c
T Karthik Reddy (2):
zynqmp_firmware: Add zynqmp firmware related enums
mmc: zynq_sdhci: Wait till sd card detect state is stable
board/xilinx/zynqmp/Makefile | 2 -
board/xilinx/zynqmp/tap_delays.c | 101 -------------
drivers/mmc/sdhci.c | 10 +-
drivers/mmc/zynq_sdhci.c | 242 ++++++++++++++++++++++++++-----
include/sdhci.h | 2 +-
include/zynqmp_firmware.h | 127 ++++++++++++++++
include/zynqmp_tap_delay.h | 21 ---
7 files changed, 338 insertions(+), 167 deletions(-)
delete mode 100644 board/xilinx/zynqmp/tap_delays.c
delete mode 100644 include/zynqmp_tap_delay.h
--
2.17.1
next reply other threads:[~2021-07-30 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 12:28 Ashok Reddy Soma [this message]
2021-07-30 12:28 ` [PATCH v3 1/7] mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay Ashok Reddy Soma
2021-08-01 23:08 ` Jaehoon Chung
2021-07-30 12:28 ` [PATCH v3 2/7] mmc: sdhci: Change prototype of set_delay to return errors Ashok Reddy Soma
2021-08-01 23:09 ` Jaehoon Chung
2021-07-30 12:28 ` [PATCH v3 3/7] zynqmp_firmware: Add zynqmp firmware related enums Ashok Reddy Soma
2021-07-30 12:28 ` [PATCH v3 4/7] mmc: zynq_sdhci: Add xilinx_pm_request() method to set tapdelays Ashok Reddy Soma
2021-07-30 12:28 ` [PATCH v3 5/7] mmc: zynq_sdhci: Move setting tapdelay code to driver Ashok Reddy Soma
2021-07-30 12:28 ` [PATCH v3 6/7] mmc: zynq_sdhci: Wait till sd card detect state is stable Ashok Reddy Soma
2021-07-30 12:28 ` [PATCH v3 7/7] mmc: zynq_sdhci: Use set_control_reg from sdhci.c Ashok Reddy Soma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210730122842.3264-1-ashok.reddy.soma@xilinx.com \
--to=ashok.reddy.soma@xilinx.com \
--cc=faiz_abbas@ti.com \
--cc=git@xilinx.com \
--cc=jh80.chung@samsung.com \
--cc=michael@walle.cc \
--cc=monstr@monstr.eu \
--cc=peng.fan@nxp.com \
--cc=sjg@chromium.org \
--cc=somaashokreddy@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.