From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C423C4338F for ; Wed, 4 Aug 2021 22:09:28 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B9E7610A0 for ; Wed, 4 Aug 2021 22:09:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B9E7610A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B7AC1829E7; Thu, 5 Aug 2021 00:09:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="jkPUDP/k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E17F182BC7; Thu, 5 Aug 2021 00:09:22 +0200 (CEST) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D2596829E7 for ; Thu, 5 Aug 2021 00:09:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id db14so1882293qvb.10 for ; Wed, 04 Aug 2021 15:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=660ren1JF8hEvHDJAWQxItzO0eomgi1IqT6C8r+yx5Y=; b=jkPUDP/kshBAQzmsoIpjIYrSZvfnOs/WwBrO/gCqdbfPtD/YOS1VCK+y3Lu2x9hWxh guu9GZTQXBgDfVJ1/BYGInBnaEamjTC6YuI0hqOR2S3YYoYnWSDq0GjZWyxTeZVtTxXq 3b+cuQZ2ketA0PrT8RoGgkDPvW547F53keKTc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=660ren1JF8hEvHDJAWQxItzO0eomgi1IqT6C8r+yx5Y=; b=emiBM3wOUQ+kyDR8FYn4ObGuw1Q3VdZRaRt/99WDKudzuXFhyN+6ijVd8qYUoXkWhB oQJtcf2ofWBYhLoNWHo2CQdj6jOqi7qa778liT6GBb7ceDLl5gR0nYbO+Yl6uVR++fyI YQshewrBncnEd5ClDswzxX9sR6UnmYvnXyYddt/AuLRL/dANi1V/fC3HVnprvzWGqBuQ pjiumnB5F5Uwm9ZwQ8B2+XhsiY7TBhpB8Q0e6RN9RI/4RAa+fNQQA3ZyM9x3z3/kUnVW kF6t/cLCRQkiquHaUB6cY6fLFkr1UJy3Pl7771R/QoHk2jD/oUgH6vUNydDTv/h4N/+M Sy3w== X-Gm-Message-State: AOAM533M0PPzdP7JAoGj8Y1E+p4ftfOgT1VPfDA19W2vd9MPSWT02CPw FIqZYKbtWF2xQBVquxDSOIG+bw== X-Google-Smtp-Source: ABdhPJxQIMJCIJGWooX0MY03aq+WdQ+h2zWbEDruZtJr8lOvqNAosK/xTONgKs3aqelduCuyBhT9uw== X-Received: by 2002:ad4:4f06:: with SMTP id fb6mr1806372qvb.37.1628114957545; Wed, 04 Aug 2021 15:09:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a9d9-7fe0-6131-a526.res6.spectrum.com. [2603:6081:7b01:cbda:a9d9:7fe0:6131:a526]) by smtp.gmail.com with ESMTPSA id h8sm1629517qkk.74.2021.08.04.15.09.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 15:09:16 -0700 (PDT) Date: Wed, 4 Aug 2021 18:09:14 -0400 From: Tom Rini To: Sean Anderson Cc: Simon Glass , Pali =?iso-8859-1?Q?Roh=E1r?= , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , U-Boot Mailing List Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h Message-ID: <20210804220914.GA858@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> <815b40e2-aa57-abfb-901f-979507a9e3b7@seco.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WIyZ46R2i8wDzkSu" Content-Disposition: inline In-Reply-To: <815b40e2-aa57-abfb-901f-979507a9e3b7@seco.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --WIyZ46R2i8wDzkSu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 04, 2021 at 05:43:41PM -0400, Sean Anderson wrote: >=20 >=20 > On 8/2/21 3:21 PM, Simon Glass wrote: > > Hi Pali, > >=20 > > On Mon, 2 Aug 2021 at 07:20, Pali Roh=E1r wrote: > > >=20 > > > Header file version.h does not use anything from timestamp.h. Includi= ng of > > > timestamp.h has side effect which cause recompiling object file at ev= ery > > > make run because timestamp.h changes at every run. > > >=20 > > > So remove timestamp.h from version.h and include timestamp.h in files > > > which needs it. > > >=20 > > > This change reduce recompilation time of final U-Boot binary when U-B= oot > > > source files were not changed as less source files needs to be recomp= iled. > > >=20 > > > Signed-off-by: Pali Roh=E1r > > > --- > > > arch/arm/mach-rockchip/tpl.c | 4 ++++ > > > board/work-microwave/work_92105/work_92105_display.c | 1 + > > > cmd/version.c | 1 + > > > common/spl/spl.c | 4 ++++ > > > drivers/rtc/emul_rtc.c | 2 +- > > > include/version.h | 2 -- > > > 6 files changed, 11 insertions(+), 3 deletions(-) > >=20 > > Reviewed-by: Simon Glass > >=20 > > I assume we do actually want to regenerate the timestamp when U-Boot > > builds, even if nothing has changed. Is that right? >=20 > I know this is the current behavior, but it would be nice if this was > not the case. If one is building U-Boot as part of a larger project, one > might want to have a makefile rule like >=20 > u-boot/u-boot.bin: > $(MAKE) -C u-boot $(@F) >=20 > but u-boot/u-boot.bin will always be remade even if no changes have been > done. This will cause make to remake all dependents of U-Boot as well > (which can be rather time-consuming). >=20 > At the moment, I just use U-Boot as an order-only dependency and remake > it manually. But I would love it if U-Boot was only remade if > dependencies had actually changed, since this would make it easier to > integrate it with the rest of my build system. Note that with this series applied, if you made use of SOURCE_DATE_EPOCH, nothing would be rebuilt. That may or may not make sense however, in your case. This series does get us closer to being able to do what the linux kernel does as there's now just one place rather than a bunch of places that are rebuilt. --=20 Tom --WIyZ46R2i8wDzkSu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmELEAMACgkQFHw5/5Y0 tywUKwwApPft+750XqLz/ZjLBChQl/C3dH0LF4DNlXIz6ZqB5hs6+ym+grdVBiaT Ndi1XBfrQSXKqNkuqeQK49+tutqIWgTdrkIJqjpDoWJnir7WdYQHtdlm+gJG0UtD 9xCSw+bgngdjQGEQ/fgyTc+pEHvOqb/zdCkeDqBNVgUrGF9J4io4muarUi9WIceH /1Yqo26bILXGo6H6Oi0aCZQEQBjTx43hsgXpGvbHK90BJnYX8BtbGPx3ReQi1Hhx cjmFu6GMc1dktUazdEXJ9GLMNIeX4wS5VIwFuC+ujqJH78glW6DShQ8pNyzHxD/j 64QuskM85QQJLfp3KvAD2Rvp55LkxlezLS5KgoEm8bPtGm1NCrBCrYufbgaPB6+U YGVbDvhJPSGu1sqnzvjLQL6u/3WrIe1TMvBggRF7cFt+36c7yqAP/5YgJwdwclmD Cw7G0qS5Zx+Chzk+rzqj7sMf1a+STjib3iT30wSMO4YxBhaZKodN/Ck3bmUq+4QV ADJhFcel =Tm2G -----END PGP SIGNATURE----- --WIyZ46R2i8wDzkSu--