All of lore.kernel.org
 help / color / mirror / Atom feed
From: marcandre.lureau@redhat.com
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PULL 2/8] chardev/socket: print a more correct command-line address
Date: Thu,  5 Aug 2021 16:53:25 +0400	[thread overview]
Message-ID: <20210805125331.826741-3-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20210805125331.826741-1-marcandre.lureau@redhat.com>

From: Marc-André Lureau <marcandre.lureau@redhat.com>

Better reflect the command line version of the socket address arguments,
following the now recommended long-form opt=on syntax.

Complement/fixes commit 9d902d51 "chardev: do not use short form boolean
options in non-QemuOpts character device descriptions".

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 chardev/char-socket.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index d0fb545963..c43668cc15 100644
--- a/chardev/char-socket.c
+++ b/chardev/char-socket.c
@@ -468,9 +468,9 @@ static char *qemu_chr_socket_address(SocketChardev *s, const char *prefix)
 
 #ifdef CONFIG_LINUX
         if (sa->has_abstract && sa->abstract) {
-            abstract = ",abstract";
+            abstract = ",abstract=on";
             if (sa->has_tight && sa->tight) {
-                tight = ",tight";
+                tight = ",tight=on";
             }
         }
 #endif
-- 
2.32.0.264.g75ae10bc75



  parent reply	other threads:[~2021-08-05 12:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 12:53 [PULL 0/8] chardev fixes for 6.1 marcandre.lureau
2021-08-05 12:53 ` [PULL 1/8] util: fix abstract socket path copy marcandre.lureau
2021-08-05 12:53 ` marcandre.lureau [this message]
2021-08-05 12:53 ` [PULL 3/8] chardev: mark explicitly first argument as poisoned marcandre.lureau
2021-08-05 12:53 ` [PULL 4/8] chardev: fix fd_chr_add_watch() when in != out marcandre.lureau
2021-08-05 12:53 ` [PULL 5/8] chardev: fix qemu_chr_open_fd() being called with fd=-1 marcandre.lureau
2021-08-05 12:53 ` [PULL 6/8] chardev: fix qemu_chr_open_fd() with fd_in==fd_out marcandre.lureau
2021-08-05 12:53 ` [PULL 7/8] chardev: give some context on chardev-add error marcandre.lureau
2021-08-05 12:53 ` [PULL 8/8] chardev: report a simpler error about duplicated id marcandre.lureau
2021-08-05 17:47 ` [PULL 0/8] chardev fixes for 6.1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210805125331.826741-3-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.