From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@nvidia.com>, Doug Ledford <dledford@redhat.com>
Cc: <linux-rdma@vger.kernel.org>,
Alexander Matushevsky <matua@amazon.com>,
Gal Pressman <galpress@amazon.com>,
Firas JahJah <firasj@amazon.com>,
Yossi Leybovich <sleybo@amazon.com>,
Steve Wise <larrystevenwise@gmail.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Shiraz Saleem <shiraz.saleem@intel.com>
Subject: [PATCH for-next 1/4] RDMA/efa: Free IRQ vectors on error flow
Date: Wed, 11 Aug 2021 18:11:28 +0300 [thread overview]
Message-ID: <20210811151131.39138-2-galpress@amazon.com> (raw)
In-Reply-To: <20210811151131.39138-1-galpress@amazon.com>
Make sure to free the IRQ vectors in case the allocation doesn't return
the expected number of IRQs.
Fixes: b7f5e880f377 ("RDMA/efa: Add the efa module")
Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
drivers/infiniband/hw/efa/efa_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/efa/efa_main.c b/drivers/infiniband/hw/efa/efa_main.c
index 997947d77de6..42f9ac3f586e 100644
--- a/drivers/infiniband/hw/efa/efa_main.c
+++ b/drivers/infiniband/hw/efa/efa_main.c
@@ -358,6 +358,7 @@ static int efa_enable_msix(struct efa_dev *dev)
}
if (irq_num != msix_vecs) {
+ efa_disable_msix(dev);
dev_err(&dev->pdev->dev,
"Allocated %d MSI-X (out of %d requested)\n",
irq_num, msix_vecs);
--
2.32.0
next prev parent reply other threads:[~2021-08-11 15:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:11 [PATCH for-next 0/4] EFA CQ notifications Gal Pressman
2021-08-11 15:11 ` Gal Pressman [this message]
2021-08-20 18:34 ` [PATCH for-next 1/4] RDMA/efa: Free IRQ vectors on error flow Jason Gunthorpe
2021-08-11 15:11 ` [PATCH for-next 2/4] RDMA/efa: Remove unused cpu field from irq struct Gal Pressman
2021-08-11 15:11 ` [PATCH for-next 3/4] RDMA/efa: Rename vector field in efa_irq struct to irqn Gal Pressman
2021-08-11 15:11 ` [PATCH for-next 4/4] RDMA/efa: CQ notifications Gal Pressman
2021-08-20 18:27 ` Jason Gunthorpe
2021-09-01 11:50 ` Gal Pressman
2021-09-01 11:57 ` Jason Gunthorpe
2021-09-01 14:24 ` Gal Pressman
2021-09-01 15:36 ` Jason Gunthorpe
2021-09-02 7:03 ` Gal Pressman
2021-09-02 13:02 ` Jason Gunthorpe
2021-09-02 15:09 ` Gal Pressman
2021-09-02 15:10 ` Jason Gunthorpe
2021-09-02 15:17 ` Gal Pressman
2021-09-02 15:41 ` Jason Gunthorpe
2021-09-05 7:25 ` Gal Pressman
2021-09-05 7:59 ` Leon Romanovsky
2021-09-05 10:45 ` Gal Pressman
2021-09-05 10:54 ` Leon Romanovsky
2021-09-05 11:05 ` Gal Pressman
2021-09-05 13:14 ` Leon Romanovsky
2021-09-05 14:36 ` Gal Pressman
2021-09-07 11:31 ` Jason Gunthorpe
2021-09-09 11:00 ` Gal Pressman
2021-08-20 18:36 ` [PATCH for-next 0/4] EFA " Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210811151131.39138-2-galpress@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=firasj@amazon.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=larrystevenwise@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=shiraz.saleem@intel.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.