All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC][PATCH] netfs, afs, ceph: Use folios
Date: Thu, 12 Aug 2021 00:33:43 +0800	[thread overview]
Message-ID: <202108120041.b3QxOAk7-lkp@intel.com> (raw)
In-Reply-To: <2408234.1628687271@warthog.procyon.org.uk>

[-- Attachment #1: Type: text/plain, Size: 6890 bytes --]

Hi David,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on next-20210811]
[cannot apply to tip/perf/core linux/master linus/master v5.14-rc5 v5.14-rc4 v5.14-rc3 v5.14-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-Howells/netfs-afs-ceph-Use-folios/20210811-210906
base:    8ca403f3e7a23c4513046ad8d107adfbe4703362
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a665390ce411c517db3f70ae59cdaa874cb914ba
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-Howells/netfs-afs-ceph-Use-folios/20210811-210906
        git checkout a665390ce411c517db3f70ae59cdaa874cb914ba
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> fs/ceph/addr.c:315:23: error: initialization of 'int (*)(struct file *, loff_t,  unsigned int,  struct folio *, void **)' {aka 'int (*)(struct file *, long long int,  unsigned int,  struct folio *, void **)'} from incompatible pointer type 'int (*)(struct file *, loff_t,  unsigned int,  struct page *, void **)' {aka 'int (*)(struct file *, long long int,  unsigned int,  struct page *, void **)'} [-Werror=incompatible-pointer-types]
     315 |  .check_write_begin = ceph_netfs_check_write_begin,
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   fs/ceph/addr.c:315:23: note: (near initialization for 'ceph_netfs_read_ops.check_write_begin')
   fs/ceph/addr.c: In function 'ceph_readpage':
>> fs/ceph/addr.c:346:30: error: passing argument 2 of 'netfs_readpage' from incompatible pointer type [-Werror=incompatible-pointer-types]
     346 |  return netfs_readpage(file, page, &ceph_netfs_read_ops, NULL);
         |                              ^~~~
         |                              |
         |                              struct page *
   In file included from fs/ceph/addr.c:15:
   include/linux/netfs.h:243:6: note: expected 'struct folio *' but argument is of type 'struct page *'
     243 |      struct folio *,
         |      ^~~~~~~~~~~~~~
   fs/ceph/addr.c: In function 'ceph_write_begin':
>> fs/ceph/addr.c:1255:61: error: passing argument 6 of 'netfs_write_begin' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1255 |  r = netfs_write_begin(file, inode->i_mapping, pos, len, 0, &page, NULL,
         |                                                             ^~~~~
         |                                                             |
         |                                                             struct page **
   In file included from fs/ceph/addr.c:15:
   include/linux/netfs.h:247:45: note: expected 'struct folio **' but argument is of type 'struct page **'
     247 |         loff_t, unsigned int, unsigned int, struct folio **,
         |                                             ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +315 fs/ceph/addr.c

49870056005ca9 Jeff Layton 2020-07-09  307  
675d4d8997ac18 Wei Yongjun 2021-05-14  308  static const struct netfs_read_request_ops ceph_netfs_read_ops = {
f0702876e152f0 Jeff Layton 2020-06-01  309  	.init_rreq		= ceph_init_rreq,
f0702876e152f0 Jeff Layton 2020-06-01  310  	.is_cache_enabled	= ceph_is_cache_enabled,
f0702876e152f0 Jeff Layton 2020-06-01  311  	.begin_cache_operation	= ceph_begin_cache_operation,
f0702876e152f0 Jeff Layton 2020-06-01  312  	.issue_op		= ceph_netfs_issue_op,
f0702876e152f0 Jeff Layton 2020-06-01  313  	.expand_readahead	= ceph_netfs_expand_readahead,
f0702876e152f0 Jeff Layton 2020-06-01  314  	.clamp_length		= ceph_netfs_clamp_length,
d801327d9500c7 Jeff Layton 2020-06-05 @315  	.check_write_begin	= ceph_netfs_check_write_begin,
49870056005ca9 Jeff Layton 2020-07-09  316  	.cleanup		= ceph_readahead_cleanup,
f0702876e152f0 Jeff Layton 2020-06-01  317  };
f0702876e152f0 Jeff Layton 2020-06-01  318  
f0702876e152f0 Jeff Layton 2020-06-01  319  /* read a single page, without unlocking it. */
f0702876e152f0 Jeff Layton 2020-06-01  320  static int ceph_readpage(struct file *file, struct page *page)
f0702876e152f0 Jeff Layton 2020-06-01  321  {
f0702876e152f0 Jeff Layton 2020-06-01  322  	struct inode *inode = file_inode(file);
f0702876e152f0 Jeff Layton 2020-06-01  323  	struct ceph_inode_info *ci = ceph_inode(inode);
f0702876e152f0 Jeff Layton 2020-06-01  324  	struct ceph_vino vino = ceph_vino(inode);
f0702876e152f0 Jeff Layton 2020-06-01  325  	u64 off = page_offset(page);
8ff2d290c8ce77 Jeff Layton 2021-04-05  326  	u64 len = thp_size(page);
f0702876e152f0 Jeff Layton 2020-06-01  327  
f0702876e152f0 Jeff Layton 2020-06-01  328  	if (ci->i_inline_version != CEPH_INLINE_NONE) {
f0702876e152f0 Jeff Layton 2020-06-01  329  		/*
f0702876e152f0 Jeff Layton 2020-06-01  330  		 * Uptodate inline data should have been added
f0702876e152f0 Jeff Layton 2020-06-01  331  		 * into page cache while getting Fcr caps.
f0702876e152f0 Jeff Layton 2020-06-01  332  		 */
f0702876e152f0 Jeff Layton 2020-06-01  333  		if (off == 0) {
f0702876e152f0 Jeff Layton 2020-06-01  334  			unlock_page(page);
f0702876e152f0 Jeff Layton 2020-06-01  335  			return -EINVAL;
f0702876e152f0 Jeff Layton 2020-06-01  336  		}
8ff2d290c8ce77 Jeff Layton 2021-04-05  337  		zero_user_segment(page, 0, thp_size(page));
f0702876e152f0 Jeff Layton 2020-06-01  338  		SetPageUptodate(page);
f0702876e152f0 Jeff Layton 2020-06-01  339  		unlock_page(page);
f0702876e152f0 Jeff Layton 2020-06-01  340  		return 0;
f0702876e152f0 Jeff Layton 2020-06-01  341  	}
f0702876e152f0 Jeff Layton 2020-06-01  342  
f0702876e152f0 Jeff Layton 2020-06-01  343  	dout("readpage ino %llx.%llx file %p off %llu len %llu page %p index %lu\n",
f0702876e152f0 Jeff Layton 2020-06-01  344  	     vino.ino, vino.snap, file, off, len, page, page->index);
f0702876e152f0 Jeff Layton 2020-06-01  345  
f0702876e152f0 Jeff Layton 2020-06-01 @346  	return netfs_readpage(file, page, &ceph_netfs_read_ops, NULL);
f0702876e152f0 Jeff Layton 2020-06-01  347  }
f0702876e152f0 Jeff Layton 2020-06-01  348  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 55407 bytes --]

  parent reply	other threads:[~2021-08-11 16:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 13:07 [RFC][PATCH] netfs, afs, ceph: Use folios David Howells
2021-08-11 13:54 ` Matthew Wilcox
2021-08-11 15:50 ` kernel test robot
2021-08-11 16:33 ` kernel test robot [this message]
2021-08-11 21:05 ` [RFC][PATCH] afs: Use folios in directory handling David Howells
2021-08-12 16:07 ` [RFC][PATCH] netfs, afs, ceph: Use folios Matthew Wilcox
2021-08-13  6:53   ` Christoph Hellwig
2021-08-13  8:17   ` David Howells
2021-08-12 20:47 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108120041.b3QxOAk7-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.