From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04B9C4320A for ; Mon, 16 Aug 2021 09:23:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 808E861B62 for ; Mon, 16 Aug 2021 09:23:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235360AbhHPJXy (ORCPT ); Mon, 16 Aug 2021 05:23:54 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:40616 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235307AbhHPJXp (ORCPT ); Mon, 16 Aug 2021 05:23:45 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D1DB21FE9F; Mon, 16 Aug 2021 09:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1629105792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lIhbtfmQFdUyLr+XRg4X189IA3pmb9ipPv3oDyGsdAk=; b=ZvpbcYm/EqvWLf2vBJ5CkR9pIkhz67biMHzXgp1fTtcgiF3RQls0iN9gVZV8fy86Bw19x0 SMBOkfOXC+vloHb/ASdhy0fdl4CHPRR8UdYKIWSM0aWUMEfoPkJXR/1nTY94q3uVSEG6pI kgKzltAq5c2R9dCHRg93+CrdasTtEXw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1629105792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lIhbtfmQFdUyLr+XRg4X189IA3pmb9ipPv3oDyGsdAk=; b=nqMgIrKk5QB2oRbM5SkuVn/WYXk2O5OD1FQ48/pu8h6En3ei+qlMeXUJAAjm20SSRMrML3 h4qMozw+RJ0DB+Cg== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id C1889A3B8E; Mon, 16 Aug 2021 09:23:12 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 91F7D1E0426; Mon, 16 Aug 2021 11:23:09 +0200 (CEST) From: Jan Kara To: Ted Tso Cc: , Jan Kara Subject: [PATCH 0/5 v6] ext4: Speedup orphan file handling Date: Mon, 16 Aug 2021 11:22:58 +0200 Message-Id: <20210816091810.16994-1-jack@suse.cz> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2222; h=from:subject:message-id; bh=+dol8tocQN+OE6iZMOk/W/8ZT/JoSmI7b+s6J9ZlrVs=; b=owEBbQGS/pANAwAIAZydqgc/ZEDZAcsmYgBhGi5RRGVcyCfxlG1lBHJLc5NIdXP+Mce7N9uiE2Qd AcqJ6C6JATMEAAEIAB0WIQSrWdEr1p4yirVVKBycnaoHP2RA2QUCYRouUQAKCRCcnaoHP2RA2b6YCA DnMlIbjp6fhmDMp+1Y8ZXAXhR6FAi2rBFVaX0D1yaF2/Kh7DNsX9fbbYVstZmtTuh3afs5tkJlCA11 9Kw3vDVwBAESiqpjlKZxocGVzkb4WBDkl92rbkbuUXOdqPHTRUsReIsC3ujeZXa6wdbWLR9Jqhy46Q ZczWZNB8ai+B30Z3biRQ+anTFg4FknJRQSn2CyZHGSlIpj1nibpa3y+4ptW301D+MWtHtEYfnp2ugZ Mhut5gBnfQxADjquSdbTn0+Afony/vvq+tG7Oxq+r8gsVUYwEQugiSiGnvZMgw+Sym4TNb1EGn4/Qk p244wG/ZhaZxtCNbFVkssM/z0ykG5f X-Developer-Key: i=jack@suse.cz; a=openpgp; fpr=93C6099A142276A28BBE35D815BC833443038D8C Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hello, Here is a fourth version of my series to speed up orphan inode handling in ext4. Orphan inode handling in ext4 is a bottleneck for workloads which heavily excercise truncate / unlink of small files as they contend on global s_orphan_mutex (when you have fast enough storage). This patch set implements new way of handling orphan inodes - instead of using a linked list, we store inode numbers of orphaned inodes in a file which is possible to implement in a more scalable manner than linked list manipulations. See description of patch 3/5 for more details. The patch set achieves significant gains both for a micro benchmark stressing orphan inode handling (truncating file byte-by-byte, several threads in parallel) and for reaim creat_clo workload. I'm happy for any review, thoughts, ideas about the patches. I have also implemented full support in e2fsprogs which I'll send separately. Honza [1] https://lore.kernel.org/lkml/20210227120804.GB22871@xsang-OptiPlex-9020/ Changes since v5: * Added Reviewed-by tags from Ted * Fixed up sparse warning spotted by 0-day * Fixed error handling path in ext4_orphan_add() to not leak orphan entry Changes since v4: * Rebased on top of v5.14-rc5 * Updated commit message of patch 1/5 * Added Reviewed-by tags from Ted Changes since v3: * Added documentation about on-disk format changes * Add physical block number into orphan block checksum * Improve some sanity checks, handling of corrupted orphan file * Improved some changelogs Changes since v2: * Updated some comments * Rebased onto 5.13-rc5 * Change orphan file inode from a fixed inode number to inode number stored in the superblock Changes since v1: * orphan blocks have now magic numbers * split out orphan handling to a separate source file * some smaller updates according to review Previous versions: Link: http://lore.kernel.org/r/20210811101006.2033-1-jack@suse.cz # v5 Link: https://lore.kernel.org/linux-ext4/20210712154009.9290-1-jack@suse.cz/ #v4 Link: https://lore.kernel.org/linux-ext4/20210616105655.5129-1-jack@suse.cz/ #v3 Link: https://lore.kernel.org/linux-ext4/1432293717-24010-1-git-send-email-jack@suse.cz/ #v2