From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2C2C4338F for ; Thu, 19 Aug 2021 07:04:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32F6261029 for ; Thu, 19 Aug 2021 07:04:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32F6261029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 112EB82917; Thu, 19 Aug 2021 09:03:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id EAD2D82C24; Thu, 19 Aug 2021 09:03:56 +0200 (CEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 690C681F7B for ; Thu, 19 Aug 2021 09:03:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miquel.raynal@bootlin.com Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 75A0240004; Thu, 19 Aug 2021 07:03:51 +0000 (UTC) Date: Thu, 19 Aug 2021 09:03:50 +0200 From: Miquel Raynal To: Simon Glass Cc: U-Boot Mailing List , Joao Marcos Costa , Thomas Petazzoni Subject: Re: [PATCH 05/11] sqfs: Suppress the message about missing filesystem Message-ID: <20210819090350.4a2b153e@xps13> In-Reply-To: <20210818214022.5.I3eb71025472bbb050bcf9a0a192dde1b6c07fa7f@changeid> References: <20210819034033.1617201-1-sjg@chromium.org> <20210818214022.5.I3eb71025472bbb050bcf9a0a192dde1b6c07fa7f@changeid> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Simon, Simon Glass wrote on Wed, 18 Aug 2021 21:40:27 -0600: > This message comes up a lot when scanning filesystems. It suggests to the > user that there is some sort of error, but in fact there is no reason to > expect that a particular partition has a sqfs filesystem. Other > filesystems don't print this error. >=20 > Turn it into a debug message. >=20 > Signed-off-by: Simon Glass Reviewed-by: Miquel Raynal > --- >=20 > fs/squashfs/sqfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c > index 92ab8ac6310..e2d91c654cd 100644 > --- a/fs/squashfs/sqfs.c > +++ b/fs/squashfs/sqfs.c > @@ -1090,7 +1090,7 @@ int sqfs_probe(struct blk_desc *fs_dev_desc, struct= disk_partition *fs_partition > =20 > /* Make sure it has a valid SquashFS magic number*/ > if (get_unaligned_le32(&sblk->s_magic) !=3D SQFS_MAGIC_NUMBER) { > - printf("Bad magic number for SquashFS image.\n"); > + debug("Bad magic number for SquashFS image.\n"); > ret =3D -EINVAL; > goto error; > } Thanks, Miqu=C3=A8l