[PATCH 1/2] configure: Remove obsoleted -malign-{jumps, loops, functions}

From: Fangrui Song <maskray@google.com>
To: grub-devel@gnu.org, Daniel Kiper <daniel.kiper@oracle.com>,
	 Alex Burmashev <alexander.burmashev@oracle.com>,
	 "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>
Cc: Fangrui Song <maskray@google.com>
Subject: [PATCH 1/2] configure: Remove obsoleted -malign-{jumps, loops, functions}
Date: Mon, 23 Aug 2021 23:18:37 -0700	[thread overview]
Message-ID: <20210824061838.3569412-2-maskray@google.com> (raw)
In-Reply-To: <20210824061838.3569412-1-maskray@google.com>

GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`.
Clang silently ignores -malign-{jumps,loops,functions}.

The preferred -falign-* forms have been supported since GCC 3.2, so just
remove -malign-{jumps,loops,functions}.

Signed-off-by: Fangrui Song <maskray@google.com>
---
 configure.ac | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/configure.ac b/configure.ac
index bee28dbeb..9a12151bd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -805,17 +805,8 @@ if test "x$target_cpu" = xi386; then
 	[grub_cv_cc_falign_loop=no])
   ])
 
-  AC_CACHE_CHECK([whether -malign-loops works], [grub_cv_cc_malign_loop], [
-    CFLAGS="$TARGET_CFLAGS -malign-loops=1 -Werror"
-    AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
-        [grub_cv_cc_malign_loop=yes],
-	[grub_cv_cc_malign_loop=no])
-  ])
-
   if test "x$grub_cv_cc_falign_loop" = xyes; then
     TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1"
-  elif test "x$grub_cv_cc_malign_loop" = xyes; then
-    TARGET_CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 -malign-functions=1"
   fi
 fi
 
-- 
2.33.0.rc2.250.ged5fa647cd-goog


