From: Marcos Paulo de Souza <mpdesouza@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.com, nborisov@suse.com,
Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: [PATCH 0/7] btrfs: Create macro to iterate slots
Date: Tue, 24 Aug 2021 14:06:51 -0300 [thread overview]
Message-ID: <20210824170658.12567-1-mpdesouza@suse.com> (raw)
There is a common pattern when search for a key in btrfs:
* Call btrfs_search_slot
* Endless loop
* If the found slot is bigger than the current items in the leaf, check the
next one
* If still not found in the next leaf, return 1
* Do something with the code
* Increment current slot, and continue
This pattern can be improved by creating an iterator macro, similar to
those for_each_X already existing in the linux kernel. using this
approach means to reduce significantly boilerplate code, along making it
easier to newcomers to understand how to code works.
This patchset survived a complete fstest run.
Changes from RFC:
* Add documentation to btrfs_for_each_slot macro and btrfs_valid_slot function
(David)
* Add documentation about the ret variable used as a macro argument (David)
* Match function argument from prototype and implementation (David)
* Changed ({ }) block to only () in btrfs_for_each_slot macro (David)
* Add more patches to show the code being reduced by using this approach
(Nikolay)
Marcos Paulo de Souza (7):
fs: btrfs: Introduce btrfs_for_each_slot
btrfs: block-group: use btrfs_for_each_slot in find_first_block_group
btrfs: dev-replace: Use btrfs_for_each_slot in
mark_block_group_to_copy
btrfs: dir-item: use btrfs_for_each_slot in
btrfs_search_dir_index_item
btrfs: inode: use btrfs_for_each_slot in btrfs_read_readdir
btrfs: send: Use btrfs_for_each_slot macro
btrfs: volumes: use btrfs_for_each_slot in btrfs_read_chunk_tree
fs/btrfs/block-group.c | 33 +-----
fs/btrfs/ctree.c | 28 ++++++
fs/btrfs/ctree.h | 25 +++++
fs/btrfs/dev-replace.c | 51 ++--------
fs/btrfs/dir-item.c | 27 +----
fs/btrfs/inode.c | 46 ++++-----
fs/btrfs/send.c | 222 +++++++++++------------------------------
fs/btrfs/volumes.c | 23 ++---
fs/btrfs/xattr.c | 40 +++-----
9 files changed, 169 insertions(+), 326 deletions(-)
--
2.31.1
next reply other threads:[~2021-08-24 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 17:06 Marcos Paulo de Souza [this message]
2021-08-24 17:06 ` [PATCH 1/7] fs: btrfs: Introduce btrfs_for_each_slot Marcos Paulo de Souza
2021-08-25 7:42 ` Johannes Thumshirn
2021-08-25 13:05 ` David Sterba
2021-08-25 13:32 ` Marcos Paulo de Souza
2021-08-24 17:06 ` [PATCH 2/7] btrfs: block-group: use btrfs_for_each_slot in find_first_block_group Marcos Paulo de Souza
2021-08-24 17:06 ` [PATCH 3/7] btrfs: dev-replace: Use btrfs_for_each_slot in mark_block_group_to_copy Marcos Paulo de Souza
2021-08-24 17:06 ` [PATCH 4/7] btrfs: dir-item: use btrfs_for_each_slot in btrfs_search_dir_index_item Marcos Paulo de Souza
2021-08-24 17:06 ` [PATCH 5/7] btrfs: inode: use btrfs_for_each_slot in btrfs_read_readdir Marcos Paulo de Souza
2021-08-24 17:06 ` [PATCH 6/7] btrfs: send: Use btrfs_for_each_slot macro Marcos Paulo de Souza
2021-08-24 17:06 ` [PATCH 7/7] btrfs: volumes: use btrfs_for_each_slot in btrfs_read_chunk_tree Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824170658.12567-1-mpdesouza@suse.com \
--to=mpdesouza@suse.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.