From: Murphy Zhou <xzhou@redhat.com>
To: fstests@vger.kernel.org
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH] common/rc: fix MKSWAP_PROG quoting
Date: Tue, 31 Aug 2021 11:04:26 +0800 [thread overview]
Message-ID: <20210831030426.nwcoelcnshq4wrxx@xzhoux.usersys.redhat.com> (raw)
After commit
0e4dd8b9 common/rc: fix ignoring of errors on
we are getting this error message when running swapfiles tests:
+./common/rc: line 2553: MKSWAP_PROG: command not found
Signed-off-by: Murphy Zhou <xzhou@redhat.com>
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 46b6b220..0597de13 100644
--- a/common/rc
+++ b/common/rc
@@ -2550,7 +2550,7 @@ _format_swapfile() {
$CHATTR_PROG +C "$fname" > /dev/null 2>&1
_pwrite_byte 0x61 0 "$sz" "$fname" >> $seqres.full
# Ignore permission complaints on filesystems that don't support perms
- $(MKSWAP_PROG "$fname" 2> >(grep -v 'insecure permission' >&2)) >> $seqres.full
+ ($MKSWAP_PROG "$fname" 2> >(grep -v 'insecure permission' >&2)) >> $seqres.full
}
_swapon_file() {
--
2.20.1
next reply other threads:[~2021-08-31 3:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 3:04 Murphy Zhou [this message]
2021-08-31 5:26 ` [PATCH] common/rc: fix MKSWAP_PROG quoting Zorro Lang
2021-08-31 7:38 ` Pavel Reichl
2021-08-31 13:42 ` Zorro Lang
2021-08-31 17:05 ` Theodore Ts'o
2021-09-01 6:16 ` [PATCH v2] " Murphy Zhou
2021-09-01 7:15 ` Dave Chinner
2021-09-01 9:40 ` [PATCH v3] " Xiong Zhou
2021-09-03 17:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831030426.nwcoelcnshq4wrxx@xzhoux.usersys.redhat.com \
--to=xzhou@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.