From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev
Cc: Kari Argillander <kari.argillander@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] fs/ntfs3: Refactor header includes
Date: Tue, 31 Aug 2021 17:14:27 +0300 [thread overview]
Message-ID: <20210831141434.975175-1-kari.argillander@gmail.com> (raw)
Right now header includes are big mess with ntfs3 imo. We cannot example
include ntfs3 headers without need of punch of includes to source file.
This patch set try to address that. When this patch series is applied we
can include any header file without need of include anything else. This
does not mean source file should rely what header file includes. Instead
it should include them by self also if it needs them.
When some include is added I have write why this is needed to commit
message. Hopefully this will help when someone wants to correct them
again. I have also just delete unnecessary headers from some .c files
and not added what is needed. Usually deleted headers where there
because ntfs_fs.h need them not file itself. When file was simple enough
I added all necessary linux headers.
I did not add linux/headers to all files yet. That is big job. This is
good starting point. I did try to build every file itself so this will
build like it should.
Please do not hesitate to tell if there is something wrong with this
series or somethings could be done better.
Kari Argillander (7):
fs/ntfs3: Add missing header files to ntfs.h
fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.h
fs/ntfs3: Add missing header and guards to lib/ headers
fs/ntfs3: Change right headers to bitfunc.c
fs/ntfs3: Change right headers to upcase.c
fs/ntfs3: Change right headers to lznt.c
fs/ntfs3: Remove unneeded header files from c files
fs/ntfs3/attrib.c | 5 -----
fs/ntfs3/attrlist.c | 3 ---
fs/ntfs3/bitfunc.c | 7 +------
fs/ntfs3/bitmap.c | 3 ---
fs/ntfs3/dir.c | 3 ---
fs/ntfs3/file.c | 1 -
fs/ntfs3/frecord.c | 3 ---
fs/ntfs3/fslog.c | 4 ----
fs/ntfs3/fsntfs.c | 1 -
fs/ntfs3/index.c | 1 -
fs/ntfs3/inode.c | 2 --
fs/ntfs3/lib/decompress_common.h | 5 +++++
fs/ntfs3/lib/lib.h | 6 ++++++
fs/ntfs3/lznt.c | 10 +++++-----
fs/ntfs3/namei.c | 4 ----
fs/ntfs3/ntfs.h | 9 +++++++++
fs/ntfs3/ntfs_fs.h | 31 +++++++++++++++++++++++++++++++
fs/ntfs3/record.c | 3 ---
fs/ntfs3/run.c | 2 --
fs/ntfs3/super.c | 2 --
fs/ntfs3/upcase.c | 8 ++------
fs/ntfs3/xattr.c | 3 ---
22 files changed, 59 insertions(+), 57 deletions(-)
--
2.25.1
next reply other threads:[~2021-08-31 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 14:14 Kari Argillander [this message]
2021-08-31 14:14 ` [PATCH 1/7] fs/ntfs3: Add missing header files to ntfs.h Kari Argillander
2021-08-31 14:14 ` [PATCH 2/7] fs/ntfs3: Add missing headers and forward declarations to ntfs_fs.h Kari Argillander
2021-08-31 14:14 ` [PATCH 3/7] fs/ntfs3: Add missing header and guards to lib/ headers Kari Argillander
2021-08-31 14:14 ` [PATCH 4/7] fs/ntfs3: Change right headers to bitfunc.c Kari Argillander
2021-08-31 14:14 ` [PATCH 5/7] fs/ntfs3: Change right headers to upcase.c Kari Argillander
2021-08-31 14:14 ` [PATCH 6/7] fs/ntfs3: Change right headers to lznt.c Kari Argillander
2021-08-31 17:54 ` kernel test robot
2021-08-31 17:54 ` kernel test robot
2021-08-31 18:43 ` Kari Argillander
2021-08-31 18:43 ` Kari Argillander
2021-09-01 0:45 ` kernel test robot
2021-09-01 0:45 ` kernel test robot
2021-08-31 14:14 ` [PATCH 7/7] fs/ntfs3: Remove unneeded header files from c files Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831141434.975175-1-kari.argillander@gmail.com \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.