From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FF13C432BE for ; Wed, 1 Sep 2021 21:17:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05B0F60F92 for ; Wed, 1 Sep 2021 21:17:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 05B0F60F92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D8A0582C47; Wed, 1 Sep 2021 23:17:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="W5z4x69o"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4568E8325E; Wed, 1 Sep 2021 23:17:15 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 68C7682952 for ; Wed, 1 Sep 2021 23:17:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id c19so1006188qte.7 for ; Wed, 01 Sep 2021 14:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QisFVKmrffUl5LkH53yslgbAJnBPEWa7LlOKiQxL+oI=; b=W5z4x69o2BCguytVLgo8WJ85IpXfcAqfiTEDxXB5ZxrF1DL5zQiqSWz7QsgWUEsNYS uYktqQ44hoJcR3yAyq/S0VIllcf0joGuC6pLQkvTZL0uad1hN3InNTd3PCDoDToVO2Jd wwr6YIg1hw4Ru15lhwZ9rp+ngwhpDdi/pFJzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QisFVKmrffUl5LkH53yslgbAJnBPEWa7LlOKiQxL+oI=; b=FYbpUneStlB+REHKK2CuTimqrw3zmxHGjcp6tFkhJErk0yFG2f0OFjqxehN4xliTpF 4q743flgZXMIrikORYeC8JIBQn3aBHKqC4Lv54eGNXmZEdVRJHAfp/TY52w9/2o+cSbD qdBRzM8/cdyPRma7dtXNEfNm+XRO5GmHF8SkTwPcgMcNmSiE9cLRYlcVMGv0ga3i6QEK zDnoAne6SVBZVZB4IX9GEXxFA7d90m2fZ21YpNjXASxdkiMDunRuTu2fADqyWPkOQ/D0 jVLeTd09eY9/RqIxgjWdHEeS45OpkI+VJ4lrANI/XiLthjLLQBi39GNniwUkAXAUbe9C vJLA== X-Gm-Message-State: AOAM533DQnkQK2ow5U3L3E10rTNPQKj4wNFaMNy1dW8pYXc9bCGLoxpq HDFHXQKnssMtVtEM4hBjcbGljw== X-Google-Smtp-Source: ABdhPJxTF/nAyM/frbGL3YufVYQSQUJV1Pj5PEjptg5yAVeipxJdOb0ZTcEcyeub64N4XcuAUmYxeQ== X-Received: by 2002:ac8:6e88:: with SMTP id c8mr1440412qtv.241.1630531029147; Wed, 01 Sep 2021 14:17:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9d52-d816-c53d-6548.res6.spectrum.com. [2603:6081:7b01:cbda:9d52:d816:c53d:6548]) by smtp.gmail.com with ESMTPSA id t194sm626346qka.72.2021.09.01.14.17.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Sep 2021 14:17:08 -0700 (PDT) Date: Wed, 1 Sep 2021 17:17:06 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210901211706.GR858@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210901205909.GA23592@bill-the-cat> <20210901210545.4mbkattfc4m7nupl@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QWivEuFOjPSd+vnt" Content-Disposition: inline In-Reply-To: <20210901210545.4mbkattfc4m7nupl@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --QWivEuFOjPSd+vnt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Roh=E1r wrote: > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Roh=E1r wrote: > >=20 > > > Including timestamp.h (either directly or transitionally) cause build > > > system to recompile binaries at every 'make' run. This has disadvanta= ge > > > in U-Boot development as for every small change 'make' recompiles lot= of > > > other irrelevant files which were not touched / changed. > > >=20 > > > This patch series eliminate transitional / indirect usage of > > > timestamp.h by removing unneeded inclusion of header files, moving > > > timestamp values from macros to global variables, etc... > > >=20 > > > After these patches, U-Boot tools are not recompiled by every 'make' = run, > > > which decrease time for incremental U-Boot recompilation. > > >=20 > > > Please test these patches, specially m68k and powerpc parts as I do n= ot > > > have any of these boards. > > >=20 > > > Patch series depend on this patch (now marked as accepted): > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-= 1-pali@kernel.org/ > > >=20 > > > Pali Roh=E1r (11): > > > Remove #include from files which do not need it > > > Remove #include from files which do not need it > > > efi_loader: Use directly version_string variable > > > version: Move version_string[] from version.h to version_string.h > > > m68k: mcf: Remove overloading version_string > > > version: Put version_string[] variable into section > > > .text_version_string > > > powerpc: mpc: Put U-Boot version string at correct place by linker > > > script > > > version: Do not make version_string[] variable as a weak > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > > Remove including timestamp.h in version.h > >=20 > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > this fails to build for at least qemu-ppce500 and xtfpga. Over in=20 > > doc/develop/ci_testing.rst we document how to run a world build. Please > > fix these build errors and re-submit, thanks. >=20 > Already happened about month ago > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-pa= li@kernel.org/ >=20 > As stated, following build command now passes: > make CROSS_COMPILE=3Dpowerpc-linux-gnu- MCR3000_defconfig u-boot.bin OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... --=20 Tom --QWivEuFOjPSd+vnt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEv7c8ACgkQFHw5/5Y0 tyx+ggv+KEtScD7ODx40oNHtMtcDpLP4rvjnHLWEv2B2cdEhhX9e6x5NPyzKncWN WC9wACJHyZtsrfjGUrAJkta4VJIZ8YiNuX9WMeICJ/9wLceTMboRSiw6nlJCneVk WcJgwiAo1kpogEsQmEtZS7sC6n1oRMkrzFCDQF0pMorVb5gB8ydXjr5MZ/vtMnM+ 8QOvOd850UjjlsMNHWt6dqPy2FdQp2s3MRHI82Fr6JsFMAunAeILc4O4gt2ga4Er lnNhS/G3eLItYSY1ZmSkoky0IE7RwKi++8aoU8ewFsj/nCWAZVi7ewaybQhGgf7i Ux/bTofrheW/FB2hMLQEI9Y9ha11IClkVGrF34CFhzynNtOBqhKEmbPOYF9xWl89 aApVVKx8o9wVFg7XCwymhjScT9+P7TX+4cer31ZV765DBI+gYItGTaq/80mD5mAg UPx+JN8pizKzOtYPby5ajyPZtXqBpnRPCl+gSNQp7DQFVikJMRrk361as/xrKd3T 1bsHm3pU =nZIw -----END PGP SIGNATURE----- --QWivEuFOjPSd+vnt--