From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27BBFC432BE for ; Wed, 1 Sep 2021 21:57:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B26F6056B for ; Wed, 1 Sep 2021 21:57:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6B26F6056B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2D9E483265; Wed, 1 Sep 2021 23:56:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TP+eq/Lk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 814BC8327F; Wed, 1 Sep 2021 23:56:56 +0200 (CEST) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77E928325E for ; Wed, 1 Sep 2021 23:56:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id dt3so14128qvb.6 for ; Wed, 01 Sep 2021 14:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=u49rP+uhcUE43GY7bGQPvq+kJ823desII2mTszU7bEE=; b=TP+eq/Lke1/XVYCQXSyvZTq6WThhXA6J3vkbCz59+9cm/HIx7VZ6NRhIC1tyIFxNjP 0w7N+Yqwe+PtDRJ3gBbSvZHJFyxrT943fbOIRksARH54MdEW6EIKJH7KTi4D7A2SEKYR DFurJYnP+6v0yJZJOlI0LWVFCP2vIBymSxqB0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=u49rP+uhcUE43GY7bGQPvq+kJ823desII2mTszU7bEE=; b=s35+Zq4pLoOYfRXkCycin1iyC9Bb75S6a0qjxTEJDFZ6mwa6GOSbju5QaIrcnno9l3 qx2vzxWtgVBG/S8HJa/Cf6dSOsEF3PEsF/fQOxv/xzs/XJ2dXPje5vgK1x2Op53HGRHa TeqXzjT+KfDkQHcdJYw6ZVwwGxypx0c8kcKfF9fK97cJuS99pLzc6AaRND3sSOZqQCpH PwmWe3JiNZLppC6H2aDK3iS4qDYIFga7zXQZk81xGgRiiPBw215RPVkYfIcxGcMJ+fEd eZaOSqdSCz6Xa/4ISDaMlK09IGWZu2siTXLJC3tNyNnVt/p8JBTtyiYE9nd8+Xs5E8I8 OAIA== X-Gm-Message-State: AOAM531c3QFOGlt8Dn/G1hm8kivo47OB1anEzPNvP2KVRq20HLoWP7ED zp32D4VMDB7eKPMhMcVCB9qwpw== X-Google-Smtp-Source: ABdhPJza3mcoyfABnwLAtDE2NfPeJFm7h+WIi+lHj+KLjH2VnYtVeMhScIRp5Pp4dNVZUl7JFdVGug== X-Received: by 2002:ad4:4ab2:: with SMTP id i18mr1564904qvx.44.1630533410144; Wed, 01 Sep 2021 14:56:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9d52-d816-c53d-6548.res6.spectrum.com. [2603:6081:7b01:cbda:9d52:d816:c53d:6548]) by smtp.gmail.com with ESMTPSA id r140sm654511qke.15.2021.09.01.14.56.48 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Sep 2021 14:56:49 -0700 (PDT) Date: Wed, 1 Sep 2021 17:56:47 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210901215647.GU858@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210901205909.GA23592@bill-the-cat> <20210901210545.4mbkattfc4m7nupl@pali> <20210901211706.GR858@bill-the-cat> <20210901212854.dabsvrkga4xdqxdf@pali> <20210901213357.GS858@bill-the-cat> <20210901214452.lxyy7cqjn6fkbghk@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lBegO5Ktmzt2vSF1" Content-Disposition: inline In-Reply-To: <20210901214452.lxyy7cqjn6fkbghk@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --lBegO5Ktmzt2vSF1 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 11:44:52PM +0200, Pali Roh=E1r wrote: > On Wednesday 01 September 2021 17:33:57 Tom Rini wrote: > > On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Roh=E1r wrote: > > > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Roh=E1r wrote: > > > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Roh=E1r wrote: > > > > > >=20 > > > > > > > Including timestamp.h (either directly or transitionally) cau= se build > > > > > > > system to recompile binaries at every 'make' run. This has di= sadvantage > > > > > > > in U-Boot development as for every small change 'make' recomp= iles lot of > > > > > > > other irrelevant files which were not touched / changed. > > > > > > >=20 > > > > > > > This patch series eliminate transitional / indirect usage of > > > > > > > timestamp.h by removing unneeded inclusion of header files, m= oving > > > > > > > timestamp values from macros to global variables, etc... > > > > > > >=20 > > > > > > > After these patches, U-Boot tools are not recompiled by every= 'make' run, > > > > > > > which decrease time for incremental U-Boot recompilation. > > > > > > >=20 > > > > > > > Please test these patches, specially m68k and powerpc parts a= s I do not > > > > > > > have any of these boards. > > > > > > >=20 > > > > > > > Patch series depend on this patch (now marked as accepted): > > > > > > > http://patchwork.ozlabs.org/project/uboot/patch/2021071011100= 1.32325-1-pali@kernel.org/ > > > > > > >=20 > > > > > > > Pali Roh=E1r (11): > > > > > > > Remove #include from files which do not need = it > > > > > > > Remove #include from files which do not need it > > > > > > > efi_loader: Use directly version_string variable > > > > > > > version: Move version_string[] from version.h to version_st= ring.h > > > > > > > m68k: mcf: Remove overloading version_string > > > > > > > version: Put version_string[] variable into section > > > > > > > .text_version_string > > > > > > > powerpc: mpc: Put U-Boot version string at correct place by= linker > > > > > > > script > > > > > > > version: Do not make version_string[] variable as a weak > > > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from de= bug log > > > > > > > version: Remove global macro U_BOOT_VERSION_STRING from ver= sion.h > > > > > > > Remove including timestamp.h in version.h > > > > > >=20 > > > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines= /8948 > > > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over= in=20 > > > > > > doc/develop/ci_testing.rst we document how to run a world build= =2E Please > > > > > > fix these build errors and re-submit, thanks. > > > > >=20 > > > > > Already happened about month ago > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7= 942-1-pali@kernel.org/ > > > > >=20 > > > > > As stated, following build command now passes: > > > > > make CROSS_COMPILE=3Dpowerpc-linux-gnu- MCR3000_defconfig u-boot.= bin > > > >=20 > > > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... > > >=20 > > > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 a= nd > > > this should be fixed above patch. At least I got similar error for > > > MCR3000_defconfig with new gcc before that. > > >=20 > > > But now after scrolling down I see that second xtfpga error > > > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > > > But seems that in this UI is error log truncated. I see only > > >=20 > > > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA [00000000= fe021584,00000000fe0215c7] overlaps section .u_boot_list LMA [00000000fe021= 584,00000000fe021e6b] > > >=20 > > > Is there a way how to show full build log? And which defconfig and > > > compiler is used? Because that error does not help me what is wrong > > > here... > >=20 > > That's the full error log, from the linker, I believe. It's the xtfpga > > config for the xtensa architecture. It's one of the few that buildman > > won't fetch a good toolchain for so you'll want to look at > > tools/docker/Dockerfile and see we get it from > > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_= 64-2020.07-xtensa-dc233c-elf.tar.gz > > if you don't have the CI builder container itself handy already. >=20 > So this is the only other build which failed, right? I suspect that I don't know. The GitLab job is configured in three stages so if something early fails we don't wait forever to fail. The Azure job is over at https://dev.azure.com/u-boot/u-boot/_build/results?buildId=3D2792&view=3Dre= sults and hasn't completed but doesn't look like it's showing anything you haven't already fixed. > there is some other bug in xtfpga linker script, that it missed > specifying wildcard sections and this change triggered it. >=20 > I will try to look at it. >=20 > It is pity that in above gitlab build log is missing full command which > produced that error as in its arguments could be something interesting, > like path to linker script or compile flags... I think what you're missing isn't about gitlab, but rather about buildman. If you've picked up any tips on how to debug these problems, updating doc/develop/ci_testing.rst for the next time would be good. --=20 Tom --lBegO5Ktmzt2vSF1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEv9xwACgkQFHw5/5Y0 tyy5IAv/YrhPcikjZiPMIHMw9pBvlZndFEpCB8pp/xTmq8eu0cWtl6C575YNBRdi f9jxonHZjlXg5P/MQgKJO/Dhk1M/Jc8vpjUvEnOVvl4/WCBybRxIhYKuI9bxv6rr Z9k4iM+wos9OuiMQbO91LMmw12TMNc6ebsSAZqi+lodE4ed0DBQvhiqfxmn0iM69 C8FNOetQ7cm5I/zhomM/n86Xn9bjK2gkVOhxBR8K7afizgBpC3DaqjlkE5rgXS7A 8CGsF+zasGcMte+qi9CBtX2oh5ce8eFm3u1tCbZ0uKI+7HEmbOZ2cKSRQVzpLTma yvnopxFiZtUk79lKnaXsWW97Dvyt6LPiStCRZs3zFipX/rMz7yAZEUCItHMk/V0T 42/CSBe2/aX3c632lpBAHWF/aPawuAuZ6ZSSxZd6I3Gn613oPu6/fhlyOZlY1I2/ H31PMX8Gq8Gonw1UhAOs6k9CLJ8f/NyuYMzqSuPfZylfmsIpjKbgmCibYFH0vIPZ CZnemltt =UmLb -----END PGP SIGNATURE----- --lBegO5Ktmzt2vSF1--