Re: [PATCH 1/4] phy: mediatek: add support for phy-mtk-hdmi-mt8195

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4409 bytes --]

Hi Guillaume,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on pza/reset/next drm-intel/for-linux-next drm-tip/drm-tip linus/master v5.14 next-20210907]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Guillaume-Ranquet/MT8195-HDMI-Tx-support/20210907-164127
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: h8300-randconfig-r033-20210906 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8daa191a0492558bb3ed1dcdb49dadda22f39f64
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Guillaume-Ranquet/MT8195-HDMI-Tx-support/20210907-164127
        git checkout 8daa191a0492558bb3ed1dcdb49dadda22f39f64
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/kernel.h:11,
                    from include/linux/delay.h:22,
                    from drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:6:
   include/linux/scatterlist.h: In function 'sg_set_buf':
   include/asm-generic/page.h:89:51: warning: ordered comparison of pointer with null pointer [-Wextra]
      89 | #define virt_addr_valid(kaddr)  (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
         |                                                   ^~
   include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
      78 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^
   include/linux/scatterlist.h:137:9: note: in expansion of macro 'BUG_ON'
     137 |         BUG_ON(!virt_addr_valid(buf));
         |         ^~~~~~
   include/linux/scatterlist.h:137:17: note: in expansion of macro 'virt_addr_valid'
     137 |         BUG_ON(!virt_addr_valid(buf));
         |                 ^~~~~~~~~~~~~~~
   drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c: At top level:
>> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:32:6: warning: no previous prototype for 'mtk_tmds_high_bit_clk_ratio' [-Wmissing-prototypes]
      32 | void mtk_tmds_high_bit_clk_ratio(struct mtk_hdmi_phy *hdmi_phy, bool enable)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c: In function 'mtk_hdmi_pll_calculate_params':
   drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:369:30: warning: unused variable 'hdmi_phy' [-Wunused-variable]
     369 |         struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw);
         |                              ^~~~~~~~
   drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:351:28: warning: unused variable 'ad_respll_ck' [-Wunused-variable]
     351 |         unsigned long long ad_respll_ck = 0;
         |                            ^~~~~~~~~~~~
   drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:349:28: warning: unused variable 'hdmirx_ref_ck' [-Wunused-variable]
     349 |         unsigned long long hdmirx_ref_ck = 0;
         |                            ^~~~~~~~~~~~~


vim +/mtk_tmds_high_bit_clk_ratio +32 drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c

    31	
  > 32	void mtk_tmds_high_bit_clk_ratio(struct mtk_hdmi_phy *hdmi_phy, bool enable)
    33	{
    34		mtk_hdmi_ana_fifo_en(hdmi_phy);
    35	
    36		/* HDMI 2.0 specification, 3.4Gbps <= TMDS Bit Rate <= 6G,
    37		 * clock bit ratio 1:40, under 3.4Gbps, clock bit ratio 1:10
    38		 */
    39		if (enable)
    40			mtk_hdmi_phy_mask(hdmi_phy, HDMI20_CLK_CFG,
    41					  (0x2 << reg_txc_div_SHIFT), reg_txc_div);
    42		else
    43			mtk_hdmi_phy_mask(hdmi_phy, HDMI20_CLK_CFG, 0, reg_txc_div);
    44	}
    45	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 24802 bytes --]