From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support
Date: Sun, 12 Sep 2021 06:22:59 +0800 [thread overview]
Message-ID: <202109120620.ZHmW3VFp-lkp@intel.com> (raw)
In-Reply-To: <20210910064322.67705-9-hare@suse.de>
[-- Attachment #1: Type: text/plain, Size: 8743 bytes --]
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.14 next-20210910]
[cannot apply to cryptodev/master crypto/master linux-nvme/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/nvme-In-band-authentication-support/20210910-144627
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bf9f243f23e6623f310ba03fbb14e10ec3a61290
config: powerpc-randconfig-s032-20210911 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/8b89de04a6eef68be62dcebf344e946c3e6843de
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hannes-Reinecke/nvme-In-band-authentication-support/20210910-144627
git checkout 8b89de04a6eef68be62dcebf344e946c3e6843de
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/nvme/host/ drivers/nvme/target/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/host/auth.c:235:24: sparse: sparse: Using plain integer as NULL pointer
>> drivers/nvme/host/auth.c:509:26: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [assigned] [usertype] tl @@ got unsigned long [usertype] tl @@
drivers/nvme/host/auth.c:509:26: sparse: expected restricted __le32 [assigned] [usertype] tl
drivers/nvme/host/auth.c:509:26: sparse: got unsigned long [usertype] tl
>> drivers/nvme/host/auth.c:537:29: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le32 [assigned] [usertype] al @@ got unsigned long [usertype] al @@
drivers/nvme/host/auth.c:537:29: sparse: expected restricted __le32 [assigned] [usertype] al
drivers/nvme/host/auth.c:537:29: sparse: got unsigned long [usertype] al
>> drivers/nvme/host/auth.c:618:54: sparse: sparse: restricted __le16 degrades to integer
>> drivers/nvme/host/auth.c:735:46: sparse: sparse: incorrect type in argument 1 (different base types) @@ expected unsigned long [usertype] size @@ got restricted __le16 [usertype] dhvlen @@
drivers/nvme/host/auth.c:735:46: sparse: expected unsigned long [usertype] size
drivers/nvme/host/auth.c:735:46: sparse: got restricted __le16 [usertype] dhvlen
>> drivers/nvme/host/auth.c:738:36: sparse: sparse: incorrect type in assignment (different base types) @@ expected int ctrl_key_len @@ got restricted __le16 [usertype] dhvlen @@
drivers/nvme/host/auth.c:738:36: sparse: expected int ctrl_key_len
drivers/nvme/host/auth.c:738:36: sparse: got restricted __le16 [usertype] dhvlen
drivers/nvme/host/auth.c:740:28: sparse: sparse: incorrect type in argument 3 (different base types) @@ expected unsigned long [usertype] size @@ got restricted __le16 [usertype] dhvlen @@
drivers/nvme/host/auth.c:740:28: sparse: expected unsigned long [usertype] size
drivers/nvme/host/auth.c:740:28: sparse: got restricted __le16 [usertype] dhvlen
>> drivers/nvme/host/auth.c:773:22: sparse: sparse: incorrect type in assignment (different base types) @@ expected restricted __le16 [usertype] dhvlen @@ got int host_key_len @@
drivers/nvme/host/auth.c:773:22: sparse: expected restricted __le16 [usertype] dhvlen
drivers/nvme/host/auth.c:773:22: sparse: got int host_key_len
vim +235 drivers/nvme/host/auth.c
0f7847d23405a2 Hannes Reinecke 2021-09-10 224
0f7847d23405a2 Hannes Reinecke 2021-09-10 225 u8 *nvme_auth_transform_key(u8 *key, size_t key_len, u8 key_hash, char *nqn)
0f7847d23405a2 Hannes Reinecke 2021-09-10 226 {
0f7847d23405a2 Hannes Reinecke 2021-09-10 227 const char *hmac_name = nvme_auth_hmac_name(key_hash);
0f7847d23405a2 Hannes Reinecke 2021-09-10 228 struct crypto_shash *key_tfm;
0f7847d23405a2 Hannes Reinecke 2021-09-10 229 struct shash_desc *shash;
0f7847d23405a2 Hannes Reinecke 2021-09-10 230 u8 *transformed_key;
0f7847d23405a2 Hannes Reinecke 2021-09-10 231 int ret;
0f7847d23405a2 Hannes Reinecke 2021-09-10 232
0f7847d23405a2 Hannes Reinecke 2021-09-10 233 /* No key transformation required */
0f7847d23405a2 Hannes Reinecke 2021-09-10 234 if (key_hash == 0)
0f7847d23405a2 Hannes Reinecke 2021-09-10 @235 return 0;
0f7847d23405a2 Hannes Reinecke 2021-09-10 236
0f7847d23405a2 Hannes Reinecke 2021-09-10 237 hmac_name = nvme_auth_hmac_name(key_hash);
0f7847d23405a2 Hannes Reinecke 2021-09-10 238 if (!hmac_name) {
0f7847d23405a2 Hannes Reinecke 2021-09-10 239 pr_warn("Invalid key hash id %d\n", key_hash);
0f7847d23405a2 Hannes Reinecke 2021-09-10 240 return ERR_PTR(-EKEYREJECTED);
0f7847d23405a2 Hannes Reinecke 2021-09-10 241 }
0f7847d23405a2 Hannes Reinecke 2021-09-10 242 key_tfm = crypto_alloc_shash(hmac_name, 0, 0);
0f7847d23405a2 Hannes Reinecke 2021-09-10 243 if (IS_ERR(key_tfm))
0f7847d23405a2 Hannes Reinecke 2021-09-10 244 return (u8 *)key_tfm;
0f7847d23405a2 Hannes Reinecke 2021-09-10 245
0f7847d23405a2 Hannes Reinecke 2021-09-10 246 shash = kmalloc(sizeof(struct shash_desc) +
0f7847d23405a2 Hannes Reinecke 2021-09-10 247 crypto_shash_descsize(key_tfm),
0f7847d23405a2 Hannes Reinecke 2021-09-10 248 GFP_KERNEL);
0f7847d23405a2 Hannes Reinecke 2021-09-10 249 if (!shash) {
0f7847d23405a2 Hannes Reinecke 2021-09-10 250 crypto_free_shash(key_tfm);
0f7847d23405a2 Hannes Reinecke 2021-09-10 251 return ERR_PTR(-ENOMEM);
0f7847d23405a2 Hannes Reinecke 2021-09-10 252 }
0f7847d23405a2 Hannes Reinecke 2021-09-10 253 transformed_key = kzalloc(crypto_shash_digestsize(key_tfm), GFP_KERNEL);
0f7847d23405a2 Hannes Reinecke 2021-09-10 254 if (!transformed_key) {
0f7847d23405a2 Hannes Reinecke 2021-09-10 255 ret = -ENOMEM;
0f7847d23405a2 Hannes Reinecke 2021-09-10 256 goto out_free_shash;
0f7847d23405a2 Hannes Reinecke 2021-09-10 257 }
0f7847d23405a2 Hannes Reinecke 2021-09-10 258
0f7847d23405a2 Hannes Reinecke 2021-09-10 259 shash->tfm = key_tfm;
0f7847d23405a2 Hannes Reinecke 2021-09-10 260 ret = crypto_shash_setkey(key_tfm, key, key_len);
0f7847d23405a2 Hannes Reinecke 2021-09-10 261 if (ret < 0)
0f7847d23405a2 Hannes Reinecke 2021-09-10 262 goto out_free_shash;
0f7847d23405a2 Hannes Reinecke 2021-09-10 263 ret = crypto_shash_init(shash);
0f7847d23405a2 Hannes Reinecke 2021-09-10 264 if (ret < 0)
0f7847d23405a2 Hannes Reinecke 2021-09-10 265 goto out_free_shash;
0f7847d23405a2 Hannes Reinecke 2021-09-10 266 ret = crypto_shash_update(shash, nqn, strlen(nqn));
0f7847d23405a2 Hannes Reinecke 2021-09-10 267 if (ret < 0)
0f7847d23405a2 Hannes Reinecke 2021-09-10 268 goto out_free_shash;
0f7847d23405a2 Hannes Reinecke 2021-09-10 269 ret = crypto_shash_update(shash, "NVMe-over-Fabrics", 17);
0f7847d23405a2 Hannes Reinecke 2021-09-10 270 if (ret < 0)
0f7847d23405a2 Hannes Reinecke 2021-09-10 271 goto out_free_shash;
0f7847d23405a2 Hannes Reinecke 2021-09-10 272 ret = crypto_shash_final(shash, transformed_key);
0f7847d23405a2 Hannes Reinecke 2021-09-10 273 out_free_shash:
0f7847d23405a2 Hannes Reinecke 2021-09-10 274 kfree(shash);
0f7847d23405a2 Hannes Reinecke 2021-09-10 275 crypto_free_shash(key_tfm);
0f7847d23405a2 Hannes Reinecke 2021-09-10 276 if (ret < 0) {
0f7847d23405a2 Hannes Reinecke 2021-09-10 277 kfree_sensitive(transformed_key);
0f7847d23405a2 Hannes Reinecke 2021-09-10 278 return ERR_PTR(ret);
0f7847d23405a2 Hannes Reinecke 2021-09-10 279 }
0f7847d23405a2 Hannes Reinecke 2021-09-10 280 return transformed_key;
0f7847d23405a2 Hannes Reinecke 2021-09-10 281 }
0f7847d23405a2 Hannes Reinecke 2021-09-10 282 EXPORT_SYMBOL_GPL(nvme_auth_transform_key);
0f7847d23405a2 Hannes Reinecke 2021-09-10 283
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34687 bytes --]
next prev parent reply other threads:[~2021-09-11 22:22 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 6:43 [PATCHv3 00/12] nvme: In-band authentication support Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-10 6:43 ` [PATCH 01/12] crypto: add crypto_has_shash() Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-13 13:15 ` Sagi Grimberg
2021-09-13 13:15 ` Sagi Grimberg
2021-09-16 17:01 ` Chaitanya Kulkarni
2021-09-16 17:01 ` Chaitanya Kulkarni
2021-09-10 6:43 ` [PATCH 02/12] crypto: add crypto_has_kpp() Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-13 13:16 ` Sagi Grimberg
2021-09-13 13:16 ` Sagi Grimberg
2021-09-16 17:02 ` Chaitanya Kulkarni
2021-09-16 17:02 ` Chaitanya Kulkarni
2021-09-10 6:43 ` [PATCH 03/12] crypto/ffdhe: Finite Field DH Ephemeral Parameters Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-10 6:43 ` [PATCH 04/12] lib/base64: RFC4648-compliant base64 encoding Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-10 6:43 ` [PATCH 05/12] nvme: add definitions for NVMe In-Band authentication Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-13 13:18 ` Sagi Grimberg
2021-09-13 13:18 ` Sagi Grimberg
2021-09-16 17:04 ` Chaitanya Kulkarni
2021-09-16 17:04 ` Chaitanya Kulkarni
2021-09-17 5:39 ` Hannes Reinecke
2021-09-17 5:39 ` Hannes Reinecke
2021-09-10 6:43 ` [PATCH 06/12] nvme-fabrics: decode 'authentication required' connect error Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-13 13:18 ` Sagi Grimberg
2021-09-13 13:18 ` Sagi Grimberg
2021-09-16 17:04 ` Chaitanya Kulkarni
2021-09-16 17:04 ` Chaitanya Kulkarni
2021-09-10 6:43 ` [PATCH 07/12] nvme: Implement In-Band authentication Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-13 13:55 ` Sagi Grimberg
2021-09-13 13:55 ` Sagi Grimberg
2021-09-13 14:33 ` Hannes Reinecke
2021-09-13 14:33 ` Hannes Reinecke
2021-09-14 7:06 ` Sagi Grimberg
2021-09-14 7:06 ` Sagi Grimberg
2021-09-14 7:19 ` Hannes Reinecke
2021-09-14 7:19 ` Hannes Reinecke
2021-09-16 17:23 ` Chaitanya Kulkarni
2021-09-26 22:04 ` Sagi Grimberg
2021-09-26 22:04 ` Sagi Grimberg
2021-09-27 7:26 ` Hannes Reinecke
2021-09-27 7:26 ` Hannes Reinecke
2021-09-27 7:52 ` Sagi Grimberg
2021-09-27 7:52 ` Sagi Grimberg
2021-09-26 22:53 ` Sagi Grimberg
2021-09-26 22:53 ` Sagi Grimberg
2021-09-27 5:48 ` Hannes Reinecke
2021-09-27 5:48 ` Hannes Reinecke
2021-09-27 7:52 ` Sagi Grimberg
2021-09-27 7:52 ` Sagi Grimberg
2021-09-10 6:43 ` [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-11 22:22 ` kernel test robot [this message]
2021-09-10 6:43 ` [PATCH 09/12] nvmet: Parse fabrics commands on all queues Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-13 13:56 ` Sagi Grimberg
2021-09-13 13:56 ` Sagi Grimberg
2021-09-10 6:43 ` [PATCH 10/12] nvmet: Implement basic In-Band Authentication Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-11 23:10 ` kernel test robot
2021-09-26 14:30 ` Sagi Grimberg
2021-09-26 14:30 ` Sagi Grimberg
2021-09-26 22:51 ` Sagi Grimberg
2021-09-26 22:51 ` Sagi Grimberg
2021-09-27 6:40 ` Hannes Reinecke
2021-09-27 6:40 ` Hannes Reinecke
2021-09-27 7:17 ` Hannes Reinecke
2021-09-27 7:17 ` Hannes Reinecke
2021-09-27 7:55 ` Sagi Grimberg
2021-09-27 7:55 ` Sagi Grimberg
2021-09-27 8:28 ` Hannes Reinecke
2021-09-27 8:28 ` Hannes Reinecke
2021-09-28 22:36 ` Sagi Grimberg
2021-09-28 22:36 ` Sagi Grimberg
2021-09-29 6:01 ` Hannes Reinecke
2021-09-29 6:01 ` Hannes Reinecke
2021-09-10 6:43 ` [PATCH 11/12] nvmet-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-11 23:47 ` kernel test robot
2021-09-10 6:43 ` [PATCH 12/12] nvmet-auth: expire authentication sessions Hannes Reinecke
2021-09-10 6:43 ` Hannes Reinecke
2021-09-13 9:16 ` [PATCHv3 00/12] nvme: In-band authentication support Sagi Grimberg
2021-09-13 9:16 ` Sagi Grimberg
2021-09-13 9:43 ` Hannes Reinecke
2021-09-13 9:43 ` Hannes Reinecke
2021-09-19 10:02 ` Sagi Grimberg
2021-09-19 10:02 ` Sagi Grimberg
2021-09-28 6:03 [PATCHv4 " Hannes Reinecke
2021-09-28 6:03 ` [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-09-28 6:03 ` Hannes Reinecke
2021-11-12 12:59 [PATCHv5 00/12] nvme: In-band authentication support Hannes Reinecke
2021-11-12 12:59 ` [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-11-22 7:47 [PATCHv6 00/12] nvme: In-band authentication support Hannes Reinecke
2021-11-22 7:47 ` [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-11-23 12:37 [PATCHv7 00/12] nvme: In-band authentication support Hannes Reinecke
2021-11-23 12:37 ` [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
2021-12-02 15:23 [PATCHv8 00/12] nvme: In-band authentication support Hannes Reinecke
2021-12-02 15:23 ` [PATCH 08/12] nvme-auth: Diffie-Hellman key exchange support Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202109120620.ZHmW3VFp-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.