From: Christoph Hellwig <hch@lst.de>
To: Andreas Larsson <andreas@gaisler.com>
Cc: Christoph Hellwig <hch@lst.de>,
David Miller <davem@davemloft.net>,
sparclinux@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, software@gaisler.com
Subject: Re: [PATCH] sparc32: Page align size in arch_dma_alloc
Date: Tue, 14 Sep 2021 13:26:46 +0200 [thread overview]
Message-ID: <20210914112646.GA18171@lst.de> (raw)
In-Reply-To: <a5483206-0539-1d3f-c8e8-e66dbb6c8d96@gaisler.com>
On Tue, Sep 14, 2021 at 01:16:16PM +0200, Andreas Larsson wrote:
> Before the patch, arch_dma_alloc did via srmmu_mapiorange set up pages with
> SRMMU_PRIV, which is all fine as it sets up kernel buffers. With your patch
> we get PAGE_KERNEL as an argument to dma_pgprot in the corresponding call
> path that earlier lead to arch_dma_alloc. PAGE_KERNEL already includes
> SRMMU_PRIV so adding it again should not be necessary.
You're right, I missed that PAGE_KERNEL already includes SRMMU_PRIV.
next prev parent reply other threads:[~2021-09-14 11:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 7:48 [PATCH] sparc32: Page align size in arch_dma_alloc Andreas Larsson
2021-09-09 6:07 ` Christoph Hellwig
2021-09-13 13:18 ` Andreas Larsson
2021-09-14 6:17 ` Christoph Hellwig
2021-09-14 8:51 ` Andreas Larsson
2021-09-14 10:42 ` Christoph Hellwig
2021-09-14 11:16 ` Andreas Larsson
2021-09-14 11:26 ` Christoph Hellwig [this message]
[not found] ` <YTjfJl6YmBCdZ8XB@ravnborg.org>
2021-09-14 6:12 ` Christoph Hellwig
2021-09-14 11:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914112646.GA18171@lst.de \
--to=hch@lst.de \
--cc=andreas@gaisler.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=software@gaisler.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.