From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D101C433F5 for ; Fri, 17 Sep 2021 12:05:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0B9761029 for ; Fri, 17 Sep 2021 12:04:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0B9761029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 676BF8319C; Fri, 17 Sep 2021 14:04:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MNkfsE/g"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DBD238320D; Fri, 17 Sep 2021 14:04:54 +0200 (CEST) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 691D580098 for ; Fri, 17 Sep 2021 14:04:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id c7so11120309qka.2 for ; Fri, 17 Sep 2021 05:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=B+3pjhBcrCoi7qorkuBEY+Jg8YixqaCFtWkmJezi5HA=; b=MNkfsE/gCpveR/CMUy1RJ00zSpGGheMhWXXMVlYOBpGV1JpPwtpjOYimt2ue1k6K9U X2tdUMm6ooM4xtsASXiqHNLo9A3ctceZDjXkicU/Dh+0NGGvHLmGuTp+gnpMO5EFOSjb V7E86EOj+xM2LXTaKLFSuw4+KiF6lcA6Ismfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=B+3pjhBcrCoi7qorkuBEY+Jg8YixqaCFtWkmJezi5HA=; b=KXNUnWTwgE/Go53iin78CjHLDQnUUydbl2hap0OAvbE7eL4EbiD175jp2whe9BuYAF kseJQQM4MvYbgkQAlBe0ey6lGkWGYwqbdaF+AVh2p/ubzX7+q3LNgADaiTcetHJyASQj RDnGJuqVxg7eJJxu0dAHDQVV6YJXTJbI78lfeUnC7E2I0mQe8OF0HNcDksGlbTpyfSI0 GzTtqWM76Iz1SAhEQOPPjmzpaM8iW5f+4wNEYBHl/ndz4jzm9Vfec3aWWZK9c6Aacm0f muDjIEY+VHsH7HgMBxG8GYAEmGVJ9qmWceI1S3/DP3UmOP9/MfJ6pLELcFZgIBMB7PB8 AbvQ== X-Gm-Message-State: AOAM531qp1T4hGZqH6tFfdC7LKoHb1OCB1HEtm16HiDzWdKFNH/1pKVJ DgmuE8hYxmALacYfje+dh5KOqw== X-Google-Smtp-Source: ABdhPJxlXdDXha8on0mWtYJqgQRkT0iSG5iJszHF+mpXkMQFk6doxMd7k3OVowoJ9yRyAWF5kSPQ5Q== X-Received: by 2002:a05:620a:4cb:: with SMTP id 11mr6907608qks.296.1631880290053; Fri, 17 Sep 2021 05:04:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a431-c986-449b-ee60.res6.spectrum.com. [2603:6081:7b01:cbda:a431:c986:449b:ee60]) by smtp.gmail.com with ESMTPSA id c10sm4076126qtb.20.2021.09.17.05.04.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 Sep 2021 05:04:49 -0700 (PDT) Date: Fri, 17 Sep 2021 08:04:47 -0400 From: Tom Rini To: Max Filippov Cc: U-Boot Mailing List Subject: Re: [PATCH] xtensa: Put U-Boot version string at correct place by linker script Message-ID: <20210917120447.GF3997@bill-the-cat> References: <20210802131838.21097-7-pali@kernel.org> <20210916173021.3347-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SWTRyWv/ijrBap1m" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --SWTRyWv/ijrBap1m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 16, 2021 at 10:14:03PM -0700, Max Filippov wrote: > On Thu, Sep 16, 2021 at 10:30 AM Tom Rini wrote: > > > > Update the linker script macros to know that we need to include the > > .text_version_string section now as well. > > > > Signed-off-by: Tom Rini > > --- > > arch/xtensa/include/asm/ldscript.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/xtensa/include/asm/ldscript.h b/arch/xtensa/include/a= sm/ldscript.h > > index 08f5d0135ed0..84c496e09f1b 100644 > > --- a/arch/xtensa/include/asm/ldscript.h > > +++ b/arch/xtensa/include/asm/ldscript.h > > @@ -72,6 +72,7 @@ > > { = \ > > _text_start =3D ABSOLUTE(.); = \ > > *(.literal .text) = \ > > + *(.literal .text_version_string) = \ >=20 > This does not belong to .text, as far as I understand it's rodata and so > it should go with rodata, probably like this: > ---8<--- > diff --git a/arch/xtensa/include/asm/ldscript.h > b/arch/xtensa/include/asm/ldscript.h > index 08f5d0135ed0..e03fcffdd6f1 100644 > --- a/arch/xtensa/include/asm/ldscript.h > +++ b/arch/xtensa/include/asm/ldscript.h > @@ -87,6 +87,7 @@ > _rodata_start =3D ABSOLUTE(.); \ > *(.rodata) \ > *(.rodata.*) \ > + *(.text_version_string) \ > *(.dtb.init.rodata) \ > *(.gnu.linkonce.r.*) \ > *(.rodata1) \ So this is in context with: https://patchwork.ozlabs.org/project/uboot/list/?series=3D256258 and specifically: https://patchwork.ozlabs.org/project/uboot/patch/20210802131838.21097-7-pal= i@kernel.org/ Now that said, I think the whole point of that has been removed with: https://patchwork.ozlabs.org/project/uboot/patch/20210916195648.9424-1-trin= i@konsulko.com/ and no longer needing to reference it from the linker script for PowerPC. So maybe I can just drop this whole part. --=20 Tom --SWTRyWv/ijrBap1m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFEhF8ACgkQFHw5/5Y0 tywHdgv/djTAyVF3qgamqxQE2InyVeegUgJktcX47KDmAbuiCY0HyNmiXfk3YQz6 K886VkXMjrPRhEl+FebDKPm8pOGP7plIkSPJpvxtH70C6Qvv1TmiR1c+VQp1iyty +ItEU5WiIXMGXklX8VdTK1zMKDXLHFeNPav0plFzbvKHJs9a8N5CcqrnCNqWO+Ah PQNSzYFzP2ZBnmiqfKqNi6gb3PEqsyyc+3L1cCc7hKE1u+kFxX+B8lwJEiy/q0zF 3cKCvwLLh01Gh3uR363rTmGbv5ZOKhOoaoUEzbi04uvruhlqcxyCvJrevD8KxpEN Vf7Mboqzj/qL6h/RNVEcrayXVTIbMJBKtqkfJLR9aKPWICReGvciqGHaoY0tCMra nqWoT/Wj78d4bNKdGdB4DTMhq8ySXCwlRSq+rj14O54q15PXR2VShQZSQvn0oWBy JL3ZX96cyMy0vGWNUC7MbxkzKTWnP7MtA+ltERHTbX0P0PyqaioKjlqFYbK4XG+F 7M9Io4z1 =hqyZ -----END PGP SIGNATURE----- --SWTRyWv/ijrBap1m--