From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, pbonzini@redhat.com, michael.roth@amd.com,
armbru@redhat.com, vsementsov@virtuozzo.com, den@openvz.org
Subject: [PATCH 0/5] trace: inroduce qmp: trace namespace
Date: Thu, 23 Sep 2021 22:54:46 +0300 [thread overview]
Message-ID: <20210923195451.714796-1-vsementsov@virtuozzo.com> (raw)
Hi all!
We have handle_qmp_command and qmp_command_repond trace points to trace
qmp commands. They are very useful to debug problems involving
management tools like libvirt.
But tracing all qmp commands is too much.
Here I suggest a kind of tracing namespace. Formally this series adds a
trace points called qmp:<some-command> for every command, which may be
enabled in separate like
--trace qmp:drive-backup
or by pattern like
--trace qmp:block-job-*
or similarly with help of qmp command trace-event-set-state.
This also allows to enable tracing of some qmp commands permanently
(by downstream patch or in libvirt xml). For example, I'm going to
enable tracing of block job comamnds and blockdev-* commands in
Virtuozzo. Qemu logs are often too empty (for example, in comparison
with Libvirt), logging block jobs is not too much but will be very
helpful.
Vladimir Sementsov-Ogievskiy (5):
trace/control: introduce trace_opt_parse_opts()
qapi/qmp: QmpCommand: add .tracing field and API
monitor: add qmp tracing API for qmp_commands
util/qemu-option: make qemu_opt_del_all() function public
trace: add qmp trace event namespace
include/monitor/monitor.h | 3 +++
include/qapi/qmp/dispatch.h | 14 ++++++++++++++
include/qemu/option.h | 1 +
trace/control.h | 7 +++++++
monitor/qmp.c | 10 ++++++++++
qapi/qmp-dispatch.c | 20 ++++++++++++++++++++
qapi/qmp-registry.c | 27 +++++++++++++++++++++++++++
softmmu/vl.c | 21 ++++++++++++++++++++-
trace/control.c | 18 ++++++++++++------
trace/qmp.c | 20 ++++++++++++++++++++
util/qemu-option.c | 2 +-
qapi/trace-events | 2 ++
12 files changed, 137 insertions(+), 8 deletions(-)
--
2.29.2
next reply other threads:[~2021-09-23 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 19:54 Vladimir Sementsov-Ogievskiy [this message]
2021-09-23 19:54 ` [PATCH 1/5] trace/control: introduce trace_opt_parse_opts() Vladimir Sementsov-Ogievskiy
2021-09-23 19:54 ` [PATCH 2/5] qapi/qmp: QmpCommand: add .tracing field and API Vladimir Sementsov-Ogievskiy
2021-09-23 19:54 ` [PATCH 3/5] monitor: add qmp tracing API for qmp_commands Vladimir Sementsov-Ogievskiy
2021-09-23 19:54 ` [PATCH 4/5] util/qemu-option: make qemu_opt_del_all() function public Vladimir Sementsov-Ogievskiy
2021-09-23 19:54 ` [PATCH 5/5] trace: add qmp trace event namespace Vladimir Sementsov-Ogievskiy
2021-10-12 11:49 ` [PATCH 0/5] trace: inroduce qmp: trace namespace Markus Armbruster
2021-10-14 15:22 ` Vladimir Sementsov-Ogievskiy
2021-10-25 12:28 ` Stefan Hajnoczi
2021-10-26 10:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923195451.714796-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.