All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Willian Rampazzo" <wrampazz@redhat.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Kamil Rytarowski" <kamil@netbsd.org>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Reinoud Zandijk" <reinoud@netbsd.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Auger Eric" <eric.auger@redhat.com>,
	"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Beraldo Leal" <bleal@redhat.com>,
	qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Ryo ONODERA" <ryoon@netbsd.org>
Subject: [PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown()
Date: Fri, 24 Sep 2021 14:54:55 -0400	[thread overview]
Message-ID: <20210924185506.2542588-6-crosa@redhat.com> (raw)
In-Reply-To: <20210924185506.2542588-1-crosa@redhat.com>

The avocado.Test class, used as the basis of the avocado_qemu.Test
class, performs a clean of temporary directories up as part of its own
tearDown() implementation.

But the avocado_qemu.Test class is currently missing the same clean
up, as it implemented its own tearDown() method without resorting to
the upper class behavior.

This brings avocado_qemu.Test behavior in sync with the standard
avocado.Test behavior and prevents temporary directories from
cluttering the test results directory (unless instructed to do so with
Avocado's "--keep-tmp" option).

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 tests/acceptance/avocado_qemu/__init__.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py
index 2c4fef3e14..1e807e2e55 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -276,6 +276,7 @@ def tearDown(self):
         for vm in self._vms.values():
             vm.shutdown()
         self._sd = None
+        super(Test, self).tearDown()
 
     def fetch_asset(self, name,
                     asset_hash=None, algorithm=None,
-- 
2.31.1



  parent reply	other threads:[~2021-09-24 19:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24 18:54 [PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements Cleber Rosa
2021-09-24 18:54 ` [PATCH 01/16] Acceptance Tests: bump Avocado requirement to 91.0 Cleber Rosa
2021-10-06 18:39   ` Willian Rampazzo
2021-09-24 18:54 ` [PATCH 02/16] Acceptance Tests: improve check-acceptance description Cleber Rosa
2021-09-27 14:40   ` Philippe Mathieu-Daudé
2021-09-24 18:54 ` [PATCH 03/16] Acceptance Tests: add mechanism for listing tests Cleber Rosa
2021-10-06 18:47   ` Willian Rampazzo
2021-09-24 18:54 ` [PATCH 04/16] Acceptance Tests: keep track and disable tests with known issues Cleber Rosa
2021-09-24 18:54 ` Cleber Rosa [this message]
2021-09-24 19:38   ` [PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown() Willian Rampazzo
2021-09-24 18:54 ` [PATCH 06/16] Acceptance Tests: use extract from package from avocado.utils Cleber Rosa
2021-09-24 18:54 ` [PATCH 07/16] Acceptance Tests: workaround expired mipsdistros.mips.com HTTPS cert Cleber Rosa
2021-09-24 18:54 ` [PATCH 08/16] acceptance/tests/vnc.py: use explicit syntax for enabling passwords Cleber Rosa
2021-09-27 14:41   ` Philippe Mathieu-Daudé
2021-09-24 18:54 ` [PATCH 09/16] tests/acceptance/boot_xen.py: merge base classes Cleber Rosa
2021-10-06 18:57   ` Willian Rampazzo
2021-09-24 18:55 ` [PATCH 10/16] tests/acceptance/boot_xen.py: unify tags Cleber Rosa
2021-10-06 18:56   ` Willian Rampazzo
2021-09-24 18:55 ` [PATCH 11/16] tests/acceptance/boot_xen.py: fetch kernel during test setUp() Cleber Rosa
2021-10-06 18:55   ` Willian Rampazzo
2021-09-24 18:55 ` [PATCH 12/16] tests/acceptance/boot_xen.py: removed unused import Cleber Rosa
2021-09-27 14:43   ` Philippe Mathieu-Daudé
2021-09-24 18:55 ` [PATCH 13/16] tests/acceptance/boot_xen.py: use class attribute Cleber Rosa
2021-10-06 18:58   ` Willian Rampazzo
2021-09-24 18:55 ` [PATCH 14/16] tests/acceptance/ppc_prep_40p.py: NetBSD 7.1.2 location update Cleber Rosa
2021-09-27 15:26   ` Philippe Mathieu-Daudé
2021-09-30 19:19     ` Reinoud Zandijk
2021-09-30 19:44       ` Philippe Mathieu-Daudé
2021-09-24 18:55 ` [PATCH 15/16] tests/acceptance/ppc_prep_40p.py: clean up unused import Cleber Rosa
2021-09-27 14:42   ` Philippe Mathieu-Daudé
2021-09-24 18:55 ` [PATCH 16/16] tests/acceptance/ppc_prep_40p.py: unify tags Cleber Rosa
2021-09-27 14:45   ` Philippe Mathieu-Daudé
2021-10-06 19:17   ` Willian Rampazzo
2021-10-06 19:19     ` Willian Rampazzo
2021-09-27  9:09 ` [PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements Pavel Dovgalyuk
2021-09-27 16:46 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924185506.2542588-6-crosa@redhat.com \
    --to=crosa@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=erdnaxe@crans.org \
    --cc=eric.auger@redhat.com \
    --cc=groug@kaod.org \
    --cc=hpoussin@reactos.org \
    --cc=kamil@netbsd.org \
    --cc=ma.mandourr@gmail.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=reinoud@netbsd.org \
    --cc=ryoon@netbsd.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wrampazz@redhat.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.