From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
Lee Jones <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>
Subject: Re: [PATCH v1 2/4] mfd: arizona: Add missing entries SPI to device ID table
Date: Mon, 27 Sep 2021 10:27:54 +0000 [thread overview]
Message-ID: <20210927102754.GE9223@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20210924112000.GB4840@sirena.org.uk>
On Fri, Sep 24, 2021 at 12:20:01PM +0100, Mark Brown wrote:
> On Fri, Sep 24, 2021 at 10:24:17AM +0100, Richard Fitzgerald wrote:
> > On 23/09/2021 20:46, Mark Brown wrote:
>
> > > Currently autoloading for SPI devices does not use the DT ID table, it uses
> > > SPI modalises. Supporting OF modalises is going to be difficult if not
> > > impractical, an attempt was made but has been reverted, so ensure that
> > > module autoloading works for this driver by adding SPI IDs for parts that
> > > only have a compatible listed.
>
> > > static const struct spi_device_id arizona_spi_ids[] = {
> > > + { "wm1814", WM1814 },
> > > { "wm5102", WM5102 },
> > > { "wm5110", WM5110 },
> > > { "wm8280", WM8280 },
> > > + { "wm8997", WM8997 },
> > > + { "wm8998", WM8998 },
>
> > WM1814, WM8997 and WM8998 do not have a SPI interface, which is why they
> > aren't in the table of SPI IDs.
>
> They're listed as valid DT compatibles for SPI so will now generate
> warnings on boot, the driver should not list those compatibles if
> they're not valid.
Yeah we should really be having different lists for SPI and I2C
here I guess. I am happy to have a quick look at doing a patch
for that, unless you particularly want to fix it up?
Thanks,
Charles
next prev parent reply other threads:[~2021-09-27 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 19:46 [PATCH v1 0/4] mfd: Ensure DT compatibles have SPI device IDs Mark Brown
2021-09-23 19:46 ` [PATCH v1 1/4] mfd: altr_a10sr: Add SPI device ID table Mark Brown
2021-09-23 19:46 ` [PATCH v1 2/4] mfd: arizona: Add missing entries SPI to " Mark Brown
2021-09-24 9:24 ` Richard Fitzgerald
2021-09-24 11:20 ` Mark Brown
2021-09-27 10:27 ` Charles Keepax [this message]
2021-09-27 10:55 ` Mark Brown
2021-09-28 8:05 ` Lee Jones
2021-09-28 10:01 ` Lee Jones
2021-09-23 19:46 ` [PATCH v1 3/4] mfd: cpcap: Add SPI " Mark Brown
2021-09-23 19:46 ` [PATCH v1 4/4] mfd: sprd: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927102754.GE9223@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.