All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srikanth Kaka <srikanth.k@oneconvergence.com>
To: Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>,
	Anand Thulasiram <avelu@juniper.net>,
	Srikanth Kaka <srikanth.k@oneconvergence.com>
Subject: [dpdk-dev] [PATCH 04/19] net/mlx5: disabling auxiliary bus support
Date: Mon, 27 Sep 2021 19:04:35 +0530	[thread overview]
Message-ID: <20210927133450.10653-5-srikanth.k@oneconvergence.com> (raw)
In-Reply-To: <20210927133450.10653-1-srikanth.k@oneconvergence.com>

Disabling auxiliary bus support in FreeBSD at this moment

Signed-off-by: Srikanth Kaka <srikanth.k@oneconvergence.com>
Signed-off-by: Vag Singh <vag.singh@oneconvergence.com>
Signed-off-by: Anand Thulasiram <avelu@juniper.net>
---
 drivers/net/mlx5/freebsd/mlx5_ethdev_os.c | 12 ------
 drivers/net/mlx5/freebsd/mlx5_os.c        | 52 +----------------------
 drivers/net/mlx5/freebsd/mlx5_os.h        |  2 -
 3 files changed, 2 insertions(+), 64 deletions(-)

diff --git a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c
index f34133e2c6..5cf3eab65a 100644
--- a/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c
+++ b/drivers/net/mlx5/freebsd/mlx5_ethdev_os.c
@@ -128,18 +128,6 @@ struct ethtool_link_settings {
 #define ETHTOOL_LINK_MODE_200000baseCR4_Full_BIT 2 /* 66 - 64 */
 #endif
 
-/* Get interface index from SubFunction device name. */
-int
-mlx5_auxiliary_get_ifindex(const char *sf_name)
-{
-	char if_name[IF_NAMESIZE] = { 0 };
-
-	if (mlx5_auxiliary_get_child_name(sf_name, "/net",
-					  if_name, sizeof(if_name)) != 0)
-		return -rte_errno;
-	return if_nametoindex(if_name);
-}
-
 /**
  * Get interface name from private structure.
  *
diff --git a/drivers/net/mlx5/freebsd/mlx5_os.c b/drivers/net/mlx5/freebsd/mlx5_os.c
index 3746057673..616bb73744 100644
--- a/drivers/net/mlx5/freebsd/mlx5_os.c
+++ b/drivers/net/mlx5/freebsd/mlx5_os.c
@@ -20,7 +20,6 @@
 #include <ethdev_pci.h>
 #include <rte_pci.h>
 #include <rte_bus_pci.h>
-#include <rte_bus_auxiliary.h>
 #include <rte_common.h>
 #include <rte_kvargs.h>
 #include <rte_rwlock.h>
@@ -2716,57 +2715,10 @@ mlx5_os_pci_probe(struct rte_pci_device *pci_dev)
 	}
 	return ret;
 }
-
-/* Probe a single SF device on auxiliary bus, no representor support. */
-static int
-mlx5_os_auxiliary_probe(struct rte_device *dev)
-{
-	struct rte_eth_devargs eth_da = { .nb_ports = 0 };
-	struct mlx5_dev_config config;
-	struct mlx5_dev_spawn_data spawn = { .pf_bond = -1 };
-	struct rte_auxiliary_device *adev = RTE_DEV_TO_AUXILIARY(dev);
-	struct rte_eth_dev *eth_dev;
-	int ret = 0;
-
-	/* Parse ethdev devargs. */
-	ret = mlx5_os_parse_eth_devargs(dev, &eth_da);
-	if (ret != 0)
-		return ret;
-	/* Set default config data. */
-	mlx5_os_config_default(&config);
-	config.sf = 1;
-	/* Init spawn data. */
-	spawn.max_port = 1;
-	spawn.phys_port = 1;
-	spawn.phys_dev = mlx5_os_get_ibv_dev(dev);
-	if (spawn.phys_dev == NULL)
-		return -rte_errno;
-	ret = mlx5_auxiliary_get_ifindex(dev->name);
-	if (ret < 0) {
-		DRV_LOG(ERR, "failed to get ethdev ifindex: %s", dev->name);
-		return ret;
-	}
-	spawn.ifindex = ret;
-	spawn.numa_node = dev->numa_node;
-	/* Spawn device. */
-	eth_dev = mlx5_dev_spawn(dev, &spawn, &config, &eth_da);
-	if (eth_dev == NULL)
-		return -rte_errno;
-	/* Post create. */
-	eth_dev->intr_handle = &adev->intr_handle;
-	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
-		eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_LSC;
-		eth_dev->data->dev_flags |= RTE_ETH_DEV_INTR_RMV;
-		eth_dev->data->numa_node = dev->numa_node;
-	}
-	rte_eth_dev_probing_finish(eth_dev);
-	return 0;
-}
-
 /**
  * Net class driver callback to probe a device.
  *
- * This function probe PCI bus device(s) or a single SF on auxiliary bus.
+ * This function probe PCI bus device(s)
  *
  * @param[in] dev
  *   Pointer to the generic device.
@@ -2790,7 +2742,7 @@ mlx5_os_net_probe(struct rte_device *dev)
 	if (mlx5_dev_is_pci(dev))
 		return mlx5_os_pci_probe(RTE_DEV_TO_PCI(dev));
 	else
-		return mlx5_os_auxiliary_probe(dev);
+		return -ENOTSUP;
 }
 
 static int
diff --git a/drivers/net/mlx5/freebsd/mlx5_os.h b/drivers/net/mlx5/freebsd/mlx5_os.h
index 2991d37df2..af7cbeb418 100644
--- a/drivers/net/mlx5/freebsd/mlx5_os.h
+++ b/drivers/net/mlx5/freebsd/mlx5_os.h
@@ -19,6 +19,4 @@ enum {
 
 #define MLX5_NAMESIZE IF_NAMESIZE
 
-int mlx5_auxiliary_get_ifindex(const char *sf_name);
-
 #endif /* RTE_PMD_MLX5_OS_H_ */
-- 
2.30.2


  parent reply	other threads:[~2021-09-27 14:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 13:34 [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 01/19] common/mlx5: stub for FreeBSD Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 02/19] net/mlx5: " Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 03/19] common/mlx5: disabling auxiliary bus support Srikanth Kaka
2021-09-27 13:34 ` Srikanth Kaka [this message]
2021-09-27 13:34 ` [dpdk-dev] [PATCH 05/19] net/mlx5: modified PCI probe to work on FreeBSD Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 06/19] common/mlx5: define PF_INET socket Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 07/19] net/mlx5: use the newly defined INET socket Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 08/19] common/mlx5: derive PCI addr in FreeBSD Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 09/19] common/mlx5: get interface name Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 10/19] net/mlx5: fix socket MAC request Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 11/19] net/mlx5: removing port representator support Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 12/19] net/mlx5: Added procedure to detect link state Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 13/19] net/mlx5: added placeholder for VLAN vmwa Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 14/19] net/mlx5: added stats support Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 15/19] net/mlx5: making flow control DPDK callback invalid Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 16/19] net/mlx5: making module DPDK callbacks invalid Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 17/19] common/mlx5: fixed missing dependency in mlx5_glue.h Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 18/19] net/mlx5: fixed compilation warnings Srikanth Kaka
2021-09-27 13:34 ` [dpdk-dev] [PATCH 19/19] mlx5: Added meson support for FreeBSD Srikanth Kaka
2021-09-29 12:20 ` [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support Thomas Monjalon
2021-09-29 15:56   ` Srikanth K
2021-09-29 16:20     ` Thomas Monjalon
2021-09-30 16:27       ` Srikanth K
2021-09-30 16:55         ` Thomas Monjalon
2021-10-01 11:35           ` Srikanth K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927133450.10653-5-srikanth.k@oneconvergence.com \
    --to=srikanth.k@oneconvergence.com \
    --cc=avelu@juniper.net \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=vag.singh@oneconvergence.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.