All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: u-boot@lists.denx.de, Joe Hershberger <joe.hershberger@ni.com>,
	Ramon Fried <rfried.dev@gmail.com>
Cc: Priyanka Jain <priyanka.jain@nxp.com>,
	Bin Meng <bmeng.cn@gmail.com>, Michael Walle <michael@walle.cc>
Subject: [PATCH v2 05/10] net: dsa: felix: configure the in-band autoneg property based on OF node info
Date: Wed, 29 Sep 2021 18:04:40 +0300	[thread overview]
Message-ID: <20210929150445.1593364-6-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20210929150445.1593364-1-vladimir.oltean@nxp.com>

Instead of trying to guess which operating modes need in-band
negotiation to be active and which ones don't, parse the available
information from the device tree. That will be correct in the cases we
can already guess, and more.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
---
v1->v2: none

 drivers/net/mscc_eswitch/felix_switch.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c
index 551fc2c9f969..2df8dde55fb9 100644
--- a/drivers/net/mscc_eswitch/felix_switch.c
+++ b/drivers/net/mscc_eswitch/felix_switch.c
@@ -16,6 +16,7 @@
  */
 
 #include <dm/device_compat.h>
+#include <dm/of_extra.h>
 #include <linux/delay.h>
 #include <net/dsa.h>
 #include <asm/io.h>
@@ -210,17 +211,14 @@ static int felix_init_sxgmii(struct mii_dev *imdio, int pidx)
 static void felix_start_pcs(struct udevice *dev, int port,
 			    struct phy_device *phy, struct mii_dev *imdio)
 {
-	bool autoneg = true;
-
-	if (phy->phy_id == PHY_FIXED_ID ||
-	    phy->interface == PHY_INTERFACE_MODE_2500BASEX)
-		autoneg = false;
+	ofnode node = dsa_port_get_ofnode(dev, port);
+	bool inband_an = ofnode_eth_uses_inband_aneg(node);
 
 	switch (phy->interface) {
 	case PHY_INTERFACE_MODE_SGMII:
 	case PHY_INTERFACE_MODE_2500BASEX:
 	case PHY_INTERFACE_MODE_QSGMII:
-		felix_init_sgmii(imdio, port, autoneg);
+		felix_init_sgmii(imdio, port, inband_an);
 		break;
 	case PHY_INTERFACE_MODE_10GBASER:
 	case PHY_INTERFACE_MODE_USXGMII:
-- 
2.25.1


  parent reply	other threads:[~2021-09-29 15:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 15:04 [PATCH v2 00/10] Support the SJA1105 DSA switch on the NXP LS1021A-TSN board Vladimir Oltean
2021-09-29 15:04 ` [PATCH v2 01/10] net: tsec: add support for promiscuous mode Vladimir Oltean
2021-10-16 18:30   ` Ramon Fried
2021-10-28 18:45     ` Ramon Fried
2021-10-30  7:45       ` Ramon Fried
2021-09-29 15:04 ` [PATCH v2 02/10] include: import if_vlan.h from Linux Vladimir Oltean
2021-09-29 15:04 ` [PATCH v2 03/10] net: dsa: allow drivers to get the port OF node Vladimir Oltean
2021-09-29 15:04 ` [PATCH v2 04/10] net: introduce a helper to determine whether to use in-band autoneg Vladimir Oltean
2021-09-29 23:20   ` Bin Meng
2021-10-16 18:28     ` Ramon Fried
2021-09-29 15:04 ` Vladimir Oltean [this message]
2021-09-29 15:04 ` [PATCH v2 06/10] net: dsa: add driver for NXP SJA1105 L2 switch Vladimir Oltean
2021-09-29 15:04 ` [PATCH v2 07/10] net: dsa: sja1105: add support for SGMII Vladimir Oltean
2021-09-29 15:04 ` [PATCH v2 08/10] arm: dts: ls1021a-tsn: add sja1105 and eth2 bindings Vladimir Oltean
2021-09-29 15:04 ` [PATCH v2 09/10] configs: ls1021a-tsn: enable sja1105 switch driver Vladimir Oltean
2021-09-29 15:04 ` [PATCH v2 10/10] configs: ls1021a-tsn: enable the generation of random Ethernet MAC addresses Vladimir Oltean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929150445.1593364-6-vladimir.oltean@nxp.com \
    --to=vladimir.oltean@nxp.com \
    --cc=bmeng.cn@gmail.com \
    --cc=joe.hershberger@ni.com \
    --cc=michael@walle.cc \
    --cc=priyanka.jain@nxp.com \
    --cc=rfried.dev@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.