All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: Leon Romanovsky <leon@kernel.org>,
	zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH for-next 0/6] RDMA/rxe: Fix potential races
Date: Tue, 19 Oct 2021 15:43:27 -0300	[thread overview]
Message-ID: <20211019184327.GX2744544@nvidia.com> (raw)
In-Reply-To: <ccdf6ffa-dc14-7b50-7a17-c0d01d9305bf@gmail.com>

On Tue, Oct 19, 2021 at 11:35:30AM -0500, Bob Pearson wrote:

> Take a look at the note I copied you on more recently. There is some
> progress but not complete elimination of rxe_pool. There is another
> project suggested by Jason which is replacing red black trees by
> xarrays as an alternative approach to indexing rdma objects.  This
> would still duplicate the indexing done by rdma-core. A while back I
> looked at trying to reuse the rdma-core indexing but no effort was
> made to make that easy.

I have no expecation that a driver can re-use the various rdma-core
indexes.. that is not what they are for, and they have a different
lifetime semantic from wha the driver needs.

> of the APIs are private to rdma-core. These indices are managed by
> the rxe driver for use as lkeys/rkeys, qpns, srqns, and more
> recently address handles. xarrays seem to be more efficient when the
> indices are fairly compact. There is a suggestion that IB and RoCE
> should attempt to make indices that are visible on the network more
> sparse. Nothing will make them secure but they could be a lot more
> secure than they are currently. I believe mlx5 is now using random
> keys for this reason.

Only qpn really benifits from something like this, and it is more
about maximum lifetime before qpn re-use which is a cyclic allocating
xarray.

Jason

  reply	other threads:[~2021-10-19 18:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 23:59 [PATCH for-next 0/6] RDMA/rxe: Fix potential races Bob Pearson
2021-10-10 23:59 ` [PATCH for-next 1/6] RDMA/rxe: Make rxe_alloc() take pool lock Bob Pearson
2021-10-20 23:16   ` Jason Gunthorpe
2021-10-21 17:46     ` Bob Pearson
2021-10-25 12:43       ` Jason Gunthorpe
2021-10-25 18:48         ` Robert Pearson
2021-10-10 23:59 ` [PATCH for-next 2/6] RDMA/rxe: Copy setup parameters into rxe_pool Bob Pearson
2021-10-10 23:59 ` [PATCH for-next 3/6] RDMA/rxe: Save object pointer in pool element Bob Pearson
2021-10-20 23:20   ` Jason Gunthorpe
2021-10-21 17:21     ` Bob Pearson
2021-10-25 15:40       ` Jason Gunthorpe
2021-10-10 23:59 ` [PATCH for-next 4/6] RDMA/rxe: Combine rxe_add_index with rxe_alloc Bob Pearson
2021-10-10 23:59 ` [PATCH for-next 5/6] RDMA/rxe: Combine rxe_add_key " Bob Pearson
2021-10-10 23:59 ` [PATCH for-next 6/6] RDMA/rxe: Fix potential race condition in rxe_pool Bob Pearson
2021-10-20 23:23   ` Jason Gunthorpe
2021-10-12  6:34 ` [PATCH for-next 0/6] RDMA/rxe: Fix potential races Leon Romanovsky
2021-10-12 20:19   ` Bob Pearson
2021-10-19 13:07     ` Leon Romanovsky
2021-10-19 16:35       ` Bob Pearson
2021-10-19 18:43         ` Jason Gunthorpe [this message]
2021-10-19 22:51           ` Bob Pearson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211019184327.GX2744544@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=rpearsonhpe@gmail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.