From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D00D4C43217 for ; Mon, 15 Nov 2021 21:42:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B3F8614C8 for ; Mon, 15 Nov 2021 21:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350864AbhKOVn4 (ORCPT ); Mon, 15 Nov 2021 16:43:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:36902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241279AbhKOSYu (ORCPT ); Mon, 15 Nov 2021 13:24:50 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8162F63422; Mon, 15 Nov 2021 17:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636998880; bh=gE8tjnZQrqhruD7oO9MniQbHmZN4wv5OjlIQ486WcGc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eVe9ndPIXceaF8DwRFnXfZJBIW96cdH7qJHMqdw0J8xMBrAugufLOJuztywhGr2pr 3X4FhS22VzjBBHgfe4jdQucWRxjHZ2ZzeRlhA5LAmTV7G8n/6uiNCZjDPIiS2zOEzn s4rLD2b6g/5txOJS8oplvqdMsqd6LUvxSy5jWgtk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tony Lu , Xuan Zhuo , Wen Gu , "David S. Miller" , Sasha Levin Subject: [PATCH 5.14 095/849] net/smc: Fix smc_link->llc_testlink_time overflow Date: Mon, 15 Nov 2021 17:52:58 +0100 Message-Id: <20211115165423.297563027@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165419.961798833@linuxfoundation.org> References: <20211115165419.961798833@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tony Lu [ Upstream commit c4a146c7cf5e8ad76231523b174d161bf152c6e7 ] The value of llc_testlink_time is set to the value stored in net->ipv4.sysctl_tcp_keepalive_time when linkgroup init. The value of sysctl_tcp_keepalive_time is already jiffies, so we don't need to multiply by HZ, which would cause smc_link->llc_testlink_time overflow, and test_link send flood. Signed-off-by: Tony Lu Reviewed-by: Xuan Zhuo Reviewed-by: Wen Gu Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/smc/smc_llc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c index 72f4b72eb1753..f1d323439a2af 100644 --- a/net/smc/smc_llc.c +++ b/net/smc/smc_llc.c @@ -1822,7 +1822,7 @@ void smc_llc_link_active(struct smc_link *link) link->smcibdev->ibdev->name, link->ibport); link->state = SMC_LNK_ACTIVE; if (link->lgr->llc_testlink_time) { - link->llc_testlink_time = link->lgr->llc_testlink_time * HZ; + link->llc_testlink_time = link->lgr->llc_testlink_time; schedule_delayed_work(&link->llc_testlink_wrk, link->llc_testlink_time); } -- 2.33.0