From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BA9C433EF for ; Tue, 30 Nov 2021 08:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239846AbhK3I45 (ORCPT ); Tue, 30 Nov 2021 03:56:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232024AbhK3I44 (ORCPT ); Tue, 30 Nov 2021 03:56:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71886C061574 for ; Tue, 30 Nov 2021 00:53:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3828EB817E9 for ; Tue, 30 Nov 2021 08:53:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AB8E2C53FCB; Tue, 30 Nov 2021 08:53:32 +0000 (UTC) Date: Tue, 30 Nov 2021 09:53:29 +0100 From: Christian Brauner To: Amir Goldstein Cc: Christian Brauner , Christoph Hellwig , Seth Forshee , Al Viro , linux-fsdevel Subject: Re: [PATCH 02/10] fs: move mapping helpers Message-ID: <20211130085329.ix677sd3v2l5yu6e@wittgenstein> References: <20211123114227.3124056-1-brauner@kernel.org> <20211123114227.3124056-3-brauner@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Nov 30, 2021 at 08:35:56AM +0200, Amir Goldstein wrote: > On Tue, Nov 23, 2021 at 3:29 PM Christian Brauner wrote: > > > > From: Christian Brauner > > > > The low-level mapping helpers were so far crammed into fs.h. They are > > out of place there. The fs.h header should just contain the higher-level > > mapping helpers that interact directly with vfs objects such as struct > > super_block or struct inode and not the bare mapping helpers. Similarly, > > only vfs and specific fs code shall interact with low-level mapping > > helpers. And so they won't be made accessible automatically through > > regular {g,u}id helpers. > > > > Cc: Seth Forshee > > Cc: Christoph Hellwig > > Cc: Al Viro > > CC: linux-fsdevel@vger.kernel.org > > Signed-off-by: Christian Brauner > > --- > > include/linux/fs.h | 91 +------------------------------- > > include/linux/mnt_mapping.h | 101 ++++++++++++++++++++++++++++++++++++ > > 2 files changed, 102 insertions(+), 90 deletions(-) > > create mode 100644 include/linux/mnt_mapping.h > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index 192242476b2b..eb69e8b035fa 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -41,6 +41,7 @@ > > #include > > #include > > #include > > +#include > > If I grepped correctly, there are ~20 files that use these helpers. > Please put the include in those files, so changes to this header > will not compile the world. Ok, happy to. > > And how about mnt_idmapping.h or idmapped_mnt.h? I think then I'll opt for mnt_idmapping.h. > Not sure if this naming issue was discussed already. Nope! Thanks! Christian