From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Daniel Smith <dpsmith@apertussolutions.com>
Subject: [PATCH 2/2] xsm: Drop extern of non-existent variable
Date: Wed, 1 Dec 2021 11:15:55 +0000 [thread overview]
Message-ID: <20211201111555.16408-3-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <20211201111555.16408-1-andrew.cooper3@citrix.com>
dummy_xsm_ops was dropped as part of organising XSM to be altcall compatible,
but the extern was accidentally left around.
A later change reintroduced dummy_ops which is logically the same thing, but
is private to xsm/dummy.c
Fixes: 164a0b9653f4 ("xsm: refactor xsm_ops handling")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Daniel De Graaf <dgdegra@tycho.nsa.gov>
CC: Daniel Smith <dpsmith@apertussolutions.com>
---
xen/include/xsm/xsm.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h
index 5aa4dd588d17..3e2b7fe3dbb3 100644
--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -789,8 +789,6 @@ int xsm_dt_policy_init(void **policy_buffer, size_t *policy_size);
bool has_xsm_magic(paddr_t);
#endif
-extern struct xsm_ops dummy_xsm_ops;
-
void xsm_fixup_ops(struct xsm_ops *ops);
#ifdef CONFIG_XSM_FLASK
--
2.11.0
next prev parent reply other threads:[~2021-12-01 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 11:15 [PATCH 0/2] xsm: Further fixes Andrew Cooper
2021-12-01 11:15 ` [PATCH 1/2] xsm: Switch xsm_ops to __alt_call_maybe_initdata Andrew Cooper
2021-12-01 11:15 ` Andrew Cooper [this message]
2021-12-01 11:23 ` [PATCH 0/2] xsm: Further fixes Jan Beulich
2021-12-02 10:39 ` Bertrand Marquis
2021-12-03 10:47 ` Daniel P. Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211201111555.16408-3-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=dpsmith@apertussolutions.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.