From: Cosmin Tanislav <demonsingur@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: cosmin.tanislav@analog.com, demonsingur@gmail.com,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 4/7] hwmon: (adt7x10) Use devm_request_threaded_irq
Date: Tue, 21 Dec 2021 23:58:38 +0200 [thread overview]
Message-ID: <20211221215841.2641417-5-demonsingur@gmail.com> (raw)
In-Reply-To: <20211221215841.2641417-1-demonsingur@gmail.com>
From: Cosmin Tanislav <cosmin.tanislav@analog.com>
To simplify the core driver remove function.
Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
---
drivers/hwmon/adt7x10.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/adt7x10.c b/drivers/hwmon/adt7x10.c
index 2e6e54bf1d15..84e8879d4ca7 100644
--- a/drivers/hwmon/adt7x10.c
+++ b/drivers/hwmon/adt7x10.c
@@ -450,9 +450,11 @@ int adt7x10_probe(struct device *dev, const char *name, int irq,
}
if (irq > 0) {
- ret = request_threaded_irq(irq, NULL, adt7x10_irq_handler,
- IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
- dev_name(dev), dev);
+ ret = devm_request_threaded_irq(dev, irq, NULL,
+ adt7x10_irq_handler,
+ IRQF_TRIGGER_FALLING |
+ IRQF_ONESHOT,
+ dev_name(dev), dev);
if (ret)
return ret;
}
@@ -463,8 +465,6 @@ EXPORT_SYMBOL_GPL(adt7x10_probe);
void adt7x10_remove(struct device *dev, int irq)
{
- if (irq > 0)
- free_irq(irq, dev);
}
EXPORT_SYMBOL_GPL(adt7x10_remove);
--
2.34.1
next prev parent reply other threads:[~2021-12-21 21:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 21:58 [PATCH v3 0/7] Refactor ADT7X10 Cosmin Tanislav
2021-12-21 21:58 ` [PATCH v3 1/7] hwmon: (adt7x10) Store bus_dev in private data Cosmin Tanislav
2021-12-21 21:58 ` [PATCH v3 2/7] hwmon: (adt7x10) Add device managed action for restoring config Cosmin Tanislav
2021-12-21 21:58 ` [PATCH v3 3/7] hwmon: (adt7x10) Use devm_hwmon_device_register_with_info Cosmin Tanislav
2021-12-22 3:08 ` Guenter Roeck
2021-12-22 6:35 ` Cosmin Tanislav
2021-12-22 17:07 ` Guenter Roeck
2021-12-21 21:58 ` Cosmin Tanislav [this message]
2021-12-21 21:58 ` [PATCH v3 5/7] hwmon: (adt7x10) Remove empty driver removal callback Cosmin Tanislav
2021-12-21 21:58 ` [PATCH v3 6/7] hwmon: (adt7x10) Pass hwinfo dev to irq handler Cosmin Tanislav
2021-12-21 21:58 ` [PATCH v3 7/7] hwmon: (adt7x10) Use hwmon_notify_event Cosmin Tanislav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221215841.2641417-5-demonsingur@gmail.com \
--to=demonsingur@gmail.com \
--cc=cosmin.tanislav@analog.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.