From: Pavel Machek <pavel@denx.de>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH 5.10.y-cip 20/22] dmaengine: sh: make array ds_lut static
Date: Wed, 22 Dec 2021 11:04:53 +0100 [thread overview]
Message-ID: <20211222100453.GD15186@amd> (raw)
In-Reply-To: <20211220133139.21624-21-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]
Hi!
> commit 4c0eee50658746b0333d35a75d3db6e0aac08ef9 upstream.
>
> Don't populate the read-only array ds_lut on the stack but instead it
> static. Also makes the object code smaller by 163 bytes:
>
> Before:
> text data bss dec hex filename
> 23508 4796 0 28304 6e90 ./drivers/dma/sh/rz-dmac.o
>
> After:
> text data bss dec hex filename
> 23281 4860 0 28141 6ded ./drivers/dma/sh/rz-dmac.o
Heh.
> @@ -574,7 +574,7 @@ static void rz_dmac_issue_pending(struct dma_chan *chan)
> static u8 rz_dmac_ds_to_val_mapping(enum dma_slave_buswidth ds)
> {
> u8 i;
> - const enum dma_slave_buswidth ds_lut[] = {
> + static const enum dma_slave_buswidth ds_lut[] = {
> DMA_SLAVE_BUSWIDTH_1_BYTE,
> DMA_SLAVE_BUSWIDTH_2_BYTES,
> DMA_SLAVE_BUSWIDTH_4_BYTES,
Array could be avoided altogether; you could check for power of two
and then count bits. That would give even shorter code, but I'm not
sure about readability.
I'd also not mind using usual convention here: return int, >= 0
success, < 0 errno.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-12-22 10:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 13:31 [PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 01/22] mm: slab: provide krealloc_array() Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 02/22] clk: renesas: r9a07g044: Add GPIO clock and reset entries Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 03/22] dt-bindings: pinctrl: renesas: Add DT bindings for RZ/G2L pinctrl Lad Prabhakar
2021-12-22 9:45 ` Pavel Machek
2021-12-22 11:05 ` Prabhakar Mahadev Lad
2021-12-20 13:31 ` [PATCH 5.10.y-cip 04/22] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver Lad Prabhakar
2021-12-22 9:48 ` Pavel Machek
2021-12-22 10:54 ` Prabhakar Mahadev Lad
2021-12-20 13:31 ` [PATCH 5.10.y-cip 05/22] pinctrl: renesas: rzg2l: Fix missing port register 21h Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 06/22] arm64: dts: renesas: rzg2l-smarc: Add scif0 pins Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 07/22] arm64: dts: renesas: r9a07g044: Add pinctrl node Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 08/22] clk: renesas: r9a07g044: Add I2C clocks/resets Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 09/22] dt-bindings: i2c: renesas,riic: Convert to json-schema Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 10/22] dt-bindings: i2c: renesas,riic: Document RZ/G2L I2C controller Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 11/22] arm64: dts: renesas: r9a07g044: Add I2C nodes Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 12/22] arm64: dts: renesas: r9a07g044: Add I2C interrupt-names Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 13/22] clk: renesas: r9a07g044: Add DMAC clocks/resets Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 14/22] dt-bindings: dma: Document RZ/G2L bindings Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 15/22] dmaengine: Extend the dma_slave_width for 128 bytes Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 16/22] dmaengine: sh: Add DMAC driver for RZ/G2L SoC Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 17/22] dmaengine: sh: Fix unused initialization of pointer lmdesc Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 18/22] dmaengine: sh: fix some NULL dereferences Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 19/22] dmaengine: sh: rz-dmac: Add DMA clock handling Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 20/22] dmaengine: sh: make array ds_lut static Lad Prabhakar
2021-12-22 10:04 ` Pavel Machek [this message]
2021-12-22 10:26 ` Prabhakar Mahadev Lad
2022-01-04 10:39 ` Biju Das
2021-12-20 13:31 ` [PATCH 5.10.y-cip 21/22] arm64: dts: renesas: r9a07g044: Add DMAC support Lad Prabhakar
2021-12-20 13:31 ` [PATCH 5.10.y-cip 22/22] arm64: defconfig: Enable RZ_DMAC Lad Prabhakar
2021-12-21 9:42 ` [PATCH 5.10.y-cip 00/22] RZ/G2L: Add support for pinctrl/dmac/iic Pavel Machek
2021-12-22 10:06 ` Pavel Machek
2021-12-22 10:19 ` Prabhakar Mahadev Lad
2021-12-22 10:23 ` [cip-dev] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222100453.GD15186@amd \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.