All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: lgirdwood@gmail.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com,
	pierre-louis.bossart@linux.intel.com,
	ranjani.sridharan@linux.intel.com, chao.song@intel.com,
	daniel.baluta@nxp.com
Subject: [PATCH 13/20] ASoC: SOF: pm: Force DSP off on suspend in BOOT_FAILED state also
Date: Thu, 23 Dec 2021 13:36:21 +0200	[thread overview]
Message-ID: <20211223113628.18582-14-peter.ujfalusi@linux.intel.com> (raw)
In-Reply-To: <20211223113628.18582-1-peter.ujfalusi@linux.intel.com>

Try to force the DSP to be turned off next time if the fw_state is either
CRASHED or BOOT_FAILED when a suspend happens in order to attempt a clean
boot to recover.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
 sound/soc/sof/pm.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/sound/soc/sof/pm.c b/sound/soc/sof/pm.c
index 022b19669735..197a88695fef 100644
--- a/sound/soc/sof/pm.c
+++ b/sound/soc/sof/pm.c
@@ -315,10 +315,11 @@ int snd_sof_prepare(struct device *dev)
 	sdev->system_suspend_target = SOF_SUSPEND_S3;
 
 	/*
-	 * if the firmware is crashed then we try to aim for S3 to reboot the
-	 * firmware
+	 * if the firmware is crashed or boot failed then we try to aim for S3
+	 * to reboot the firmware
 	 */
-	if (sdev->fw_state == SOF_FW_CRASHED)
+	if (sdev->fw_state == SOF_FW_CRASHED ||
+	    sdev->fw_state == SOF_FW_BOOT_FAILED)
 		return 0;
 
 	if (!desc->use_acpi_target_states)
-- 
2.34.1


  parent reply	other threads:[~2021-12-23 11:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23 11:36 [PATCH 00/20] ASoC: SOF: Re-visit firmware state and panic tracking/handling Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 01/20] ASoC: SOF: ops: Use dev_warn() if the panic offsets differ Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 02/20] ASoC: SOF: Intel: hda-loader: Avoid re-defining the HDA_FW_BOOT_ATTEMPTS Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 03/20] ASoC: SOF: core: Add simple wrapper to check flags in sof_core_debug Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 04/20] ASoC: SOF: Use sof_debug_check_flag() instead of sof_core_debug directly Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 05/20] ASoC: SOF: Add 'non_recoverable' parameter to snd_sof_dsp_panic() Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 06/20] ASoC: SOF: Add a 'message' parameter to snd_sof_dsp_dbg_dump() Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 07/20] ASoC: SOF: Introduce new firmware state: SOF_FW_CRASHED Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 08/20] ASoC: SOF: Introduce new firmware state: SOF_FW_BOOT_READY_OK Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 09/20] ASoC: SOF: Move the definition of enum snd_sof_fw_state to global header Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 10/20] ASoC: SOF: Rename 'enum snd_sof_fw_state' to 'enum sof_fw_state' Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 11/20] ASoC: SOF: ipc: Only allow sending of an IPC in SOF_FW_BOOT_COMPLETE state Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 12/20] ASoC: SOF: Set SOF_FW_BOOT_FAILED in case we have failure during boot Peter Ujfalusi
2021-12-23 11:36 ` Peter Ujfalusi [this message]
2021-12-23 11:36 ` [PATCH 14/20] ASoc: SOF: core: Update the FW boot state transition diagram Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 15/20] ASoC: SOF: ops: Always print DSP Panic message but use different message Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 16/20] ASoC: SOF: dsp_arch_ops: add kernel log level parameter for oops and stack Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 17/20] ASoC: SOF: Rename snd_sof_get_status() and add kernel log level parameter Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 18/20] ASoC: SOF: Add clarifying comments for sof_core_debug and DSP dump flags Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 19/20] ASoC: SOF: debug: Use DEBUG log level for optional prints Peter Ujfalusi
2021-12-23 11:36 ` [PATCH 20/20] ASoC: SOF: Intel: hda: " Peter Ujfalusi
2021-12-23 17:17 ` [PATCH 00/20] ASoC: SOF: Re-visit firmware state and panic tracking/handling Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211223113628.18582-14-peter.ujfalusi@linux.intel.com \
    --to=peter.ujfalusi@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=chao.song@intel.com \
    --cc=daniel.baluta@nxp.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.