Re: [PATCH 1/4] um: Run console exit code also upon kernel panic

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/4] um: Run console exit code also upon kernel panic
Date: Tue, 04 Jan 2022 13:58:44 +0800	[thread overview]
Message-ID: <202201041330.hsCRX4ov-lkp@intel.com> (raw)
In-Reply-To: <20220101215810.13260-2-richard@nod.at>

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

Hi Richard,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rw-uml/linux-next]
[also build test WARNING on linux/master linus/master v5.16-rc8 next-20211224]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Richard-Weinberger/um-Assorted-console-related-fixes/20220102-055954
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml.git linux-next
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220104/202201041330.hsCRX4ov-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/8ed1e739d9071fbe06c0e6ff91eeb065afd18953
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Richard-Weinberger/um-Assorted-console-related-fixes/20220102-055954
        git checkout 8ed1e739d9071fbe06c0e6ff91eeb065afd18953
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/um/drivers/stdio_console.c:183:6: warning: no previous prototype for 'uml_console_exit' [-Wmissing-prototypes]
     183 | void uml_console_exit(void)
         |      ^~~~~~~~~~~~~~~~

vim +/uml_console_exit +183 arch/um/drivers/stdio_console.c

   182	
 > 183	void uml_console_exit(void)
   184	{
   185		if (!con_init_done)
   186			return;
   187		close_lines(vts, ARRAY_SIZE(vts));
   188	}
   189	__uml_exitcall(uml_console_exit);
   190	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org