From: Steven Rostedt <rostedt@goodmis.org>
To: Sven Schnelle <svens@linux.ibm.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pingfan Liu <kernelfans@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Tom Zanussi <zanussi@kernel.org>,
hca@linux.ibm.com, deller@gmx.de
Subject: Re: [PATCH v2] tracing: Add test for user space strings when filtering on string pointers
Date: Thu, 13 Jan 2022 16:51:15 -0500 [thread overview]
Message-ID: <20220113165115.0c844df9@gandalf.local.home> (raw)
In-Reply-To: <yt9dwnj3wcke.fsf@linux.ibm.com>
On Thu, 13 Jan 2022 22:28:01 +0100
Sven Schnelle <svens@linux.ibm.com> wrote:
>
> Hmm, i don't see how. On s390, TASK_SIZE is -PAGE_SIZE, which means
> 0xfffffffffffff000 so i think the if() condition below is always true.
Yes, I did that to just use the kernel version and not the user space one.
This is just a workaround for now.
>
> Too bad that the __user attribute is stripped during a normal compile.
> But couldn't we add the information whether a pointer belongs to user
> or kernel space in the trace event definition? For syscall tracing it's
> easy, because pointer types in SYSCALL_DEFINE() and friends are always
> userspace pointers?
We could add something later. As it is currently the merge window, and this
is a real bug, I'm going to just leave it as is, and we can work to fix the
other archs later. I need to get a pull request ready by tomorrow.
-- Steve
next prev parent reply other threads:[~2022-01-13 21:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 16:55 [PATCH v2] tracing: Add test for user space strings when filtering on string pointers Steven Rostedt
2022-01-10 17:11 ` David Laight
2022-01-10 17:24 ` Steven Rostedt
2022-01-10 17:29 ` Steven Rostedt
2022-01-10 21:58 ` David Laight
2022-01-11 20:55 ` Sven Schnelle
2022-01-13 17:57 ` Steven Rostedt
2022-01-13 21:28 ` Sven Schnelle
2022-01-13 21:51 ` Steven Rostedt [this message]
2022-01-14 2:15 ` Steven Rostedt
2022-01-14 7:29 ` Sven Schnelle
2022-01-14 9:35 ` David Laight
2022-01-13 22:11 ` David Laight
2022-01-13 22:28 ` Steven Rostedt
2022-01-10 22:03 ` David Laight
2022-01-11 0:21 ` Steven Rostedt
2022-01-12 4:13 ` Pingfan Liu
2022-01-13 18:04 ` Steven Rostedt
2022-01-13 22:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113165115.0c844df9@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=David.Laight@ACULAB.COM \
--cc=akpm@linux-foundation.org \
--cc=deller@gmx.de \
--cc=hca@linux.ibm.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=svens@linux.ibm.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.