All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabiano Rosas <farosas@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: danielhb413@gmail.com, qemu-ppc@nongnu.org, clg@kaod.org,
	david@gibson.dropbear.id.au
Subject: [PATCH 04/11] target/ppc: booke: Machine Check cleanups
Date: Fri, 28 Jan 2022 19:40:11 -0300	[thread overview]
Message-ID: <20220128224018.1228062-5-farosas@linux.ibm.com> (raw)
In-Reply-To: <20220128224018.1228062-1-farosas@linux.ibm.com>

There's no MSR_HV in BookE.

Also remove 40x code.

Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
---
 target/ppc/excp_helper.c | 29 ++++++-----------------------
 1 file changed, 6 insertions(+), 23 deletions(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 8a656ace6f..4753b81527 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -819,34 +819,17 @@ static void powerpc_excp_booke(PowerPCCPU *cpu, int excp)
             cs->halted = 1;
             cpu_interrupt_exittb(cs);
         }
-        if (env->msr_mask & MSR_HVB) {
-            /*
-             * ISA specifies HV, but can be delivered to guest with HV
-             * clear (e.g., see FWNMI in PAPR).
-             */
-            new_msr |= (target_ulong)MSR_HVB;
-        }
 
         /* machine check exceptions don't have ME set */
         new_msr &= ~((target_ulong)1 << MSR_ME);
 
-        /* XXX: should also have something loaded in DAR / DSISR */
-        switch (excp_model) {
-        case POWERPC_EXCP_40x:
-            srr0 = SPR_40x_SRR2;
-            srr1 = SPR_40x_SRR3;
-            break;
-        case POWERPC_EXCP_BOOKE:
-            /* FIXME: choose one or the other based on CPU type */
-            srr0 = SPR_BOOKE_MCSRR0;
-            srr1 = SPR_BOOKE_MCSRR1;
+        /* FIXME: choose one or the other based on CPU type */
+        srr0 = SPR_BOOKE_MCSRR0;
+        srr1 = SPR_BOOKE_MCSRR1;
+
+        env->spr[SPR_BOOKE_CSRR0] = env->nip;
+        env->spr[SPR_BOOKE_CSRR1] = msr;
 
-            env->spr[SPR_BOOKE_CSRR0] = env->nip;
-            env->spr[SPR_BOOKE_CSRR1] = msr;
-            break;
-        default:
-            break;
-        }
         break;
     case POWERPC_EXCP_DSI:       /* Data storage exception                   */
         trace_ppc_excp_dsi(env->spr[SPR_DSISR], env->spr[SPR_DAR]);
-- 
2.34.1



  parent reply	other threads:[~2022-01-28 22:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-28 22:40 [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n) Fabiano Rosas
2022-01-28 22:40 ` [PATCH 01/11] target/ppc: Introduce powerpc_excp_booke Fabiano Rosas
2022-01-28 22:40 ` [PATCH 02/11] target/ppc: Simplify powerpc_excp_booke Fabiano Rosas
2022-01-28 22:40 ` [PATCH 03/11] target/ppc: booke: Critical exception cleanup Fabiano Rosas
2022-01-28 22:40 ` Fabiano Rosas [this message]
2022-01-28 22:40 ` [PATCH 05/11] target/ppc: booke: Data Storage " Fabiano Rosas
2022-01-28 22:40 ` [PATCH 06/11] target/ppc: booke: Instruction storage " Fabiano Rosas
2022-01-28 22:40 ` [PATCH 07/11] target/ppc: booke: External interrupt cleanup Fabiano Rosas
2022-01-28 22:40 ` [PATCH 08/11] target/ppc: booke: Alignment " Fabiano Rosas
2022-01-28 22:40 ` [PATCH 09/11] target/ppc: booke: System Call exception cleanup Fabiano Rosas
2022-01-28 22:40 ` [PATCH 10/11] target/ppc: booke: Watchdog Timer interrupt Fabiano Rosas
2022-01-28 22:40 ` [PATCH 11/11] target/ppc: booke: System Reset exception cleanup Fabiano Rosas
2022-01-29  0:07 ` [PATCH 00/11] target/ppc: powerpc_excp improvements [BookE] (6/n) BALATON Zoltan
2022-02-01  8:10   ` Cédric Le Goater
2022-02-01 11:32     ` BALATON Zoltan
2022-02-01 12:54       ` Fabiano Rosas
2022-02-09  7:43 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220128224018.1228062-5-farosas@linux.ibm.com \
    --to=farosas@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.