From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out.xnet.cz (smtp-out.xnet.cz [178.217.244.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D7931B75 for ; Tue, 15 Mar 2022 08:02:11 +0000 (UTC) Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id AF527183A2; Tue, 15 Mar 2022 09:02:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=true.cz; s=xnet; t=1647331329; bh=Owgjpt9llFly8+dfQ/MyEmdugi3jXELC/2QOvA1Yplw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To; b=RksBD10DTBfymcyc0tskKWTanzG6CEDK8a+QhF0EhUkiSh1bldkhga8ViEOgnnthc Nzs9BB4sVW25Df5/L+nrQkSAZmyvD4oum9Ej+IRCYrePc/YELButYksL9ODTppiKaK 8XvCrce2WNdoX7QtlftDvNI5rvlq2FWV8G7QIlYg= Received: by meh.true.cz (OpenSMTPD) with SMTP id 36d5bdad; Tue, 15 Mar 2022 09:01:44 +0100 (CET) Date: Tue, 15 Mar 2022 09:02:06 +0100 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Corentin Labbe Cc: Greg Kroah-Hartman , Maxime Ripard , Bastien =?utf-8?Q?Roucari=C3=A8s?= , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , stable@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Message-ID: <20220315080206.GA12404@meh.true.cz> Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= References: <20220308125531.27305-1-ynezz@true.cz> <20220315072846.GA9129@meh.true.cz> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-PGP-Key: https://gist.githubusercontent.com/ynezz/477f6d7a1623a591b0806699f9fc8a27/raw/a0878b8ed17e56f36ebf9e06a6b888a2cd66281b/pgp-key.pub Corentin Labbe [2022-03-15 08:37:06]: Hi, > If your patch is applied, older revisions will stop working, right ? correct, in the same way new revisions stopped working when that wrong fix was applied. > What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ? >From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY. Cheers, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FD2DC433EF for ; Tue, 15 Mar 2022 08:03:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x0YuLT0zHDy76+qajWr9IX6121+e2vQafFCfoMQrd0s=; b=UseO3j3RV4I2V0 znwy7/rBS0+PAqMaNtjyC6R0PJcp1Cmsqt9IYVQpFwsq68IYInHW4E91DARoindvYf7RTrXFi4WVn roFrx8ycQ7LWK9/sY6RbjpjAHJ6UWuLkllHIDeUnDdSHm2LOmz4qoH7kuWeHoxPee1NgZKJ09Xw4X kFSoXNccfAMFI5PjcSu1tG4zdFfFHQItO7GKeBMNPEwWR8zVuDKlGuptburvcB1R9ilsVIXBrr9tG RpF1RaxWaEpGA86ve2y790g7QRjSquFrJfuHlinGhDZTG8ZrOcArri04nXO1d/ctqtWzLUTv7cxZT CnuIEEBkrlse/8CqQ7ig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU28G-008D4e-Ku; Tue, 15 Mar 2022 08:02:16 +0000 Received: from smtp-out.xnet.cz ([178.217.244.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nU28C-008D3M-PZ for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 08:02:14 +0000 Received: from meh.true.cz (meh.true.cz [108.61.167.218]) (Authenticated sender: petr@true.cz) by smtp-out.xnet.cz (Postfix) with ESMTPSA id AF527183A2; Tue, 15 Mar 2022 09:02:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=true.cz; s=xnet; t=1647331329; bh=Owgjpt9llFly8+dfQ/MyEmdugi3jXELC/2QOvA1Yplw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To; b=RksBD10DTBfymcyc0tskKWTanzG6CEDK8a+QhF0EhUkiSh1bldkhga8ViEOgnnthc Nzs9BB4sVW25Df5/L+nrQkSAZmyvD4oum9Ej+IRCYrePc/YELButYksL9ODTppiKaK 8XvCrce2WNdoX7QtlftDvNI5rvlq2FWV8G7QIlYg= Received: by meh.true.cz (OpenSMTPD) with SMTP id 36d5bdad; Tue, 15 Mar 2022 09:01:44 +0100 (CET) Date: Tue, 15 Mar 2022 09:02:06 +0100 From: Petr =?utf-8?Q?=C5=A0tetiar?= To: Corentin Labbe Cc: Greg Kroah-Hartman , Maxime Ripard , Bastien =?utf-8?Q?Roucari=C3=A8s?= , Chen-Yu Tsai , Jernej Skrabec , Rob Herring , stable@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Message-ID: <20220315080206.GA12404@meh.true.cz> References: <20220308125531.27305-1-ynezz@true.cz> <20220315072846.GA9129@meh.true.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-PGP-Key: https://gist.githubusercontent.com/ynezz/477f6d7a1623a591b0806699f9fc8a27/raw/a0878b8ed17e56f36ebf9e06a6b888a2cd66281b/pgp-key.pub X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_010212_990930_7DCE0FB6 X-CRM114-Status: UNSURE ( 7.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr =?utf-8?Q?=C5=A0tetiar?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Corentin Labbe [2022-03-15 08:37:06]: Hi, > If your patch is applied, older revisions will stop working, right ? correct, in the same way new revisions stopped working when that wrong fix was applied. > What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ? >From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY. Cheers, Petr _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel