From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641B6C433EF for ; Thu, 24 Mar 2022 06:16:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348095AbiCXGS2 (ORCPT ); Thu, 24 Mar 2022 02:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347185AbiCXGSZ (ORCPT ); Thu, 24 Mar 2022 02:18:25 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02D839681B; Wed, 23 Mar 2022 23:16:54 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id D871768BEB; Thu, 24 Mar 2022 07:16:50 +0100 (CET) Date: Thu, 24 Mar 2022 07:16:50 +0100 From: Christoph Hellwig To: Sven Peter Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Hector Martin , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Jens Axboe Subject: Re: [PATCH 7/9] nvme-apple: Serialize command issue Message-ID: <20220324061650.GB12330@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-8-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220321165049.35985-8-sven@svenpeter.dev> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 21, 2022 at 05:50:47PM +0100, Sven Peter wrote: > From: Jens Axboe > > This controller shouldn't need serialization of command issue since > the SQ is replaced by a simple array and commands are issued by writing > the array index to a MMIO register. > Without serialization however sometimes commands are still executed > correctly and appear in the CQ but never trigger an interrupt. > > Signed-off-by: Jens Axboe > [sven: added our best guess why this needs to be done] > Signed-off-by: Sven Peter This really should go into the previous patch. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D17E8C433EF for ; Thu, 24 Mar 2022 06:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fKilZrBMvcuuP8tmevpaZQvs+F2EqzmsCfiBzXZ2XMI=; b=IW+1bqgbN8gdTz r+PrGJgaZyJhn/PZdPjjU+gnfA5m4hC7AytHxc5jFJdViAYjS1gYgCSJkklu4qbhsm/qi23byjGso oicqAfZvBJCsjXJ037d6sbbuNsRkKPTfN1h9FSCdLXjD9bsdJKW/fLgRfH0mJLB3QsMD+MHXVp+vv psJyFI+6zsl9RBMh6PN3980ERVdqaSEsTiQIVBm29gG8XizkNI08QZynLrsrM3yFVoZFHgP6dLE45 WMc4J6PK4/Gca54LNUS1LKnZUwCn7dNLh+KoPfli/M8mjYAXAzVP0m2EmadBC0aj96PC24FiFI5GZ 71q+nYMlowz2PZY8Rrkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXGmH-00Fn4y-O6; Thu, 24 Mar 2022 06:16:57 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXGmD-00Fn34-Jm; Thu, 24 Mar 2022 06:16:54 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id D871768BEB; Thu, 24 Mar 2022 07:16:50 +0100 (CET) Date: Thu, 24 Mar 2022 07:16:50 +0100 From: Christoph Hellwig To: Sven Peter Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Hector Martin , Alyssa Rosenzweig , Rob Herring , Arnd Bergmann , Marc Zyngier , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Jens Axboe Subject: Re: [PATCH 7/9] nvme-apple: Serialize command issue Message-ID: <20220324061650.GB12330@lst.de> References: <20220321165049.35985-1-sven@svenpeter.dev> <20220321165049.35985-8-sven@svenpeter.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220321165049.35985-8-sven@svenpeter.dev> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220323_231653_825123_993104A8 X-CRM114-Status: GOOD ( 14.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 21, 2022 at 05:50:47PM +0100, Sven Peter wrote: > From: Jens Axboe > > This controller shouldn't need serialization of command issue since > the SQ is replaced by a simple array and commands are issued by writing > the array index to a MMIO register. > Without serialization however sometimes commands are still executed > correctly and appear in the CQ but never trigger an interrupt. > > Signed-off-by: Jens Axboe > [sven: added our best guess why this needs to be done] > Signed-off-by: Sven Peter This really should go into the previous patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel