From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: [PATCH for-7.1 v2 00/39] Logging cleanup and per-thread logfiles
Date: Sat, 26 Mar 2022 07:24:47 -0600 [thread overview]
Message-ID: <20220326132534.543738-1-richard.henderson@linaro.org> (raw)
Most of the changes here reduce the amount of locking involved
in logging, due to repeated qemu_log calls, each of which takes
and releases the rcu_read_lock.
This makes more use of qemu_log_lock/unlock around code blocks,
which both keeps the output together in the face of threads and
also plays the rcu_read_lock game only once for the block.
Finally, add a -d tid option to open per-thread logfiles.
This can be extremely helpful in debugging user-only threads.
Changes for v2:
* Rename qemu_log_lock to qemu_log_trylock to emphasize that
the call is not guaranteed to succeed.
* Work around a musl compilation error, caused by our own
typeof_strip_qual macro not working with incomplete structs.
* Use CONFIG_GETTID properly.
r~
Richard Henderson (39):
util/log: Drop manual log buffering
target/hexagon: Remove qemu_set_log in hexagon_translate_init
util/log: Return bool from qemu_set_log_filename
util/log: Pass Error pointer to qemu_set_log
os-posix: Use qemu_log_enabled
util/log: Move qemu_log_lock, qemu_log_unlock out of line
util/log: Rename qemu_log_lock to qemu_log_trylock
hw/xen: Split out xen_pv_output_msg
*: Use fprintf between qemu_log_trylock/unlock
util/log: Remove qemu_log_vprintf
tcg: Pass the locked filepointer to tcg_dump_ops
exec/translator: Pass the locked filepointer to disas_log hook
exec/log: Remove log_disas and log_target_disas
accel/tcg: Use cpu_dump_state between qemu_log_trylock/unlock
target/nios2: Remove log_cpu_state from reset
util/log: Use qemu_log_trylock/unlock in qemu_log
util/log: Drop return value from qemu_log
util/log: Mark qemu_log_trylock as G_GNUC_WARN_UNUSED_RESULT
util/log: Remove qemu_log_flush
util/log: Drop call to setvbuf
bsd-user: Expand log_page_dump inline
linux-user: Expand log_page_dump inline
tests/unit: Do not reference QemuLogFile directly
include/exec/log: Do not reference QemuLogFile directly
include/qemu/log: Move entire implementation out-of-line
sysemu/os-win32: Test for and use _lock_file/_unlock_file
util/log: Introduce qemu_set_log_filename_flags
bsd-user: Use qemu_set_log_filename_flags
linux-user: Use qemu_set_log_filename_flags
softmmu: Use qemu_set_log_filename_flags
util/log: Remove qemu_log_close
util/log: Rename logfilename to global_filename
util/log: Rename qemu_logfile to global_file
util/log: Rename qemu_logfile_mutex to global_mutex
util/log: Hoist the eval of is_daemonized in qemu_set_log_internal
util/log: Combine two logfile closes
util/log: Rename QemuLogFile to RCUCloseFILE
util/log: Limit RCUCloseFILE to file closing
util/log: Support per-thread log files
meson.build | 12 +
include/exec/log.h | 52 +---
include/exec/translator.h | 2 +-
include/qemu/log-for-trace.h | 2 +-
include/qemu/log.h | 93 +------
include/sysemu/os-win32.h | 16 +-
accel/tcg/cpu-exec.c | 18 +-
accel/tcg/translate-all.c | 118 +++++----
accel/tcg/translator.c | 12 +-
bsd-user/main.c | 54 ++--
cpu.c | 16 +-
hw/net/can/can_sja1000.c | 25 +-
hw/xen/xen_pvdev.c | 45 ++--
linux-user/main.c | 55 ++--
linux-user/mmap.c | 7 +-
monitor/misc.c | 9 +-
net/can/can_socketcan.c | 24 +-
os-posix.c | 2 +-
qemu-img.c | 2 +-
qemu-io.c | 2 +-
qemu-nbd.c | 2 +-
scsi/qemu-pr-helper.c | 2 +-
softmmu/vl.c | 21 +-
storage-daemon/qemu-storage-daemon.c | 2 +-
target/alpha/translate.c | 7 +-
target/arm/translate-a64.c | 6 +-
target/arm/translate.c | 7 +-
target/avr/translate.c | 7 +-
target/cris/translate.c | 7 +-
target/hexagon/translate.c | 13 +-
target/hppa/translate.c | 15 +-
target/i386/tcg/translate.c | 22 +-
target/m68k/translate.c | 7 +-
target/microblaze/translate.c | 7 +-
target/mips/tcg/translate.c | 7 +-
target/nios2/cpu.c | 5 -
target/nios2/translate.c | 7 +-
target/openrisc/translate.c | 7 +-
target/ppc/translate.c | 7 +-
target/riscv/translate.c | 10 +-
target/rx/translate.c | 7 +-
target/s390x/tcg/translate.c | 11 +-
target/sh4/translate.c | 7 +-
target/sparc/translate.c | 7 +-
target/tricore/translate.c | 7 +-
target/xtensa/translate.c | 7 +-
tcg/tcg.c | 184 +++++++-------
tests/unit/test-logging.c | 42 ++-
util/log.c | 365 +++++++++++++++++----------
49 files changed, 712 insertions(+), 659 deletions(-)
--
2.25.1
next reply other threads:[~2022-03-26 13:29 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 13:24 Richard Henderson [this message]
2022-03-26 13:24 ` [PATCH v2 1/8] linux-user/nios2: Hoist pc advance to the top of EXCP_TRAP Richard Henderson
2022-03-26 13:36 ` Richard Henderson
2022-03-26 13:24 ` [PATCH v2 01/39] util/log: Drop manual log buffering Richard Henderson
2022-03-26 13:24 ` [PATCH v2 2/8] linux-user/nios2: Fix clone child return Richard Henderson
2022-03-26 13:24 ` [PATCH v2 02/39] target/hexagon: Remove qemu_set_log in hexagon_translate_init Richard Henderson
2022-03-26 13:24 ` [PATCH v2 3/8] linux-user/nios2: Drop syscall 0 "workaround" Richard Henderson
2022-03-26 13:24 ` [PATCH v2 03/39] util/log: Return bool from qemu_set_log_filename Richard Henderson
2022-04-12 20:34 ` Alex Bennée
2022-03-26 13:24 ` [PATCH v2 4/8] linux-user/nios2: Adjust error return Richard Henderson
2022-03-26 13:24 ` [PATCH v2 04/39] util/log: Pass Error pointer to qemu_set_log Richard Henderson
2022-04-12 20:37 ` Alex Bennée
2022-03-26 13:24 ` [PATCH v2 5/8] linux-user/nios2: Handle special qemu syscall return values Richard Henderson
2022-03-26 13:24 ` [PATCH v2 05/39] os-posix: Use qemu_log_enabled Richard Henderson
2022-03-26 13:24 ` [PATCH v2 6/8] linux-user/nios2: Remove do_sigreturn Richard Henderson
2022-03-26 13:24 ` [PATCH v2 06/39] util/log: Move qemu_log_lock, qemu_log_unlock out of line Richard Henderson
2022-03-26 13:25 ` [PATCH v2 7/8] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn Richard Henderson
2022-03-26 13:25 ` [PATCH v2 07/39] util/log: Rename qemu_log_lock to qemu_log_trylock Richard Henderson
2022-04-12 20:38 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 08/39] hw/xen: Split out xen_pv_output_msg Richard Henderson
2022-03-26 13:25 ` [PATCH v2 8/8] tests/tcg/nios2: Re-enable linux-user tests Richard Henderson
2022-03-26 13:25 ` [PATCH v2 09/39] *: Use fprintf between qemu_log_trylock/unlock Richard Henderson
2022-04-13 13:54 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 10/39] util/log: Remove qemu_log_vprintf Richard Henderson
2022-03-26 13:25 ` [PATCH v2 11/39] tcg: Pass the locked filepointer to tcg_dump_ops Richard Henderson
2022-04-13 9:08 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 12/39] exec/translator: Pass the locked filepointer to disas_log hook Richard Henderson
2022-04-13 13:55 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 13/39] exec/log: Remove log_disas and log_target_disas Richard Henderson
2022-04-13 18:41 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 14/39] accel/tcg: Use cpu_dump_state between qemu_log_trylock/unlock Richard Henderson
2022-04-14 13:46 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 15/39] target/nios2: Remove log_cpu_state from reset Richard Henderson
2022-04-14 13:47 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 16/39] util/log: Use qemu_log_trylock/unlock in qemu_log Richard Henderson
2022-03-26 13:25 ` [PATCH v2 17/39] util/log: Drop return value from qemu_log Richard Henderson
2022-04-14 14:18 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 18/39] util/log: Mark qemu_log_trylock as G_GNUC_WARN_UNUSED_RESULT Richard Henderson
2022-04-14 14:18 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 19/39] util/log: Remove qemu_log_flush Richard Henderson
2022-04-14 14:19 ` Alex Bennée
2022-04-14 14:20 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 20/39] util/log: Drop call to setvbuf Richard Henderson
2022-04-14 14:21 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 21/39] bsd-user: Expand log_page_dump inline Richard Henderson
2022-04-14 14:21 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 22/39] linux-user: " Richard Henderson
2022-04-14 14:22 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 23/39] tests/unit: Do not reference QemuLogFile directly Richard Henderson
2022-04-14 14:49 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 24/39] include/exec/log: " Richard Henderson
2022-03-26 13:25 ` [PATCH v2 25/39] include/qemu/log: Move entire implementation out-of-line Richard Henderson
2022-04-14 14:50 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 26/39] sysemu/os-win32: Test for and use _lock_file/_unlock_file Richard Henderson
2022-04-14 14:51 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 27/39] util/log: Introduce qemu_set_log_filename_flags Richard Henderson
2022-04-14 14:56 ` Alex Bennée
2022-04-14 17:32 ` Richard Henderson
2022-03-26 13:25 ` [PATCH v2 28/39] bsd-user: Use qemu_set_log_filename_flags Richard Henderson
2022-04-14 15:02 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 29/39] linux-user: " Richard Henderson
2022-04-14 15:06 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 30/39] softmmu: " Richard Henderson
2022-04-14 15:16 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 31/39] util/log: Remove qemu_log_close Richard Henderson
2022-04-14 15:16 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 32/39] util/log: Rename logfilename to global_filename Richard Henderson
2022-04-14 15:18 ` Alex Bennée
2022-04-14 15:56 ` Richard Henderson
2022-03-26 13:25 ` [PATCH v2 33/39] util/log: Rename qemu_logfile to global_file Richard Henderson
2022-04-14 15:19 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 34/39] util/log: Rename qemu_logfile_mutex to global_mutex Richard Henderson
2022-04-14 15:21 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 35/39] util/log: Hoist the eval of is_daemonized in qemu_set_log_internal Richard Henderson
2022-04-14 15:25 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 36/39] util/log: Combine two logfile closes Richard Henderson
2022-04-14 15:26 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 37/39] util/log: Rename QemuLogFile to RCUCloseFILE Richard Henderson
2022-04-14 15:27 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 38/39] util/log: Limit RCUCloseFILE to file closing Richard Henderson
2022-04-14 15:30 ` Alex Bennée
2022-03-26 13:25 ` [PATCH v2 39/39] util/log: Support per-thread log files Richard Henderson
2022-04-14 15:35 ` Alex Bennée
2022-04-14 16:32 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220326132534.543738-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.