From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B67C433F5 for ; Fri, 1 Apr 2022 12:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346005AbiDAM5X (ORCPT ); Fri, 1 Apr 2022 08:57:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345997AbiDAM5W (ORCPT ); Fri, 1 Apr 2022 08:57:22 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BEFC1DB8BE for ; Fri, 1 Apr 2022 05:55:33 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naGoK-000709-7q; Fri, 01 Apr 2022 14:55:28 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1naGoJ-0002ZA-D5; Fri, 01 Apr 2022 14:55:27 +0200 Date: Fri, 1 Apr 2022 14:55:27 +0200 From: Sascha Hauer To: Andy Yan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis , Kever Yang Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Message-ID: <20220401125527.GM4012@pengutronix.de> References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:54:05 up 2 days, 1:23, 55 users, load average: 0.13, 0.21, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: > Hi: > > On 3/31/22 16:18, Sascha Hauer wrote: > > On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 3/31/22 15:06, Sascha Hauer wrote: > > > > On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: > > > > > Hi Sascha: > > > > > > > > > > On 3/30/22 14:39, Sascha Hauer wrote: > > > > > > Hi Andy, > > > > > > > > > > > > On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: > > > > > > > Hi Sascha: > > > > > > > > > > > > > > On 3/28/22 23:11, Sascha Hauer wrote: > > > > > > > > With upcoming VOP2 support VOP won't be the only choice anymore, so make > > > > > > > > the VOP driver optional. > > > > > > > > > > > > > > > > Signed-off-by: Sascha Hauer > > > > > > > > --- > > > > > > > > drivers/gpu/drm/rockchip/Kconfig | 8 ++++++++ > > > > > > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > > > > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > > > > > > 3 files changed, 11 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > index fa5cfda4e90e3..7d22e2997a571 100644 > > > > > > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > @@ -23,8 +23,16 @@ config DRM_ROCKCHIP > > > > > > > > if DRM_ROCKCHIP > > > > > > > > +config ROCKCHIP_VOP > > > > > > > > + bool "Rockchip VOP driver" > > > > > > > > + default y > > > > > > > > + help > > > > > > > > + This selects support for the VOP driver. You should enable it > > > > > > > > + on all older SoCs up to RK3399. > > > > > > That reminds me that I wanted to rephrase this. Will change in next > > > > > > round. > > > > > > > > > > > > > > + > > > > > > > > config ROCKCHIP_ANALOGIX_DP > > > > > > > > bool "Rockchip specific extensions for Analogix DP driver" > > > > > > > > + depends on ROCKCHIP_VOP > > > > > > > Aanlogix dp is also on vop2 base soc such as  rk356x and rk3588. > > > > BTW I just looked at the downstream driver. Here we have the same > > > > situation that the analogix dp driver calls rockchip_drm_wait_vact_end() > > > > which is implemented in the VOP driver, so when the analogix dp driver > > > > is actually used on a VOP2 SoC then it is either used in a way that > > > > rockchip_drm_wait_vact_end() will never be called or it explodes in all > > > > colours. > > > > > > > > > > I added the dependency because analogix_dp-rockchip.c calls > > > > > > rockchip_drm_wait_vact_end() which is implemented in the VOP driver, > > > > > > so this driver currenty can't work with the VOP2 driver and can't > > > > > > be linked without the VOP driver being present. > > > > > > I'll add a few words to the commit message. > > > > > Maybe a better direction is move rockchip_drm_wait_vact_end from the VOP > > > > > driver to rockchip_drm_drv.c > > > > I am not sure if that's really worth it. Yes, the direction might be the > > > > right one, but I would really prefer when somebody does the change who > > > > can test and confirm that the analogix dp really works with VOP2 in the > > > > end. > > > If follow this point, the current DW_MIPI also has not been tested for > > > confirm that it > > > > > > can really work with VOP2, so you should also make it depends on > > > ROCKCHIP_VOP. > > Well at least I have patches here which make DW_MIPI work with VOP2 ;) > > > But you DW_MIPI patches for rk356x didn't come. So this is not keep > consistency with this point. > > > > > What about the others, like LVDS and RGB? > > > Yes, we also have other interface , RK356X has LVDS/RGB/BT1120/BT656, RK3588 > has BT1120/BT656, no LVDS or RGB. > > > > I think the current solution is just a workaround to make your patch pass > > > the kernel compile > > Indeed. > > > > I agree that it would be good to add a note somewhere which outputs > > work with the VOP2 driver (currently only HDMI), but I wonder if Kconfig > > dependencies is the right place for it, because only people who deliberately > > disable VOP support will see this information. > > Maybe we should rather add it to the Kconfig help text? > > > If a device is supported for this soc, we will add dt node at the dtsi file. > > A Kconfig dependencies don't seems a good idea. Ok, this means we can keep my current approach with just letting ROCKCHIP_ANALOGIX_DP depend on ROCKCHIP_VOP to avoid having a non buildable kernel. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73237C433F5 for ; Fri, 1 Apr 2022 12:55:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A+9QJtLbLKykzXuaYIaatPOqk0B0PfMYr90lu91ZI3Q=; b=ecgCtaNHOmsMtk qbm3NXOcjr+c2aTDE0TE/8JrY3P/9aL1IW9/B6ZwolZW75Cp0TuzuRLfV8KgCmvZ9EhFZKITaaL2b wwGsrH3bd+daeVSFIaSwyTJKGGpMVVCR+wTkFX9wnZ2aLeHmuiIc6OkeBGZKBC36uf4lzMnq++aXs GnbyOdBznXik4ro/7ORhetCFZvRK085xw7QKNY8JRwfUmEIr5l2Gp3r5bFfLsLu8jF0xtTFAWWjTX xb5A/MCWD1Tg3ruDyjF5E2RWbvW2c6OUDcbLdCv/45KrEzTIOS9dLW0nUA0eEYxEAVyhzaONjC8LB QwazP45zIvBOyR1SeHaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGoX-005gKc-E1; Fri, 01 Apr 2022 12:55:41 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGoN-005gI4-Ah for linux-rockchip@lists.infradead.org; Fri, 01 Apr 2022 12:55:33 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naGoK-000709-7q; Fri, 01 Apr 2022 14:55:28 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1naGoJ-0002ZA-D5; Fri, 01 Apr 2022 14:55:27 +0200 Date: Fri, 1 Apr 2022 14:55:27 +0200 From: Sascha Hauer To: Andy Yan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis , Kever Yang Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Message-ID: <20220401125527.GM4012@pengutronix.de> References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:54:05 up 2 days, 1:23, 55 users, load average: 0.13, 0.21, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_055531_394340_80A9C7E6 X-CRM114-Status: GOOD ( 57.33 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: > Hi: > = > On 3/31/22 16:18, Sascha Hauer wrote: > > On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > = > > > On 3/31/22 15:06, Sascha Hauer wrote: > > > > On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: > > > > > Hi Sascha: > > > > > = > > > > > On 3/30/22 14:39, Sascha Hauer wrote: > > > > > > Hi Andy, > > > > > > = > > > > > > On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: > > > > > > > Hi Sascha: > > > > > > > = > > > > > > > On 3/28/22 23:11, Sascha Hauer wrote: > > > > > > > > With upcoming VOP2 support VOP won't be the only choice any= more, so make > > > > > > > > the VOP driver optional. > > > > > > > > = > > > > > > > > Signed-off-by: Sascha Hauer > > > > > > > > --- > > > > > > > > drivers/gpu/drm/rockchip/Kconfig | 8 ++++++= ++ > > > > > > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > > > > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > > > > > > 3 files changed, 11 insertions(+), 2 deletions(-) > > > > > > > > = > > > > > > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu= /drm/rockchip/Kconfig > > > > > > > > index fa5cfda4e90e3..7d22e2997a571 100644 > > > > > > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > @@ -23,8 +23,16 @@ config DRM_ROCKCHIP > > > > > > > > if DRM_ROCKCHIP > > > > > > > > +config ROCKCHIP_VOP > > > > > > > > + bool "Rockchip VOP driver" > > > > > > > > + default y > > > > > > > > + help > > > > > > > > + This selects support for the VOP driver. You should ena= ble it > > > > > > > > + on all older SoCs up to RK3399. > > > > > > That reminds me that I wanted to rephrase this. Will change in = next > > > > > > round. > > > > > > = > > > > > > > > + > > > > > > > > config ROCKCHIP_ANALOGIX_DP > > > > > > > > bool "Rockchip specific extensions for Analogix DP dr= iver" > > > > > > > > + depends on ROCKCHIP_VOP > > > > > > > Aanlogix dp is also on vop2 base soc such as=A0 rk356x and rk= 3588. > > > > BTW I just looked at the downstream driver. Here we have the same > > > > situation that the analogix dp driver calls rockchip_drm_wait_vact_= end() > > > > which is implemented in the VOP driver, so when the analogix dp dri= ver > > > > is actually used on a VOP2 SoC then it is either used in a way that > > > > rockchip_drm_wait_vact_end() will never be called or it explodes in= all > > > > colours. > > > > = > > > > > > I added the dependency because analogix_dp-rockchip.c calls > > > > > > rockchip_drm_wait_vact_end() which is implemented in the VOP dr= iver, > > > > > > so this driver currenty can't work with the VOP2 driver and can= 't > > > > > > be linked without the VOP driver being present. > > > > > > I'll add a few words to the commit message. > > > > > Maybe a better direction is move rockchip_drm_wait_vact_end from = the VOP > > > > > driver to rockchip_drm_drv.c > > > > I am not sure if that's really worth it. Yes, the direction might b= e the > > > > right one, but I would really prefer when somebody does the change = who > > > > can test and confirm that the analogix dp really works with VOP2 in= the > > > > end. > > > If follow this point, the current DW_MIPI also has not been tested for > > > confirm that it > > > = > > > can really work with VOP2, so you should also make it depends on > > > ROCKCHIP_VOP. > > Well at least I have patches here which make DW_MIPI work with VOP2 ;) > = > = > But you DW_MIPI patches for rk356x didn't come. So this is not keep > consistency with this point. > = > > = > > What about the others, like LVDS and RGB? > = > = > Yes, we also have other interface , RK356X has LVDS/RGB/BT1120/BT656, RK3= 588 > has BT1120/BT656, no LVDS or RGB. > = > > > I think the current solution is just a workaround to make your patch = pass > > > the kernel compile > > Indeed. > > = > > I agree that it would be good to add a note somewhere which outputs > > work with the VOP2 driver (currently only HDMI), but I wonder if Kconfig > > dependencies is the right place for it, because only people who deliber= ately > > disable VOP support will see this information. > > Maybe we should rather add it to the Kconfig help text? > = > = > If a device is supported for this soc, we will add dt node at the dtsi fi= le. > = > A Kconfig dependencies don't seems a good idea. Ok, this means we can keep my current approach with just letting ROCKCHIP_ANALOGIX_DP depend on ROCKCHIP_VOP to avoid having a non buildable kernel. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 420BFC433EF for ; Fri, 1 Apr 2022 12:55:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E8D110E257; Fri, 1 Apr 2022 12:55:31 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE02110E257 for ; Fri, 1 Apr 2022 12:55:29 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naGoK-000709-7q; Fri, 01 Apr 2022 14:55:28 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1naGoJ-0002ZA-D5; Fri, 01 Apr 2022 14:55:27 +0200 Date: Fri, 1 Apr 2022 14:55:27 +0200 From: Sascha Hauer To: Andy Yan Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Message-ID: <20220401125527.GM4012@pengutronix.de> References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:54:05 up 2 days, 1:23, 55 users, load average: 0.13, 0.21, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, Kever Yang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: > Hi: > > On 3/31/22 16:18, Sascha Hauer wrote: > > On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 3/31/22 15:06, Sascha Hauer wrote: > > > > On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: > > > > > Hi Sascha: > > > > > > > > > > On 3/30/22 14:39, Sascha Hauer wrote: > > > > > > Hi Andy, > > > > > > > > > > > > On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: > > > > > > > Hi Sascha: > > > > > > > > > > > > > > On 3/28/22 23:11, Sascha Hauer wrote: > > > > > > > > With upcoming VOP2 support VOP won't be the only choice anymore, so make > > > > > > > > the VOP driver optional. > > > > > > > > > > > > > > > > Signed-off-by: Sascha Hauer > > > > > > > > --- > > > > > > > > drivers/gpu/drm/rockchip/Kconfig | 8 ++++++++ > > > > > > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > > > > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > > > > > > 3 files changed, 11 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > index fa5cfda4e90e3..7d22e2997a571 100644 > > > > > > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > @@ -23,8 +23,16 @@ config DRM_ROCKCHIP > > > > > > > > if DRM_ROCKCHIP > > > > > > > > +config ROCKCHIP_VOP > > > > > > > > + bool "Rockchip VOP driver" > > > > > > > > + default y > > > > > > > > + help > > > > > > > > + This selects support for the VOP driver. You should enable it > > > > > > > > + on all older SoCs up to RK3399. > > > > > > That reminds me that I wanted to rephrase this. Will change in next > > > > > > round. > > > > > > > > > > > > > > + > > > > > > > > config ROCKCHIP_ANALOGIX_DP > > > > > > > > bool "Rockchip specific extensions for Analogix DP driver" > > > > > > > > + depends on ROCKCHIP_VOP > > > > > > > Aanlogix dp is also on vop2 base soc such as  rk356x and rk3588. > > > > BTW I just looked at the downstream driver. Here we have the same > > > > situation that the analogix dp driver calls rockchip_drm_wait_vact_end() > > > > which is implemented in the VOP driver, so when the analogix dp driver > > > > is actually used on a VOP2 SoC then it is either used in a way that > > > > rockchip_drm_wait_vact_end() will never be called or it explodes in all > > > > colours. > > > > > > > > > > I added the dependency because analogix_dp-rockchip.c calls > > > > > > rockchip_drm_wait_vact_end() which is implemented in the VOP driver, > > > > > > so this driver currenty can't work with the VOP2 driver and can't > > > > > > be linked without the VOP driver being present. > > > > > > I'll add a few words to the commit message. > > > > > Maybe a better direction is move rockchip_drm_wait_vact_end from the VOP > > > > > driver to rockchip_drm_drv.c > > > > I am not sure if that's really worth it. Yes, the direction might be the > > > > right one, but I would really prefer when somebody does the change who > > > > can test and confirm that the analogix dp really works with VOP2 in the > > > > end. > > > If follow this point, the current DW_MIPI also has not been tested for > > > confirm that it > > > > > > can really work with VOP2, so you should also make it depends on > > > ROCKCHIP_VOP. > > Well at least I have patches here which make DW_MIPI work with VOP2 ;) > > > But you DW_MIPI patches for rk356x didn't come. So this is not keep > consistency with this point. > > > > > What about the others, like LVDS and RGB? > > > Yes, we also have other interface , RK356X has LVDS/RGB/BT1120/BT656, RK3588 > has BT1120/BT656, no LVDS or RGB. > > > > I think the current solution is just a workaround to make your patch pass > > > the kernel compile > > Indeed. > > > > I agree that it would be good to add a note somewhere which outputs > > work with the VOP2 driver (currently only HDMI), but I wonder if Kconfig > > dependencies is the right place for it, because only people who deliberately > > disable VOP support will see this information. > > Maybe we should rather add it to the Kconfig help text? > > > If a device is supported for this soc, we will add dt node at the dtsi file. > > A Kconfig dependencies don't seems a good idea. Ok, this means we can keep my current approach with just letting ROCKCHIP_ANALOGIX_DP depend on ROCKCHIP_VOP to avoid having a non buildable kernel. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0987CC433F5 for ; Fri, 1 Apr 2022 12:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/enng4iyTqGSWmORYJBllc7dYwowqfZVKqU3WkYh7dI=; b=ysx2SS044OV2y6 vx0n4Q0ZNF+o1XVkqN7QCzvG0qdVWqeSF9d+eB/C/QVwlaDhyMctTaZRW1Xbboa72TVQ/i3Lwcc0z 655I5Hp677BKc8QELO8IBnTMh+gqouwWjwWZnJW0iae7DTWunEN4OGZ9+4JE0Q9M40OXNjC6qtd8a 6HPU+bDkkFJFWBK93hd85cR/WGiTmHopvMwS27uixZQ5mwMdlgN0gGHDjx5vTAawUGIRno/LzwF+Y 207DyZep42YeBomdxiBrLSd1OOmeRsNjDi2XR99GFjJIOxMHhjqzJQK8uzOr+uRhLKavC5UkTNk0F 3xKMTzVIcVCBzKbpGziQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGoP-005gId-Lw; Fri, 01 Apr 2022 12:55:33 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naGoL-005gHY-PD for linux-arm-kernel@lists.infradead.org; Fri, 01 Apr 2022 12:55:31 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1naGoK-000709-7q; Fri, 01 Apr 2022 14:55:28 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1naGoJ-0002ZA-D5; Fri, 01 Apr 2022 14:55:27 +0200 Date: Fri, 1 Apr 2022 14:55:27 +0200 From: Sascha Hauer To: Andy Yan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-15?Q?St=FCbner?= , Peter Geis , Kever Yang Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Message-ID: <20220401125527.GM4012@pengutronix.de> References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> <20220331081815.GF4012@pengutronix.de> <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8aa9da47-d7ed-41bf-384c-103757c19fe2@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:54:05 up 2 days, 1:23, 55 users, load average: 0.13, 0.21, 0.17 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_055529_855334_22A3934B X-CRM114-Status: GOOD ( 58.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: > Hi: > = > On 3/31/22 16:18, Sascha Hauer wrote: > > On Thu, Mar 31, 2022 at 03:20:37PM +0800, Andy Yan wrote: > > > Hi Sascha: > > > = > > > On 3/31/22 15:06, Sascha Hauer wrote: > > > > On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: > > > > > Hi Sascha: > > > > > = > > > > > On 3/30/22 14:39, Sascha Hauer wrote: > > > > > > Hi Andy, > > > > > > = > > > > > > On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: > > > > > > > Hi Sascha: > > > > > > > = > > > > > > > On 3/28/22 23:11, Sascha Hauer wrote: > > > > > > > > With upcoming VOP2 support VOP won't be the only choice any= more, so make > > > > > > > > the VOP driver optional. > > > > > > > > = > > > > > > > > Signed-off-by: Sascha Hauer > > > > > > > > --- > > > > > > > > drivers/gpu/drm/rockchip/Kconfig | 8 ++++++= ++ > > > > > > > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > > > > > > > > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- > > > > > > > > 3 files changed, 11 insertions(+), 2 deletions(-) > > > > > > > > = > > > > > > > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu= /drm/rockchip/Kconfig > > > > > > > > index fa5cfda4e90e3..7d22e2997a571 100644 > > > > > > > > --- a/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > +++ b/drivers/gpu/drm/rockchip/Kconfig > > > > > > > > @@ -23,8 +23,16 @@ config DRM_ROCKCHIP > > > > > > > > if DRM_ROCKCHIP > > > > > > > > +config ROCKCHIP_VOP > > > > > > > > + bool "Rockchip VOP driver" > > > > > > > > + default y > > > > > > > > + help > > > > > > > > + This selects support for the VOP driver. You should ena= ble it > > > > > > > > + on all older SoCs up to RK3399. > > > > > > That reminds me that I wanted to rephrase this. Will change in = next > > > > > > round. > > > > > > = > > > > > > > > + > > > > > > > > config ROCKCHIP_ANALOGIX_DP > > > > > > > > bool "Rockchip specific extensions for Analogix DP dr= iver" > > > > > > > > + depends on ROCKCHIP_VOP > > > > > > > Aanlogix dp is also on vop2 base soc such as=A0 rk356x and rk= 3588. > > > > BTW I just looked at the downstream driver. Here we have the same > > > > situation that the analogix dp driver calls rockchip_drm_wait_vact_= end() > > > > which is implemented in the VOP driver, so when the analogix dp dri= ver > > > > is actually used on a VOP2 SoC then it is either used in a way that > > > > rockchip_drm_wait_vact_end() will never be called or it explodes in= all > > > > colours. > > > > = > > > > > > I added the dependency because analogix_dp-rockchip.c calls > > > > > > rockchip_drm_wait_vact_end() which is implemented in the VOP dr= iver, > > > > > > so this driver currenty can't work with the VOP2 driver and can= 't > > > > > > be linked without the VOP driver being present. > > > > > > I'll add a few words to the commit message. > > > > > Maybe a better direction is move rockchip_drm_wait_vact_end from = the VOP > > > > > driver to rockchip_drm_drv.c > > > > I am not sure if that's really worth it. Yes, the direction might b= e the > > > > right one, but I would really prefer when somebody does the change = who > > > > can test and confirm that the analogix dp really works with VOP2 in= the > > > > end. > > > If follow this point, the current DW_MIPI also has not been tested for > > > confirm that it > > > = > > > can really work with VOP2, so you should also make it depends on > > > ROCKCHIP_VOP. > > Well at least I have patches here which make DW_MIPI work with VOP2 ;) > = > = > But you DW_MIPI patches for rk356x didn't come. So this is not keep > consistency with this point. > = > > = > > What about the others, like LVDS and RGB? > = > = > Yes, we also have other interface , RK356X has LVDS/RGB/BT1120/BT656, RK3= 588 > has BT1120/BT656, no LVDS or RGB. > = > > > I think the current solution is just a workaround to make your patch = pass > > > the kernel compile > > Indeed. > > = > > I agree that it would be good to add a note somewhere which outputs > > work with the VOP2 driver (currently only HDMI), but I wonder if Kconfig > > dependencies is the right place for it, because only people who deliber= ately > > disable VOP support will see this information. > > Maybe we should rather add it to the Kconfig help text? > = > = > If a device is supported for this soc, we will add dt node at the dtsi fi= le. > = > A Kconfig dependencies don't seems a good idea. Ok, this means we can keep my current approach with just letting ROCKCHIP_ANALOGIX_DP depend on ROCKCHIP_VOP to avoid having a non buildable kernel. Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel