Re: [PATCH 3/3] xfs/216: handle larger log sizes

[Zorro Lang <zlang@redhat.com>]

On Thu, Apr 14, 2022 at 12:36:35PM -0700, Darrick J. Wong wrote:
> On Fri, Apr 15, 2022 at 03:25:31AM +0800, Zorro Lang wrote:
> > On Wed, Apr 13, 2022 at 06:51:49PM -0700, Darrick J. Wong wrote:
> > > On Thu, Apr 14, 2022 at 01:44:00AM +0800, Zorro Lang wrote:
> > > > On Mon, Apr 11, 2022 at 03:55:13PM -0700, Darrick J. Wong wrote:
> > > > > From: Darrick J. Wong <djwong@kernel.org>
> > > > > 
> > > > > mkfs will soon refuse to format a log smaller than 64MB, so update this
> > > > > test to reflect the new log sizing calculations.
> > > > > 
> > > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > > > > ---
> > > > >  tests/xfs/216.out |   14 +++++++-------
> > > > >  1 file changed, 7 insertions(+), 7 deletions(-)
> > > > > 
> > > > > 
> > > > > diff --git a/tests/xfs/216.out b/tests/xfs/216.out
> > > > > index cbd7b652..3c12085f 100644
> > > > > --- a/tests/xfs/216.out
> > > > > +++ b/tests/xfs/216.out
> > > > > @@ -1,10 +1,10 @@
> > > > >  QA output created by 216
> > > > > -fssize=1g log      =internal log           bsize=4096   blocks=2560, version=2
> > > > > -fssize=2g log      =internal log           bsize=4096   blocks=2560, version=2
> > > > > -fssize=4g log      =internal log           bsize=4096   blocks=2560, version=2
> > > > > -fssize=8g log      =internal log           bsize=4096   blocks=2560, version=2
> > > > > -fssize=16g log      =internal log           bsize=4096   blocks=2560, version=2
> > > > > -fssize=32g log      =internal log           bsize=4096   blocks=4096, version=2
> > > > > -fssize=64g log      =internal log           bsize=4096   blocks=8192, version=2
> > > > > +fssize=1g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > > +fssize=2g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > > +fssize=4g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > > +fssize=8g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > > +fssize=16g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > > +fssize=32g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > > +fssize=64g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > 
> > > > So this will break downstream kernel testing too, except it follows this new
> > > > xfs behavior change. Is it possible to get the minimal log size, then help to
> > > > avoid the failure (if it won't mess up the code:)?
> > > 
> > > Hmm.  I suppose we could do a .out.XXX switcheroo type thing, though I
> > > don't know of a good way to detect which mkfs behavior you've got.
> > 
> > Don't need to take much time to handle it :) How about use a specified filter function,
> > filter all log blocks number <= 16384, if the number of blocks=$number <= 16384, transform
> > it to blocks=* or what anything else do you like ?
> > 
> > I think we don't really care how much the log size less than 64M, right? Just hope it
> > works (can be mounted and read/write)?
> 
> <shrug> Well I already reworked this patch to create 216.out.64mblog and
> 216.out.classic, and symlink them to 216.out as appropriate given the
> log size for a 512m log format, since it probably *is* a good idea to
> make sure older mkfs doesn't stray.

Thanks for doing this! I saw Dave has described the history reason[1] of this test, so
I think your new change on this patch is good to me. I've acked two other patches, I'll
give RVB to this one ASAP after you send the new version.

Thanks,
Zorro


[1]
05:58 < dchinner> sandeen: I'm betting that I wrote that test to ensure the changes I made in mkfs commit a6634fba3dec ("mkfs: allow to make larger logs") didn't change the log size for 
                  small filesystems
05:58 < dchinner> that was the commit that changed the max log size from 128MB to 2GB

> 
> --D
> 
> > Thanks,
> > Zorro
> > 
> > > 
> > > --D
> > > 
> > > > 
> > > > >  fssize=128g log      =internal log           bsize=4096   blocks=16384, version=2
> > > > >  fssize=256g log      =internal log           bsize=4096   blocks=32768, version=2
> > > > > 
> > > > 
> > > 
> > 
>