From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC55AC433EF for ; Tue, 19 Apr 2022 08:26:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349997AbiDSI3U (ORCPT ); Tue, 19 Apr 2022 04:29:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240524AbiDSI3R (ORCPT ); Tue, 19 Apr 2022 04:29:17 -0400 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17BD92DD46; Tue, 19 Apr 2022 01:26:34 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5B566FF804; Tue, 19 Apr 2022 08:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650356793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VXBlhum4y6XFxuELbe8JGMivZRApx0IpgXnue2l+2tA=; b=En4XckKRy2XUHcPmxdD3HS/8imGMUX23JA+DVW2whyGf+0TkYT1GxTJToeKg7JxW6sp5YD 5T0JqZyLmOcpT1Iscp4JTrMcF69FqaC2psvhgVarurkbtDHCd+TQMp1LDZQTn6fSMVP84V m2EAoe4FtF7XBLmH+M/XIhq17fudmWBlAwS/Wj97MBQcbsMXbn0E16axGlemoqdzPpyoya fAisPIPcnZTYKVRtov653V9gvO5sDfdIPJe/GZr/3QyP8Ea81PUSS5b6v3GY9CSZBnVm0t RyH6QoClKUE+YOkWoXhtMnMlpeNu/C5hwRwH4GI3lUOr9PNnM21z0cRB9bfj7Q== Date: Tue, 19 Apr 2022 10:26:29 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419102629.1c77aa2a@xps13> In-Reply-To: References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, liang.yang@amlogic.com wrote on Mon, 18 Apr 2022 11:40:10 +0800: > Hi Miquel, >=20 > i have some confusion when i prepare the patches. for DT compatibility, i= t falls back to the old DT when failed to get resource by the new DT, but t= here is some points: > a. old DT depends on MMC sub clock driver, but it never be merged, so it = can't work. I don't get what you mean here, sorry. I believe there is a new way to describe this clock but grabbing the one from the MMC still works, does not it? > b. if it falls back to the old DT, beside the regmap lookup below, it see= ms that we have to preserve the code of the old clock setting in nfc_clk_in= it(). Yes, probably. > do we still need to avoid break DT compatibility? We should try our best to avoid breaking the DT, yes. >=20 > Thanks. >=20 > On 2022/4/11 10:40, Liang Yang wrote: > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 nfc->dev =3D dev; > >>> -=C2=A0=C2=A0=C2=A0 res =3D platform_get_resource(pdev, IORESOURCE_ME= M, 0); > >>> -=C2=A0=C2=A0=C2=A0 nfc->reg_base =3D devm_ioremap_resource(dev, res); > >>> +=C2=A0=C2=A0=C2=A0 nfc->reg_base =3D devm_platform_ioremap_resource_= byname(pdev, "nfc"); =20 > >> > >> This change seems unrelated. =20 > >=20 > > To be consistent with the following > devm_platform_ioremap_resource_by= name(pdev, "emmc"). do you mean that we > don't need it?> =20 > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (IS_ERR(nfc->reg_base)) > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_ERR= (nfc->reg_base); > >>> -=C2=A0=C2=A0=C2=A0 nfc->reg_clk =3D > >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 syscon_regmap_lookup_by_p= handle(dev->of_node, > >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "a= mlogic,mmc-syscon"); > >>> -=C2=A0=C2=A0=C2=A0 if (IS_ERR(nfc->reg_clk)) { > >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev_err(dev, "Failed to l= ookup clock base\n"); > >>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_ERR(nfc->reg_c= lk); > >>> -=C2=A0=C2=A0=C2=A0 } > >>> +=C2=A0=C2=A0=C2=A0 nfc->sd_emmc_clock =3D devm_platform_ioremap_reso= urce_byname(pdev, >>> "emmc"); > >>> +=C2=A0=C2=A0=C2=A0 if (IS_ERR(nfc->sd_emmc_clock)) > >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return PTR_ERR(nfc->sd_em= mc_clock); =20 > >> > >> While I agree this is much better than the previous solution, we cannot > >> break DT compatibility, so you need to try getting the emmc clock, but > >> if it fails you should fallback to the regmap lookup. =20 > >=20 > > ok, i will fix it next version. thanks. > > =20 > >> =20 > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 irq =3D platform_get_irq(pdev, 0); =20 Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37D82C433EF for ; Tue, 19 Apr 2022 08:26:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xvXgV6qMsqKz227DogVKyBVxcJ+PFERhpQNfzdwWUIs=; b=zhx6E+Fv7d/hVx pF1oA0NpsicSC0Rdz5mFyaOqQ3JGbAakgKn8ppZTaBWrh/yfsL7M80NSyx2SDHe//uoVOuTmO2jOt siFzsCJjP1Vq7xW+au8sd9l0b3i7LX1Fxdx1KppgYpzyFvUtSiFB3ihKxkct9o6WHWx7CPG4xTVrG FrQkNcRvR104cRse9BNGJAK/+p7wuqLtLF7l9RjVjAInIMAS66S6ZG7vpeoy2GGoNbcewjcyfROWb Y2Mpu9YOGAc3gR4U1R4EblD9JFMbpbsWYtpQNgB4gfmTV34Mv6KOWjeqqXdeEShCHp3p8dJuXR6z5 g6AnGXD2r9o3KjVP5/SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjCA-002JpZ-6X; Tue, 19 Apr 2022 08:26:46 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjC6-002Jli-Ta; Tue, 19 Apr 2022 08:26:44 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5B566FF804; Tue, 19 Apr 2022 08:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650356793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VXBlhum4y6XFxuELbe8JGMivZRApx0IpgXnue2l+2tA=; b=En4XckKRy2XUHcPmxdD3HS/8imGMUX23JA+DVW2whyGf+0TkYT1GxTJToeKg7JxW6sp5YD 5T0JqZyLmOcpT1Iscp4JTrMcF69FqaC2psvhgVarurkbtDHCd+TQMp1LDZQTn6fSMVP84V m2EAoe4FtF7XBLmH+M/XIhq17fudmWBlAwS/Wj97MBQcbsMXbn0E16axGlemoqdzPpyoya fAisPIPcnZTYKVRtov653V9gvO5sDfdIPJe/GZr/3QyP8Ea81PUSS5b6v3GY9CSZBnVm0t RyH6QoClKUE+YOkWoXhtMnMlpeNu/C5hwRwH4GI3lUOr9PNnM21z0cRB9bfj7Q== Date: Tue, 19 Apr 2022 10:26:29 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419102629.1c77aa2a@xps13> In-Reply-To: References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_012643_271417_24B822AB X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIE1vbiwgMTggQXByIDIwMjIg MTE6NDA6MTAgKzA4MDA6Cgo+IEhpIE1pcXVlbCwKPiAKPiBpIGhhdmUgc29tZSBjb25mdXNpb24g d2hlbiBpIHByZXBhcmUgdGhlIHBhdGNoZXMuIGZvciBEVCBjb21wYXRpYmlsaXR5LCBpdCBmYWxs cyBiYWNrIHRvIHRoZSBvbGQgRFQgd2hlbiBmYWlsZWQgdG8gZ2V0IHJlc291cmNlIGJ5IHRoZSBu ZXcgRFQsIGJ1dCB0aGVyZSBpcyBzb21lIHBvaW50czoKPiBhLiBvbGQgRFQgZGVwZW5kcyBvbiBN TUMgc3ViIGNsb2NrIGRyaXZlciwgYnV0IGl0IG5ldmVyIGJlIG1lcmdlZCwgc28gaXQgY2FuJ3Qg d29yay4KCkkgZG9uJ3QgZ2V0IHdoYXQgeW91IG1lYW4gaGVyZSwgc29ycnkuIEkgYmVsaWV2ZSB0 aGVyZSBpcyBhIG5ldyB3YXkgdG8KZGVzY3JpYmUgdGhpcyBjbG9jayBidXQgZ3JhYmJpbmcgdGhl IG9uZSBmcm9tIHRoZSBNTUMgc3RpbGwgd29ya3MsIGRvZXMKbm90IGl0PwoKPiBiLiBpZiBpdCBm YWxscyBiYWNrIHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywg aXQgc2VlbXMgdGhhdCB3ZSBoYXZlIHRvIHByZXNlcnZlIHRoZSBjb2RlIG9mIHRoZSBvbGQgY2xv Y2sgc2V0dGluZyBpbiBuZmNfY2xrX2luaXQoKS4KClllcywgcHJvYmFibHkuCgo+IGRvIHdlIHN0 aWxsIG5lZWQgdG8gYXZvaWQgYnJlYWsgRFQgY29tcGF0aWJpbGl0eT8KCldlIHNob3VsZCB0cnkg b3VyIGJlc3QgdG8gYXZvaWQgYnJlYWtpbmcgdGhlIERULCB5ZXMuCgo+IAo+IFRoYW5rcy4KPiAK PiBPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlhbmcgd3JvdGU6Cj4gPj4+IMKgwqDCoMKgwqAg bmZjLT5kZXYgPSBkZXY7Cj4gPj4+IC3CoMKgwqAgcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNl KHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsKPiA+Pj4gLcKgwqDCoCBuZmMtPnJlZ19iYXNlID0g ZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgcmVzKTsKPiA+Pj4gK8KgwqDCoCBuZmMtPnJlZ19i YXNlID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCAibmZjIik7 ICAKPiA+Pgo+ID4+IFRoaXMgY2hhbmdlIHNlZW1zIHVucmVsYXRlZC4gIAo+ID4gCj4gPiBUbyBi ZSBjb25zaXN0ZW50IHdpdGggdGhlIGZvbGxvd2luZyA+IGRldm1fcGxhdGZvcm1faW9yZW1hcF9y ZXNvdXJjZV9ieW5hbWUocGRldiwgImVtbWMiKS4gZG8geW91IG1lYW4gdGhhdCB3ZSA+IGRvbid0 IG5lZWQgaXQ/PiAgCj4gPj4+IMKgwqDCoMKgwqAgaWYgKElTX0VSUihuZmMtPnJlZ19iYXNlKSkK PiA+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5mYy0+cmVnX2Jhc2UpOwo+ ID4+PiAtwqDCoMKgIG5mYy0+cmVnX2NsayA9Cj4gPj4+IC3CoMKgwqDCoMKgwqDCoCBzeXNjb25f cmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlKGRldi0+b2Zfbm9kZSwKPiA+Pj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgImFtbG9naWMsbW1jLXN5c2NvbiIp Owo+ID4+PiAtwqDCoMKgIGlmIChJU19FUlIobmZjLT5yZWdfY2xrKSkgewo+ID4+PiAtwqDCoMKg wqDCoMKgwqAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gbG9va3VwIGNsb2NrIGJhc2VcbiIpOwo+ ID4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfY2xrKTsKPiA+Pj4g LcKgwqDCoCB9Cj4gPj4+ICvCoMKgwqAgbmZjLT5zZF9lbW1jX2Nsb2NrID0gZGV2bV9wbGF0Zm9y bV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCA+Pj4gImVtbWMiKTsKPiA+Pj4gK8KgwqDC oCBpZiAoSVNfRVJSKG5mYy0+c2RfZW1tY19jbG9jaykpCj4gPj4+ICvCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gUFRSX0VSUihuZmMtPnNkX2VtbWNfY2xvY2spOyAgCj4gPj4KPiA+PiBXaGlsZSBJIGFn cmVlIHRoaXMgaXMgbXVjaCBiZXR0ZXIgdGhhbiB0aGUgcHJldmlvdXMgc29sdXRpb24sIHdlIGNh bm5vdAo+ID4+IGJyZWFrIERUIGNvbXBhdGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0 aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQKPiA+PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxi YWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLiAgCj4gPiAKPiA+IG9rLCBpIHdpbGwgZml4IGl0IG5l eHQgdmVyc2lvbi4gdGhhbmtzLgo+ID4gICAKPiA+PiAgCj4gPj4+IMKgwqDCoMKgwqAgaXJxID0g cGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsgIAoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWls aW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D884C433F5 for ; Tue, 19 Apr 2022 08:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L0hM6uqQ3+uH+4Wyd+L+1fw0X1BzQM6uxjVZ0oP2T2E=; b=Ju/Xs0Bku3rqyx YplyQHekUi1g1v6W1ms5QCko6/VXHD6xDEvYVM5UpY28uXgorYO2/BSKMhx7mrTjm06RPsJ7BAbdU f1vHBiqiuV6t58C1h6Uut09kqSZPKKG9k2ksMniu+DRN3p5uQCflurFH0KC2FWejPdinhYryxYObl yh9vMyDkO61sFYs98d5cVlXc5P3q+aBQw17RQmnyxjP8g5ahM7wnxD3LcMxznqg3FDXfk7JwfYGwJ agL82K9DYzZo51t9ggj3dOTns6n2U/Db9wu9ff9LjFfRWIc9Wl2jaIB75zRFE0JgLL9nOLarXX4Eq 8JIzaaT7SOM7kmXg8m5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjCL-002Jtq-SC; Tue, 19 Apr 2022 08:26:57 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjC6-002Jli-Ta; Tue, 19 Apr 2022 08:26:44 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5B566FF804; Tue, 19 Apr 2022 08:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650356793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VXBlhum4y6XFxuELbe8JGMivZRApx0IpgXnue2l+2tA=; b=En4XckKRy2XUHcPmxdD3HS/8imGMUX23JA+DVW2whyGf+0TkYT1GxTJToeKg7JxW6sp5YD 5T0JqZyLmOcpT1Iscp4JTrMcF69FqaC2psvhgVarurkbtDHCd+TQMp1LDZQTn6fSMVP84V m2EAoe4FtF7XBLmH+M/XIhq17fudmWBlAwS/Wj97MBQcbsMXbn0E16axGlemoqdzPpyoya fAisPIPcnZTYKVRtov653V9gvO5sDfdIPJe/GZr/3QyP8Ea81PUSS5b6v3GY9CSZBnVm0t RyH6QoClKUE+YOkWoXhtMnMlpeNu/C5hwRwH4GI3lUOr9PNnM21z0cRB9bfj7Q== Date: Tue, 19 Apr 2022 10:26:29 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419102629.1c77aa2a@xps13> In-Reply-To: References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_012643_271417_24B822AB X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIE1vbiwgMTggQXByIDIwMjIg MTE6NDA6MTAgKzA4MDA6Cgo+IEhpIE1pcXVlbCwKPiAKPiBpIGhhdmUgc29tZSBjb25mdXNpb24g d2hlbiBpIHByZXBhcmUgdGhlIHBhdGNoZXMuIGZvciBEVCBjb21wYXRpYmlsaXR5LCBpdCBmYWxs cyBiYWNrIHRvIHRoZSBvbGQgRFQgd2hlbiBmYWlsZWQgdG8gZ2V0IHJlc291cmNlIGJ5IHRoZSBu ZXcgRFQsIGJ1dCB0aGVyZSBpcyBzb21lIHBvaW50czoKPiBhLiBvbGQgRFQgZGVwZW5kcyBvbiBN TUMgc3ViIGNsb2NrIGRyaXZlciwgYnV0IGl0IG5ldmVyIGJlIG1lcmdlZCwgc28gaXQgY2FuJ3Qg d29yay4KCkkgZG9uJ3QgZ2V0IHdoYXQgeW91IG1lYW4gaGVyZSwgc29ycnkuIEkgYmVsaWV2ZSB0 aGVyZSBpcyBhIG5ldyB3YXkgdG8KZGVzY3JpYmUgdGhpcyBjbG9jayBidXQgZ3JhYmJpbmcgdGhl IG9uZSBmcm9tIHRoZSBNTUMgc3RpbGwgd29ya3MsIGRvZXMKbm90IGl0PwoKPiBiLiBpZiBpdCBm YWxscyBiYWNrIHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywg aXQgc2VlbXMgdGhhdCB3ZSBoYXZlIHRvIHByZXNlcnZlIHRoZSBjb2RlIG9mIHRoZSBvbGQgY2xv Y2sgc2V0dGluZyBpbiBuZmNfY2xrX2luaXQoKS4KClllcywgcHJvYmFibHkuCgo+IGRvIHdlIHN0 aWxsIG5lZWQgdG8gYXZvaWQgYnJlYWsgRFQgY29tcGF0aWJpbGl0eT8KCldlIHNob3VsZCB0cnkg b3VyIGJlc3QgdG8gYXZvaWQgYnJlYWtpbmcgdGhlIERULCB5ZXMuCgo+IAo+IFRoYW5rcy4KPiAK PiBPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlhbmcgd3JvdGU6Cj4gPj4+IMKgwqDCoMKgwqAg bmZjLT5kZXYgPSBkZXY7Cj4gPj4+IC3CoMKgwqAgcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNl KHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsKPiA+Pj4gLcKgwqDCoCBuZmMtPnJlZ19iYXNlID0g ZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgcmVzKTsKPiA+Pj4gK8KgwqDCoCBuZmMtPnJlZ19i YXNlID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCAibmZjIik7 ICAKPiA+Pgo+ID4+IFRoaXMgY2hhbmdlIHNlZW1zIHVucmVsYXRlZC4gIAo+ID4gCj4gPiBUbyBi ZSBjb25zaXN0ZW50IHdpdGggdGhlIGZvbGxvd2luZyA+IGRldm1fcGxhdGZvcm1faW9yZW1hcF9y ZXNvdXJjZV9ieW5hbWUocGRldiwgImVtbWMiKS4gZG8geW91IG1lYW4gdGhhdCB3ZSA+IGRvbid0 IG5lZWQgaXQ/PiAgCj4gPj4+IMKgwqDCoMKgwqAgaWYgKElTX0VSUihuZmMtPnJlZ19iYXNlKSkK PiA+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5mYy0+cmVnX2Jhc2UpOwo+ ID4+PiAtwqDCoMKgIG5mYy0+cmVnX2NsayA9Cj4gPj4+IC3CoMKgwqDCoMKgwqDCoCBzeXNjb25f cmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlKGRldi0+b2Zfbm9kZSwKPiA+Pj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgImFtbG9naWMsbW1jLXN5c2NvbiIp Owo+ID4+PiAtwqDCoMKgIGlmIChJU19FUlIobmZjLT5yZWdfY2xrKSkgewo+ID4+PiAtwqDCoMKg wqDCoMKgwqAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gbG9va3VwIGNsb2NrIGJhc2VcbiIpOwo+ ID4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfY2xrKTsKPiA+Pj4g LcKgwqDCoCB9Cj4gPj4+ICvCoMKgwqAgbmZjLT5zZF9lbW1jX2Nsb2NrID0gZGV2bV9wbGF0Zm9y bV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCA+Pj4gImVtbWMiKTsKPiA+Pj4gK8KgwqDC oCBpZiAoSVNfRVJSKG5mYy0+c2RfZW1tY19jbG9jaykpCj4gPj4+ICvCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gUFRSX0VSUihuZmMtPnNkX2VtbWNfY2xvY2spOyAgCj4gPj4KPiA+PiBXaGlsZSBJIGFn cmVlIHRoaXMgaXMgbXVjaCBiZXR0ZXIgdGhhbiB0aGUgcHJldmlvdXMgc29sdXRpb24sIHdlIGNh bm5vdAo+ID4+IGJyZWFrIERUIGNvbXBhdGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0 aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQKPiA+PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxi YWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLiAgCj4gPiAKPiA+IG9rLCBpIHdpbGwgZml4IGl0IG5l eHQgdmVyc2lvbi4gdGhhbmtzLgo+ID4gICAKPiA+PiAgCj4gPj4+IMKgwqDCoMKgwqAgaXJxID0g cGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsgIAoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBk aXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F106C433F5 for ; Tue, 19 Apr 2022 08:27:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZInl62cRT2PkzhEdgIa1vcUSMnXXNt5oe5H7vqq6vfY=; b=wPuXSwUESynXEQ Of+0BxqERzvDGMQIZSRCRTZMvOy7Hu+TeQAUIib4aJIAOMKMm+T8ZGBOkQqZ8ETaW37GBSCQ+pmK8 ErSWqKmbfvoj/4TwXkBNOtFTY4mDTDBCBdO9N4Zmj6HXM0mexW2PB/9n1ElEapHA5+YHVkC0HxQn8 Gb5P34vNSag+PwhCfcy0a/jV3VAFbUj1pGaMQindniAIeG8DS1dKxTM04RfwMlZziLT8LSdd5M3/k EcSuxYT9l/QXRJ7982YWJUbtk6nS020mPX997a/cyD5WijpN1/+I22/RPXHIXcmzTM8SpokCVqK2q i5kuZwLjhgIU7+jMlovQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjCB-002Jpm-80; Tue, 19 Apr 2022 08:26:47 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngjC6-002Jli-Ta; Tue, 19 Apr 2022 08:26:44 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 5B566FF804; Tue, 19 Apr 2022 08:26:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1650356793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VXBlhum4y6XFxuELbe8JGMivZRApx0IpgXnue2l+2tA=; b=En4XckKRy2XUHcPmxdD3HS/8imGMUX23JA+DVW2whyGf+0TkYT1GxTJToeKg7JxW6sp5YD 5T0JqZyLmOcpT1Iscp4JTrMcF69FqaC2psvhgVarurkbtDHCd+TQMp1LDZQTn6fSMVP84V m2EAoe4FtF7XBLmH+M/XIhq17fudmWBlAwS/Wj97MBQcbsMXbn0E16axGlemoqdzPpyoya fAisPIPcnZTYKVRtov653V9gvO5sDfdIPJe/GZr/3QyP8Ea81PUSS5b6v3GY9CSZBnVm0t RyH6QoClKUE+YOkWoXhtMnMlpeNu/C5hwRwH4GI3lUOr9PNnM21z0cRB9bfj7Q== Date: Tue, 19 Apr 2022 10:26:29 +0200 From: Miquel Raynal To: Liang Yang Cc: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Message-ID: <20220419102629.1c77aa2a@xps13> In-Reply-To: References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_012643_271417_24B822AB X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpsaWFuZy55YW5nQGFtbG9naWMuY29tIHdyb3RlIG9uIE1vbiwgMTggQXByIDIwMjIg MTE6NDA6MTAgKzA4MDA6Cgo+IEhpIE1pcXVlbCwKPiAKPiBpIGhhdmUgc29tZSBjb25mdXNpb24g d2hlbiBpIHByZXBhcmUgdGhlIHBhdGNoZXMuIGZvciBEVCBjb21wYXRpYmlsaXR5LCBpdCBmYWxs cyBiYWNrIHRvIHRoZSBvbGQgRFQgd2hlbiBmYWlsZWQgdG8gZ2V0IHJlc291cmNlIGJ5IHRoZSBu ZXcgRFQsIGJ1dCB0aGVyZSBpcyBzb21lIHBvaW50czoKPiBhLiBvbGQgRFQgZGVwZW5kcyBvbiBN TUMgc3ViIGNsb2NrIGRyaXZlciwgYnV0IGl0IG5ldmVyIGJlIG1lcmdlZCwgc28gaXQgY2FuJ3Qg d29yay4KCkkgZG9uJ3QgZ2V0IHdoYXQgeW91IG1lYW4gaGVyZSwgc29ycnkuIEkgYmVsaWV2ZSB0 aGVyZSBpcyBhIG5ldyB3YXkgdG8KZGVzY3JpYmUgdGhpcyBjbG9jayBidXQgZ3JhYmJpbmcgdGhl IG9uZSBmcm9tIHRoZSBNTUMgc3RpbGwgd29ya3MsIGRvZXMKbm90IGl0PwoKPiBiLiBpZiBpdCBm YWxscyBiYWNrIHRvIHRoZSBvbGQgRFQsIGJlc2lkZSB0aGUgcmVnbWFwIGxvb2t1cCBiZWxvdywg aXQgc2VlbXMgdGhhdCB3ZSBoYXZlIHRvIHByZXNlcnZlIHRoZSBjb2RlIG9mIHRoZSBvbGQgY2xv Y2sgc2V0dGluZyBpbiBuZmNfY2xrX2luaXQoKS4KClllcywgcHJvYmFibHkuCgo+IGRvIHdlIHN0 aWxsIG5lZWQgdG8gYXZvaWQgYnJlYWsgRFQgY29tcGF0aWJpbGl0eT8KCldlIHNob3VsZCB0cnkg b3VyIGJlc3QgdG8gYXZvaWQgYnJlYWtpbmcgdGhlIERULCB5ZXMuCgo+IAo+IFRoYW5rcy4KPiAK PiBPbiAyMDIyLzQvMTEgMTA6NDAsIExpYW5nIFlhbmcgd3JvdGU6Cj4gPj4+IMKgwqDCoMKgwqAg bmZjLT5kZXYgPSBkZXY7Cj4gPj4+IC3CoMKgwqAgcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNl KHBkZXYsIElPUkVTT1VSQ0VfTUVNLCAwKTsKPiA+Pj4gLcKgwqDCoCBuZmMtPnJlZ19iYXNlID0g ZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwgcmVzKTsKPiA+Pj4gK8KgwqDCoCBuZmMtPnJlZ19i YXNlID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCAibmZjIik7 ICAKPiA+Pgo+ID4+IFRoaXMgY2hhbmdlIHNlZW1zIHVucmVsYXRlZC4gIAo+ID4gCj4gPiBUbyBi ZSBjb25zaXN0ZW50IHdpdGggdGhlIGZvbGxvd2luZyA+IGRldm1fcGxhdGZvcm1faW9yZW1hcF9y ZXNvdXJjZV9ieW5hbWUocGRldiwgImVtbWMiKS4gZG8geW91IG1lYW4gdGhhdCB3ZSA+IGRvbid0 IG5lZWQgaXQ/PiAgCj4gPj4+IMKgwqDCoMKgwqAgaWYgKElTX0VSUihuZmMtPnJlZ19iYXNlKSkK PiA+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBQVFJfRVJSKG5mYy0+cmVnX2Jhc2UpOwo+ ID4+PiAtwqDCoMKgIG5mYy0+cmVnX2NsayA9Cj4gPj4+IC3CoMKgwqDCoMKgwqDCoCBzeXNjb25f cmVnbWFwX2xvb2t1cF9ieV9waGFuZGxlKGRldi0+b2Zfbm9kZSwKPiA+Pj4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgImFtbG9naWMsbW1jLXN5c2NvbiIp Owo+ID4+PiAtwqDCoMKgIGlmIChJU19FUlIobmZjLT5yZWdfY2xrKSkgewo+ID4+PiAtwqDCoMKg wqDCoMKgwqAgZGV2X2VycihkZXYsICJGYWlsZWQgdG8gbG9va3VwIGNsb2NrIGJhc2VcbiIpOwo+ ID4+PiAtwqDCoMKgwqDCoMKgwqAgcmV0dXJuIFBUUl9FUlIobmZjLT5yZWdfY2xrKTsKPiA+Pj4g LcKgwqDCoCB9Cj4gPj4+ICvCoMKgwqAgbmZjLT5zZF9lbW1jX2Nsb2NrID0gZGV2bV9wbGF0Zm9y bV9pb3JlbWFwX3Jlc291cmNlX2J5bmFtZShwZGV2LCA+Pj4gImVtbWMiKTsKPiA+Pj4gK8KgwqDC oCBpZiAoSVNfRVJSKG5mYy0+c2RfZW1tY19jbG9jaykpCj4gPj4+ICvCoMKgwqDCoMKgwqDCoCBy ZXR1cm4gUFRSX0VSUihuZmMtPnNkX2VtbWNfY2xvY2spOyAgCj4gPj4KPiA+PiBXaGlsZSBJIGFn cmVlIHRoaXMgaXMgbXVjaCBiZXR0ZXIgdGhhbiB0aGUgcHJldmlvdXMgc29sdXRpb24sIHdlIGNh bm5vdAo+ID4+IGJyZWFrIERUIGNvbXBhdGliaWxpdHksIHNvIHlvdSBuZWVkIHRvIHRyeSBnZXR0 aW5nIHRoZSBlbW1jIGNsb2NrLCBidXQKPiA+PiBpZiBpdCBmYWlscyB5b3Ugc2hvdWxkIGZhbGxi YWNrIHRvIHRoZSByZWdtYXAgbG9va3VwLiAgCj4gPiAKPiA+IG9rLCBpIHdpbGwgZml4IGl0IG5l eHQgdmVyc2lvbi4gdGhhbmtzLgo+ID4gICAKPiA+PiAgCj4gPj4+IMKgwqDCoMKgwqAgaXJxID0g cGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsgIAoKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=