From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C64AC4332F for ; Fri, 22 Apr 2022 22:56:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B1E210E7BD; Fri, 22 Apr 2022 22:56:10 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0E93910E79E for ; Fri, 22 Apr 2022 22:56:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A247BB832FD; Fri, 22 Apr 2022 22:56:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52DAFC385A0; Fri, 22 Apr 2022 22:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650668164; bh=g2fYQ8tm3COkkq2YncBk1OWp9JnooIBSRa7pFk6sT74=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=I5w/7jihsVIOHdNHdwHI9q6Q3q06D2FQZAe4ePmHlq8Cs0+yodwYMKr0jIsf2Vkmm Jf4ihxuZLcR98Mx65WT9JSPWYOglfKPe7ICt7L5stxHkxWZTFuYftbEYuDFQImqDQn 1i+XE8YgLYBABhz4eBXxQEp/fhm0JhSPz7ZRey9SAM/nbzy1z3G9zjmZliTmlLW4/P nQfGdAYBmW4QdM8ISXR0CmEorTRBisnpTsTmczqmOwHvuhhteA92WCWnF10tTOY9Gq nieWy/cGf80AwQf/0pTtF9bdavrHtW13LpQ7tYJ83OLgJECQ5ZBy0rEYe1kJ6zbSf1 GEx+tSzx5mnrA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220419163810.2118169-37-arnd@kernel.org> References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-37-arnd@kernel.org> Subject: Re: [PATCH 36/48] cpufreq: pxa3: move clk register access to clk driver From: Stephen Boyd To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, robert.jarzmik@free.fr Date: Fri, 22 Apr 2022 15:56:02 -0700 User-Agent: alot/0.10 Message-Id: <20220422225604.52DAFC385A0@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar , linux-fbdev@vger.kernel.org, Dominik Brodowski , linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, Tomas Cech , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Helge Deller , Marek Vasut , Paul Parsons , Sergey Lapin , Arnd Bergmann , linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , Lubomir Rintel , Mark Brown , dri-devel@lists.freedesktop.org, Thomas Bogendoerfer , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Arnd Bergmann (2022-04-19 09:37:58) > diff --git a/include/linux/clk/pxa.h b/include/linux/clk/pxa.h > new file mode 100644 > index 000000000000..e5516c608c99 > --- /dev/null > +++ b/include/linux/clk/pxa.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifdef CONFIG_PXA3xx > +extern unsigned pxa3xx_get_clk_frequency_khz(int); What is the spacing about here? > +extern void pxa3xx_clk_update_accr(u32 disable, u32 enable, u32 xclkcfg,= u32 mask); > +#else > +#define pxa3xx_get_clk_frequency_khz(x) (0) > +#define pxa3xx_clk_update_accr(disable, enable, xclkcfg, mask) do { } wh= ile (0) Why not static inline with types? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20F13C433F5 for ; Mon, 25 Apr 2022 13:30:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 58F1F1752; Mon, 25 Apr 2022 15:29:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 58F1F1752 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650893410; bh=g2fYQ8tm3COkkq2YncBk1OWp9JnooIBSRa7pFk6sT74=; h=In-Reply-To:References:Subject:From:To:Date:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aSctaaKD4jHtfqkNr/c4Qi9+HBkzlvxwNtKnntLzELBSML4ioLgdfDyFasT2mv0FY aKwfe2rpi1TsJEBCJVWtOrlC+z3fqE7x2cLchCnOZI7Y8oYWn3sC+QupWIs2iLji4w XNI0G0O1CmD6ls287qqccAuzAmAlbaTqnvIy0GiU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 277B5F8051A; Mon, 25 Apr 2022 15:27:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D9954F80245; Sat, 23 Apr 2022 00:56:11 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 82988F80134 for ; Sat, 23 Apr 2022 00:56:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 82988F80134 Authentication-Results: alsa1.perex.cz; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="I5w/7jih" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A247BB832FD; Fri, 22 Apr 2022 22:56:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52DAFC385A0; Fri, 22 Apr 2022 22:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650668164; bh=g2fYQ8tm3COkkq2YncBk1OWp9JnooIBSRa7pFk6sT74=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=I5w/7jihsVIOHdNHdwHI9q6Q3q06D2FQZAe4ePmHlq8Cs0+yodwYMKr0jIsf2Vkmm Jf4ihxuZLcR98Mx65WT9JSPWYOglfKPe7ICt7L5stxHkxWZTFuYftbEYuDFQImqDQn 1i+XE8YgLYBABhz4eBXxQEp/fhm0JhSPz7ZRey9SAM/nbzy1z3G9zjmZliTmlLW4/P nQfGdAYBmW4QdM8ISXR0CmEorTRBisnpTsTmczqmOwHvuhhteA92WCWnF10tTOY9Gq nieWy/cGf80AwQf/0pTtF9bdavrHtW13LpQ7tYJ83OLgJECQ5ZBy0rEYe1kJ6zbSf1 GEx+tSzx5mnrA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220419163810.2118169-37-arnd@kernel.org> References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-37-arnd@kernel.org> Subject: Re: [PATCH 36/48] cpufreq: pxa3: move clk register access to clk driver From: Stephen Boyd To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, robert.jarzmik@free.fr Date: Fri, 22 Apr 2022 15:56:02 -0700 User-Agent: alot/0.10 Message-Id: <20220422225604.52DAFC385A0@smtp.kernel.org> X-Mailman-Approved-At: Mon, 25 Apr 2022 15:27:43 +0200 Cc: Ulf Hansson , linux-usb@vger.kernel.org, Philipp Zabel , ux-mtd@lists.infradead.org, "Rafael J.Wysocki" , Viresh Kumar , Sergey Lapin , linux-fbdev@vger.kernel.org, Dominik Brodowski , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Tomas Cech , linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, lin@alsa-project.org, Helge Deller , Marek Vasut , Paul Parsons , Linus Walleij , Arnd Bergmann , linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , Lubomir Rintel , Mark Brown , dri-devel@lists.freedesktop.org, Thomas Bogendoerfer , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-mips@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Daniel Mack X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Quoting Arnd Bergmann (2022-04-19 09:37:58) > diff --git a/include/linux/clk/pxa.h b/include/linux/clk/pxa.h > new file mode 100644 > index 000000000000..e5516c608c99 > --- /dev/null > +++ b/include/linux/clk/pxa.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifdef CONFIG_PXA3xx > +extern unsigned pxa3xx_get_clk_frequency_khz(int); What is the spacing about here? > +extern void pxa3xx_clk_update_accr(u32 disable, u32 enable, u32 xclkcfg,= u32 mask); > +#else > +#define pxa3xx_get_clk_frequency_khz(x) (0) > +#define pxa3xx_clk_update_accr(disable, enable, xclkcfg, mask) do { } wh= ile (0) Why not static inline with types?